[asterisk-commits] tilghman: branch 1.6.0 r214703 - in /branches/1.6.0: ./ main/channel.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Fri Aug 28 15:15:51 2009
New Revision: 214703

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=214703
Log:
Merged revisions 214702 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r214702 | tilghman | 2009-08-28 15:14:39 -0500 (Fri, 28 Aug 2009) | 15 lines
  
  Merged revisions 214701 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r214701 | tilghman | 2009-08-28 15:13:32 -0500 (Fri, 28 Aug 2009) | 8 lines
    
    Modify comment to be a bit more accurate.
    We have kept this comment around long enough, that it's pretty clear that we're
    keeping the code, because changing the code would require a pretty fundamental
    architectural shift.  We've also taken criticism in some quarters, because it
    was believed that it was referring to the code being nasty.  No, the code isn't
    nasty, just the operation itself is rather odd.  Fixed for eternity (probably
    not).
  ........
................

Modified:
    branches/1.6.0/   (props changed)
    branches/1.6.0/main/channel.c

Propchange: branches/1.6.0/
------------------------------------------------------------------------------
Binary property 'trunk-merged' - no diff available.

Modified: branches/1.6.0/main/channel.c
URL: http://svn.asterisk.org/svn-view/asterisk/branches/1.6.0/main/channel.c?view=diff&rev=214703&r1=214702&r2=214703
==============================================================================
--- branches/1.6.0/main/channel.c (original)
+++ branches/1.6.0/main/channel.c Fri Aug 28 15:15:51 2009
@@ -4320,10 +4320,10 @@
 	manager_event(EVENT_FLAG_CALL, "Masquerade", "Clone: %s\r\nCloneState: %s\r\nOriginal: %s\r\nOriginalState: %s\r\n",
 		      clone->name, ast_state2str(clone->_state), original->name, ast_state2str(original->_state));
 
-	/* XXX This is a seriously wacked out operation.  We're essentially putting the guts of
-	   the clone channel into the original channel.  Start by killing off the original
-	   channel's backend.   I'm not sure we're going to keep this function, because
-	   while the features are nice, the cost is very high in terms of pure nastiness. XXX */
+	/* XXX This operation is a bit odd.  We're essentially putting the guts of
+	 * the clone channel into the original channel.  Start by killing off the
+	 * original channel's backend.  While the features are nice, which is the
+	 * reason we're keeping it, it's still awesomely weird. XXX */
 
 	/* We need the clone's lock, too */
 	ast_channel_lock(clone);