[asterisk-commits] rmudgett: trunk r212199 - /trunk/channels/chan_misdn.c

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Thu Aug 13 12:33:44 2009
New Revision: 212199

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=212199
Log:
Send a generic return result when we receive a CallDeflection facility message in chan_misdn.

ETSI 300-196 implies that a facility return result without arguments does
not have the operation-value.  This fact implies for ETSI that you can
only use the invoke-id to match requests with responses.

Modified:
    trunk/channels/chan_misdn.c

Modified: trunk/channels/chan_misdn.c
URL: http://svn.asterisk.org/svn-view/asterisk/trunk/channels/chan_misdn.c?view=diff&rev=212199&r1=212198&r2=212199
==============================================================================
--- trunk/channels/chan_misdn.c (original)
+++ trunk/channels/chan_misdn.c Thu Aug 13 12:33:44 2009
@@ -8761,9 +8761,18 @@
 				ast_string_field_set(ch->ast, call_forward, bc->redirecting.to.number);
 
 				/* Send back positive ACK */
+#if 1
+				/*
+				 * Since there are no return result arguments it must be a
+				 * generic result message.  ETSI 300-196
+				 */
+				bc->fac_out.Function = Fac_RESULT;
+				bc->fac_out.u.RESULT.InvokeID = bc->fac_in.u.CallDeflection.InvokeID;
+#else
 				bc->fac_out.Function = Fac_CallDeflection;
 				bc->fac_out.u.CallDeflection.InvokeID = bc->fac_in.u.CallDeflection.InvokeID;
 				bc->fac_out.u.CallDeflection.ComponentType = FacComponent_Result;
+#endif
 				print_facility(&bc->fac_out, bc);
 				misdn_lib_send_event(bc, EVENT_DISCONNECT);