[asterisk-commits] mmichelson: trunk r188585 - in /trunk: ./ main/file.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Wed Apr 15 15:17:33 2009
New Revision: 188585

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=188585
Log:
Merged revisions 188582 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188582 | mmichelson | 2009-04-15 15:04:20 -0500 (Wed, 15 Apr 2009) | 7 lines
  
  Update ast_readvideo_callback to match ast_readaudio_callback.
  
  This fixes potential refcount errors that may occur on ast_filestreams.
  
  AST-208
........

Modified:
    trunk/   (props changed)
    trunk/main/file.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/main/file.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/main/file.c?view=diff&rev=188585&r1=188584&r2=188585
==============================================================================
--- trunk/main/file.c (original)
+++ trunk/main/file.c Wed Apr 15 15:17:33 2009
@@ -778,11 +778,16 @@
 			ast_set_flag(fr, AST_FRFLAG_FROM_FILESTREAM);
 			ao2_ref(s, +1);
 		}
-		if (!fr || ast_write(s->owner, fr)) { /* no stream or error, as above */
-			if (fr)
+		if (!fr /* stream complete */ || ast_write(s->owner, fr) /* error writing */) {
+			if (fr) {
 				ast_log(LOG_WARNING, "Failed to write frame\n");
+				ast_frfree(fr);
+			}
 			s->owner->vstreamid = -1;
 			return FSREAD_FAILURE;
+		}
+		if (fr) {
+			ast_frfree(fr);
 		}
 	}