[asterisk-commits] tilghman: trunk r187363 - in /trunk: ./ apps/app_sendtext.c channels/chan_sip.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Thu Apr  9 11:39:43 2009
New Revision: 187363

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=187363
Log:
Merged revisions 187362 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r187362 | tilghman | 2009-04-09 11:38:37 -0500 (Thu, 09 Apr 2009) | 3 lines
  
  Permit zero-length text messages in SIP.
  (Related to an issue posted to the -users list, subject "AEL2, BASE64_DECODE and hexadecimal")
........

Modified:
    trunk/   (props changed)
    trunk/apps/app_sendtext.c
    trunk/channels/chan_sip.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/apps/app_sendtext.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/apps/app_sendtext.c?view=diff&rev=187363&r1=187362&r2=187363
==============================================================================
--- trunk/apps/app_sendtext.c (original)
+++ trunk/apps/app_sendtext.c Thu Apr  9 11:39:43 2009
@@ -81,7 +81,9 @@
 		AST_APP_ARG(text);
 	);
 
-	if (ast_strlen_zero(data)) {
+	/* NOT ast_strlen_zero, because some protocols (e.g. SIP) MUST be able to
+	 * send a zero-length message. */
+	if (!data) {
 		ast_log(LOG_WARNING, "SendText requires an argument (text)\n");
 		return -1;
 	} else

Modified: trunk/channels/chan_sip.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/channels/chan_sip.c?view=diff&rev=187363&r1=187362&r2=187363
==============================================================================
--- trunk/channels/chan_sip.c (original)
+++ trunk/channels/chan_sip.c Thu Apr  9 11:39:43 2009
@@ -4187,7 +4187,9 @@
 		ast_verbose("Sending text %s on %s\n", text, ast->name);
 	if (!p)
 		return -1;
-	if (ast_strlen_zero(text))
+	/* NOT ast_strlen_zero, because a zero-length message is specifically
+	 * allowed by RFC 3428 (See section 10, Examples) */
+	if (!text)
 		return 0;
 	if (debug)
 		ast_verbose("Really sending text %s on %s\n", text, ast->name);