[asterisk-commits] murf: trunk r143974 - /trunk/

[SVN commits to the Asterisk project]

Author: murf
Date: Tue Sep 23 09:26:32 2008
New Revision: 143974

URL: http://svn.digium.com/view/asterisk?view=rev&rev=143974
Log:
Blocked revisions 143964 via svnmerge

........
r143964 | murf | 2008-09-23 08:22:10 -0600 (Tue, 23 Sep 2008) | 21 lines

In at least one machine, we noted that the timestr
was not getting set in the STMT; it was coming out,
usually, as binary garbage to an mssql server.
These changes fixed the problem. The only thing
I can venture forth as a guess, is that the pointer
is being stored in the interface, not a copy of the
string. Because we ripped the build process into a 
subroutine, the timestr became a temp. stack variable,
and between the time the STMT got built and the
time it was executed on the server, the string being
pointed to was damaged. At any rate, even if this
theory is false, and some mechanism was at fault,
this fix worked reliably where it didn't before.

Why this bug didn't bite last week, I have no idea.
This change basically defines the timestr buffer
in the calling function, extending the life of the
buffer to cover both the STMT's building and
processing to the server.

I AM BLOCKING THIS FIX FROM TRUNK, because we
tested out a trunk release, and it is working
fine.
........

Modified:
    trunk/   (props changed)

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-blocked' - no diff available.