[asterisk-commits] mvanbaak: branch 1.6.0 r143083 - in /branches/1.6.0: ./ channels/chan_skinny.c

[SVN commits to the Asterisk project]

Author: mvanbaak
Date: Sun Sep 14 17:22:48 2008
New Revision: 143083

URL: http://svn.digium.com/view/asterisk?view=rev&rev=143083
Log:
Merged revisions 143082 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r143082 | mvanbaak | 2008-09-15 00:16:34 +0200 (Mon, 15 Sep 2008) | 11 lines
  
  plug a couple of memleaks in chan_skinny.
  
  (closes issue #13452)
  Reported by: pj
  Patches:
        memleak5.diff uploaded by wedhorn (license 30)
  Tested by: wedhorn, pj, mvanbaak
  
  (closes issue #13294)
  Reported by: pj
........

Modified:
    branches/1.6.0/   (props changed)
    branches/1.6.0/channels/chan_skinny.c

Propchange: branches/1.6.0/
------------------------------------------------------------------------------
Binary property 'trunk-merged' - no diff available.

Modified: branches/1.6.0/channels/chan_skinny.c
URL: http://svn.digium.com/view/asterisk/branches/1.6.0/channels/chan_skinny.c?view=diff&rev=143083&r1=143082&r2=143083
==============================================================================
--- branches/1.6.0/channels/chan_skinny.c (original)
+++ branches/1.6.0/channels/chan_skinny.c Sun Sep 14 17:22:48 2008
@@ -1845,7 +1845,7 @@
 	memcpy(s->outbuf+skinny_header_size, &req->data, letohl(req->len));
 
 	res = write(s->fd, s->outbuf, letohl(req->len)+8);
-
+	
 	if (res != letohl(req->len)+8) {
 		ast_log(LOG_WARNING, "Transmit: write only sent %d out of %d bytes: %s\n", res, letohl(req->len)+8, strerror(errno));
 		if (res == -1) {
@@ -1856,6 +1856,7 @@
 		
 	}
 	
+	ast_free(req);
 	ast_mutex_unlock(&s->lock);
 	return 1;
 }
@@ -1953,9 +1954,11 @@
 		req->data.stoptone.reference = htolel(reference);
 	}
 
-	if (tone > 0) {
-		req->data.starttone.tone = htolel(tone);
-	}
+	//Bad, tone is already set so this is redundant and a change to the if above
+	//may lead to issues where we try to set a tone to a stop_tone_message
+	//if (tone > 0) {
+	//	req->data.starttone.tone = htolel(tone);
+	//}
 	transmit_response(s, req);
 }
 
@@ -2019,8 +2022,10 @@
 		if (!(req = req_alloc(0, CLEAR_DISPLAY_MESSAGE)))
 			return;
 
-		req->data.clearpromptstatus.lineInstance = instance;
-		req->data.clearpromptstatus.callReference = reference;
+		//what do we want hear CLEAR_DISPLAY_MESSAGE or CLEAR_PROMPT_STATUS???
+		//if we are clearing the display, it appears there is no instance and refernece info (size 0)
+		//req->data.clearpromptstatus.lineInstance = instance;
+		//req->data.clearpromptstatus.callReference = reference;
 
 		if (skinnydebug)
 			ast_debug(1, "Clearing Display\n");
@@ -3444,6 +3449,7 @@
 		sub->rtp = NULL;
 	}
 	ast_mutex_unlock(&sub->lock);
+	ast_free(sub);
 	return 0;
 }