[asterisk-commits] murf: branch 1.6.1 r142478 - in /branches/1.6.1: ./ main/features.c

[SVN commits to the Asterisk project]

Author: murf
Date: Wed Sep 10 17:18:33 2008
New Revision: 142478

URL: http://svn.digium.com/view/asterisk?view=rev&rev=142478
Log:
Merged revisions 142475 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r142475 | murf | 2008-09-10 16:11:27 -0600 (Wed, 10 Sep 2008) | 38 lines

Merged revisions 142474 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r142474 | murf | 2008-09-10 15:58:17 -0600 (Wed, 10 Sep 2008) | 30 lines

(closes issue #12318)
Reported by: krtorio

I made a small change to the code that handles local channel situations.
In that code, I copy the answer time from the peer cdr, to the bridge_cdr,
but I wasn't also copying the disposition from the peer cdr.

So, Now I copy the disposition, and I've tested against 
these cases:

1. phone 1 never answers the phone; no cdr is generated at all.
   this should show up as a manager command failure or something.

2. phone 2 never answers. CDR is generated, says NO ANSWER

3. phone 2 is busy. CDR is generated, says BUSY

4. phone 2 answers: CDR is generated, times are correct; disposition
   is ANSWERED, which is correct. The start time is the time that
   the manager dialed the first phone. The answer time is the time
   the second phone picks up.

I purposely left the cid and src fields blank; since this call really
originates from the manager, there is no 'easy' data to put in these
fields. If you feel strongly that these fields should be filled in,
re-open this bug and I'll dig further.




........

................

Modified:
    branches/1.6.1/   (props changed)
    branches/1.6.1/main/features.c

Propchange: branches/1.6.1/
------------------------------------------------------------------------------
Binary property 'trunk-merged' - no diff available.

Modified: branches/1.6.1/main/features.c
URL: http://svn.digium.com/view/asterisk/branches/1.6.1/main/features.c?view=diff&rev=142478&r1=142477&r2=142478
==============================================================================
--- branches/1.6.1/main/features.c (original)
+++ branches/1.6.1/main/features.c Wed Sep 10 17:18:33 2008
@@ -2162,6 +2162,8 @@
 		if (peer->cdr && !ast_tvzero(peer->cdr->answer)) {
 			bridge_cdr->answer = peer->cdr->answer;
 			chan->cdr->answer = peer->cdr->answer;
+			bridge_cdr->disposition = peer->cdr->disposition;
+			chan->cdr->disposition = peer->cdr->disposition;
 		} else {
 			ast_cdr_answer(bridge_cdr);
 			ast_cdr_answer(chan->cdr); /* for the sake of cli status checks */