[asterisk-commits] russell: tag 1.4.22-rc4 r141743 - /tags/1.4.22-rc4/
SVN commits to the Asterisk project
asterisk-commits at lists.digium.com
Mon Sep 8 15:17:21 CDT 2008
Author: russell
Date: Mon Sep 8 15:17:21 2008
New Revision: 141743
URL: http://svn.digium.com/view/asterisk?view=rev&rev=141743
Log:
Importing files for 1.4.22-rc4 release
Added:
tags/1.4.22-rc4/.lastclean (with props)
tags/1.4.22-rc4/.version (with props)
tags/1.4.22-rc4/ChangeLog (with props)
Added: tags/1.4.22-rc4/.lastclean
URL: http://svn.digium.com/view/asterisk/tags/1.4.22-rc4/.lastclean?view=auto&rev=141743
==============================================================================
--- tags/1.4.22-rc4/.lastclean (added)
+++ tags/1.4.22-rc4/.lastclean Mon Sep 8 15:17:21 2008
@@ -1,0 +1,1 @@
+32
Propchange: tags/1.4.22-rc4/.lastclean
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: tags/1.4.22-rc4/.lastclean
------------------------------------------------------------------------------
svn:keywords = none
Propchange: tags/1.4.22-rc4/.lastclean
------------------------------------------------------------------------------
svn:mime-type = text/plain
Added: tags/1.4.22-rc4/.version
URL: http://svn.digium.com/view/asterisk/tags/1.4.22-rc4/.version?view=auto&rev=141743
==============================================================================
--- tags/1.4.22-rc4/.version (added)
+++ tags/1.4.22-rc4/.version Mon Sep 8 15:17:21 2008
@@ -1,0 +1,1 @@
+1.4.22-rc4
Propchange: tags/1.4.22-rc4/.version
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: tags/1.4.22-rc4/.version
------------------------------------------------------------------------------
svn:keywords = none
Propchange: tags/1.4.22-rc4/.version
------------------------------------------------------------------------------
svn:mime-type = text/plain
Added: tags/1.4.22-rc4/ChangeLog
URL: http://svn.digium.com/view/asterisk/tags/1.4.22-rc4/ChangeLog?view=auto&rev=141743
==============================================================================
--- tags/1.4.22-rc4/ChangeLog (added)
+++ tags/1.4.22-rc4/ChangeLog Mon Sep 8 15:17:21 2008
@@ -1,0 +1,20095 @@
+2008-09-08 Russell Bryant <russell at digium.com>
+
+ * Asterisk 1.4.22-rc4 released.
+
+2008-09-08 20:15 +0000 [r141741] Jason Parker <jparker at digium.com>
+
+ * Makefile, redhat (removed): Remove RPM package targets from
+ Makefile (and all associated parts). This has never worked in
+ 1.4, and we decided that it makes no sense to be done here. There
+ are many distros out there that already have "proper" spec files
+ that can be (re)used. Closes issue #13113 Closes issue #10950
+ Closes issue #10952
+
+2008-09-08 16:26 +0000 [r141678] Russell Bryant <russell at digium.com>
+
+ * configure, configure.ac: Actually use Zaptel CFLAGS if using
+ Zaptel instead of DAHDI This fixes building against Zaptel when
+ using a custom path
+
+2008-09-06 20:13 +0000 [r141565] Steve Murphy <murf at digium.com>
+
+ * channels/chan_sip.c: This fix comes from Joshua Colp The
+ Brilliant, who, given the trace, came up with a solution. This
+ will most likely will close 13235 and 13409. I'll wait till
+ Monday to verify, and then close these bugs.
+
+2008-09-06 15:23 +0000 [r141503] Tilghman Lesher <tlesher at digium.com>
+
+ * res/res_agi.c: Reverting behavior change (AGI should not exit
+ non-zero on SUCCESS) (closes issue #13434) Reported by:
+ francesco_r
+
+2008-09-05 21:10 +0000 [r141217-141366] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_agent.c: Agent's should not try to call a channel's
+ indicate callback if the channel has been hung up. It will likely
+ crash otherwise ABE-1159
+
+ * apps/app_voicemail.c: Since greetings are not stored in IMAP, we
+ should not be DISPOSE'ing of them the same way we do with other
+ messages. (closes issue #13414) Reported by: mthomasslo Patches:
+ 13414v2.patch uploaded by putnopvut (license 60) Tested by:
+ mthomasslo
+
+ * channels/chan_sip.c: Commit 140417 had a logic flaw in it which
+ caused port 5060 to always be used when dialing a peer if no
+ explicit port was specified. This broke the behavior of
+ implicitly using the port from which the peer registered if no
+ port is specified. This commit fixes the logic flaw. (closes
+ issue #13424) Reported by: mdu113 Patches: 13424.patch uploaded
+ by putnopvut (license 60) Tested by: mdu113
+
+2008-09-05 14:15 +0000 [r141094-141156] Steve Murphy <murf at digium.com>
+
+ * main/channel.c: A small change to prevent double-posting of
+ CDR's; thanks to Daniel Ferrer for bringing it to our attention
+
+ * pbx/ael/ael-test/ref.ael-vtest25 (added),
+ pbx/ael/ael-test/ael-vtest25/extensions.ael (added),
+ pbx/ael/ael-test/ael-vtest25 (added), pbx/ael/ael_lex.c,
+ pbx/ael/ael-test/ref.ael-test6, pbx/ael/ael.flex: (closes issue
+ #13357) Reported by: pj Tested by: murf (closes issue #13416)
+ Reported by: yarns Tested by: murf If you find this message
+ overly verbose, relax, it's probably not meant for you. This
+ message is meant for probably only two people in the whole world:
+ me, or the poor schnook that has to maintain this code because
+ I'm either dead or unavailable at the moment. This fix solves two
+ reports, both having to do with embedding a function call in a
+ ${} construct. It was tricky because the funccall syntax has
+ parenthesis () in it. And up till now, the 'word' token in the
+ flex stuff didn't allow that, because it would tend to steal the
+ LP and RP tokens. To be truthful, the "word" token was the
+ trickiest, most unstable thing in the whole lexer. I was lucky it
+ made this long without complaints. I had to choose every
+ character in the pattern with extreme care, and I knew that
+ someday I'd have to revisit it. Well, the day has come. So, my
+ brilliant idea (and I'm being modest), was to use the surrounding
+ ${} construct to make a state machine and capture everything in
+ it, no matter what it contains. But, I have to now treat the word
+ token like I did with comments, in that I turn the whole thing
+ into a state-machine sort of spec, with new contexts
+ "curlystate", "wordstate", and "brackstate". Wait a minute,
+ "brackstate"? Yes, well, it didn't take very many regression
+ tests to point out if I do this for ${} constructs, I also have
+ to do it with the $[] constructs, too. I had to create a separate
+ pcbstack2 and pcbstack3 because these constructs can occur inside
+ macro argument lists, and when we have two state machines
+ operating on the same structures we'd get problems otherwise. I
+ guess I could have stopped at pcbstack2 and had the brackstate
+ stuff share it, but it doesn't hurt to be safe. So, the pcbpush
+ and pcbpop routines also now have versions for "2" and "3". I had
+ to add the {KEYWORD} construct to the initial pattern for "word",
+ because previously word would match stuff like "default7",
+ because it was a longer match than the keyword "default". But,
+ not any more, because the word pattern only matches only one or
+ two characters now, and it will always lose. So, I made it the
+ winner again by making an optional match on any of the keywords
+ before it's normal pattern. I added another regression test to
+ make sure we don't lose this in future edits, and had to fix just
+ one regression, where it no longer reports a 'cascaded' error,
+ which I guess is a plus. I've given some thought as to whether to
+ apply these fixes to 1.4 and the 1.6.x releases, vs trunk; I
+ decided to put it in 1.4 because one of the bug reports was
+ against 1.4; and it is unexpected that AEL cannot handle this
+ situation. It actually reduced the amount of useless "cascade"
+ error messages that appeared in the regressions (by one line,
+ ehhem). There is a possible side-effect in that it does now do
+ more careful checking of what's in those ${} constructs, as far
+ as matching parens, and brackets are concerned. Some users may
+ find a an insidious problem and correct it this way. This should
+ be exceedingly rare, I hope.
+
+2008-09-04 17:00 +0000 [r141028] Jeff Peeler <jpeeler at digium.com>
+
+ * res/res_features.c, res/res_agi.c: (closes issue #11979) Fixes
+ multiple parking problems: Crash when executing a park on an
+ extension dialed by AGI due to not returning the proper return
+ code. Crash when using a builtin feature that was a subset of a
+ enabled dynamic feature. Crash due to always hanging up the peer
+ despite the fact that the peer was supposed to be parked.
+
+2008-09-03 Russell Bryant <russell at digium.com>
+
+ * Asterisk 1.4.22-rc3 released.
+
+2008-09-03 14:29 +0000 [r140850] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_voicemail.c: Fix voicemail forwarding when using ODBC
+ storage. (closes issue #13387) Reported by: moliveras Patches:
+ 13387.patch uploaded by putnopvut (license 60) Tested by:
+ putnopvut, moliveras
+
+2008-09-03 13:24 +0000 [r140816] Russell Bryant <russell at digium.com>
+
+ * main/poll.c: Don't freak out if the poll emulation receives NULL
+ for the pollfds array (closes issue #13307) Reported by: jcovert
+
+2008-09-02 23:47 +0000 [r140751] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_voicemail.c: After adding the context checking to
+ app_voicemail for IMAP storage, I left out a crucial place to
+ copy the context to the vm_state structure. This is the
+ correction.
+
+2008-09-02 23:36 +0000 [r140670-140747] Steve Murphy <murf at digium.com>
+
+ * main/cdr.c: I am turning the warnings generated in ast_cdr_free
+ and post_cdr into verbose level 2 messages. Really, they matter
+ little to end users. You either get the CDR's you wanted, or you
+ don't, and it is a bug.
+
+ * main/channel.c: After reconsidering, with respect to 13409,
+ ast_cdr_detach should be OK, better in fact, than ast_cdr_free,
+ which generates lots of useless warnings that will undoubtably
+ generate complaints.
+
+ * main/channel.c, main/pbx.c: (closes issue #13409) Reported by:
+ tomaso Patches: asterisk-1.6.0-rc2-cdrmemleak.patch uploaded by
+ tomaso (license 564) I basically spent the day, verifying that
+ this patch solves the problem, and doesn't hurt in non-problem
+ cases. Why valgrind did not plainly reveal this leak absolutely
+ mystifies and stuns me. Many, many thanks to tomaso for finding
+ and providing the fix.
+
+2008-09-02 18:14 +0000 [r140605] Sean Bright <sean.bright at gmail.com>
+
+ * channels/chan_iax2.c: Make sure to use the correct length of the
+ mohinterpret and mohsuggest buffers when copying configuration
+ values. (closes issue #13336) Reported by:
+ decryptus_proformatique Patches:
+ chan_iax2_mohinterpret_mohsuggest_general_settings.patch uploaded
+ by decryptus (license 555)
+
+2008-08-29 17:34 +0000 [r140417-140488] Mark Michelson <mmichelson at digium.com>
+
+ * main/manager.c, apps/app_queue.c, channels/chan_iax2.c: After
+ working on the ao2_containers branch, I noticed something a bit
+ strange. In all cases where we provide a callback function to
+ ao2_container_alloc, the callback function would only return 0 or
+ CMP_MATCH. After inspecting the ao2_callback() code carefully, I
+ found that if you're only looking for one specific item, then you
+ should return CMP_MATCH | CMP_STOP. Otherwise, astobj2 will
+ continue traversing the current bucket until the end searching
+ for more matches. In cases like chan_iax2 where in 1.4, all the
+ peers are shoved into a single bucket, this makes for potentially
+ terrible performance since the entire bucket will be traversed
+ even if the peer is one of the first ones come across in the
+ bucket. All the changes I have made were for cases where the
+ callback function defined was passed to ao2_container_alloc so
+ that calls to ao2_find could find a unique instance of whatever
+ object was being stored in the container.
+
+ * apps/app_voicemail.c: Add context checking when retrieving a
+ vm_state. This was causing a problem for people who had
+ identically named mailboxes in separate voicemail contexts. This
+ commit affects IMAP storage only. (closes issue #13194) Reported
+ by: moliveras Patches: 13194.patch uploaded by putnopvut (license
+ 60) Tested by: putnopvut, moliveras
+
+ * channels/chan_sip.c: Fix SIP's parsing so that if a port is
+ specified in a string to Dial(), it is not ignored. (closes issue
+ #13355) Reported by: acunningham Patches: 13355v2.patch uploaded
+ by putnopvut (license 60) Tested by: acunningham
+
+2008-08-27 19:49 +0000 [r140299] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_sip.c: Fix tag checking in get_sip_pvt_byid_locked
+ when in pedantic mode. The problem was that the wrong tags would
+ be compared depending on the direction of the call. (closes issue
+ #13353) Reported by: flefoll Patches:
+ chan_sip.c.br14.139015.patch-refer-pedantic uploaded by flefoll
+ (license 244)
+
+2008-08-26 16:49 +0000 [r140115] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: add HAVE_PRI if define around
+ dahdi_close_pri_fd
+
+2008-08-26 16:07 +0000 [r140060] Russell Bryant <russell at digium.com>
+
+ * channels/chan_sip.c: Fix some bogus scheduler usage in chan_sip.
+ This code used the return value of a completely unrelated
+ function to determine whether the scheduler should be run or not.
+ This would have caused the scheduler to not run in cases where it
+ should have. Also, leave a note about another scheduler issue
+ that needs to be addressed at some point.
+
+2008-08-26 15:57 +0000 [r140056] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: (closes issue #12071) Reported by: tzafrir
+ Patches: dahdi_close.diff uploaded by tzafrir (license 46) Tested
+ by: tzafrir, jpeeler This patch fixes closing open file
+ descriptors in the case of an error.
+
+2008-08-26 15:27 +0000 [r140051] Russell Bryant <russell at digium.com>
+
+ * channels/chan_iax2.c: Fix a race condition with the IAX scheduler
+ thread. A lock and condition are used here to allow newly
+ scheduled tasks to wake up the scheduler just in case the new
+ task needs to run sooner than the current wakeup time when the
+ thread is sleeping. However, there was a race condition such that
+ a newly scheduled task would not properly wake up the scheduler
+ or affect the wake up period. The order of execution would have
+ been: 1) Scheduler thread determines wake up time of N ms. 2)
+ Another thread schedules a task and signals the condition, with
+ an execution time of < N ms. 3) Scheduler thread locks and goes
+ to sleep for N ms. By moving the sleep time determination to
+ inside the critical section, this possibility is avoided.
+
+2008-08-26 15:22 +0000 [r140050] Terry Wilson <twilson at digium.com>
+
+ * Makefile: sounds/Makefile installs sounds using the "new"
+ language directory structure, but languageprefix needs to be set
+ = yes for sounds in subdirectories (digits/1, etc.) to play as
+ the correct language. Fix the generation of asterisk.conf to
+ include languageprefix=yes
+
+2008-08-26 14:09 +0000 [r140029] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: correct a file location in an error
+ message
+
+2008-08-25 21:47 +0000 [r139927] Jeff Peeler <jpeeler at digium.com>
+
+ * main/manager.c: Fix a typo I made. Lesson learned, apply the
+ patch if one exists.
+
+2008-08-25 21:31 +0000 [r139909] Sean Bright <sean.bright at gmail.com>
+
+ * build_tools/get_moduleinfo, build_tools/get_makeopts: Some
+ versions of awk (nawk, for example) don't like empty regular
+ expressions so be slightly more verbose. (closes issue #13374)
+ Reported by: dougm Patches: 13374.diff uploaded by seanbright
+ (license 71) Tested by: dougm
+
+2008-08-25 20:46 +0000 [r139869] Terry Wilson <twilson at digium.com>
+
+ * channels/chan_sip.c: Make SIPADDHEADER() propagate indefinitely
+
+2008-08-25 15:52 +0000 [r139769] Mark Michelson <mmichelson at digium.com>
+
+ * main/config.c: Fix the logic in config_text_file_save so that if
+ an UpdateConfig manager action is issued and the file specified
+ in DstFileName does not yet exist, an error is not returned.
+ (closes issue #13341) Reported by: vadim Patches: 13341.patch
+ uploaded by putnopvut (license 60) (with small modification from
+ seanbright)
+
+2008-08-25 15:33 +0000 [r139764] Steve Murphy <murf at digium.com>
+
+ * main/pbx.c, res/res_features.c: This patch reverts the changes
+ made via 139347, and 139635, as users are seeing adverse
+ difference. I will un-close 13251. Back to the drawing board/
+ concept/ beginning/ whatever!
+
+2008-08-22 22:24 +0000 [r139635] Steve Murphy <murf at digium.com>
+
+ * res/res_features.c: I found some problems with the code I
+ committed earlier, when I merged them into trunk, so I'm coming
+ back to clean up. And, in the process, I found an error in the
+ code I added to trunk and 1.6.x, that I'll fix using this patch
+ also.
+
+2008-08-22 21:36 +0000 [r139621] Jeff Peeler <jpeeler at digium.com>
+
+ * main/manager.c: (closes issue #13359) Reported by: Laureano
+ Patches: originate_channel_check.patch uploaded by Laureano
+ (license 265)
+
+2008-08-22 19:45 +0000 [r139456-139553] Mark Michelson <mmichelson at digium.com>
+
+ * include/asterisk/threadstorage.h: Fix compilation when
+ DEBUG_THREAD_LOCALS is selected (closes issue #13298) Reported
+ by: snuffy Patches: bug13298_20080822.diff uploaded by snuffy
+ (license 35)
+
+ * main/frame.c: Remove show_frame_stats_deprecated since it is not
+ used anywhere and causes build errors if building under dev-mode
+ with TRACE_FRAMES selected in menuselect. (closes issue #13362)
+ Reported by: snuffy
+
+ * channels/chan_iax2.c: Fix the build. Thanks, mvanbaak!
+
+ * channels/chan_iax2.c: Prevent a deadlock in chan_iax2 resulting
+ from incorrect locking order between iax2_pvt and ast_channel
+ structures. AST-13
+
+2008-08-21 23:39 +0000 [r139387] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: Fixes loop that could possibly never exit
+ in the event of a channel never being able to be opened or
+ specify after a restart. (closes issue #11017)
+
+2008-08-21 23:03 +0000 [r139347] Steve Murphy <murf at digium.com>
+
+ * main/pbx.c, res/res_features.c: (closes issue #13251) Reported
+ by: sergee Tested by: murf THis is a bold move for a static
+ release fix, but I wouldn't have made it if I didn't feel
+ confident (at least a *bit* confident) that it wouldn't mess
+ everyone up. The reasoning goes something like this: 1. We simply
+ cannot do anything with CDR's at the current point (in pbx.c,
+ after the __ast_pbx_run loop). It's way too late to have any
+ affect on the CDRs. The CDR is already posted and gone, and the
+ remnants have been cleared. 2. I was very much afraid that moving
+ the running of the 'h' extension down into the bridge code (where
+ it would be now practical to do it), would result in a lot more
+ calls to the 'h' exten, so I implemented it as another exten
+ under another name, but found, to my pleasant surprise, that
+ there was a 1:1 correspondence to the running of the 'h' exten in
+ the pbx_run loop, and the new spot at the end of the bridge. So,
+ I ifdef'd out the current 'h' loop, and moved it into the bridge
+ code. The only difference I can see is the stuff about the
+ AST_PBX_KEEPALIVE, and hopefully, if this is still an important
+ decision point, I can replicate it if there are complaints. To be
+ perfectly honest, the KEEPALIVE situation is not totally clear to
+ me, and how it relates to a post-bridge situation is less clear.
+ I suspect the users will point out everything in total clarity if
+ this steps on anyone's toes! 3. I temporarily swap the bridge_cdr
+ into the channel before running the 'h' exten, which makes it
+ possible for users to edit the cdr before it goes out the door.
+ And, of course, with the endbeforehexten config var set, the
+ users can also get at the billsec/duration vals. After the h
+ exten finishes, the cdr is swapped back and processing continues
+ as normal. Please, all who deal with CDR's, please test this
+ version of Asterisk, and file bug reports as appropriate!
+
+2008-08-21 10:11 +0000 [r139283] Philippe Sultan <philippe.sultan at gmail.com>
+
+ * channels/chan_gtalk.c: Apply fix for issue #13310 to branch 1.4,
+ too.
+
+2008-08-20 22:14 +0000 [r139213] Russell Bryant <russell at digium.com>
+
+ * apps/app_chanspy.c: Fix a crash in the ChanSpy application. The
+ issue here is that if you call ChanSpy and specify a spy group,
+ and sit in the application long enough looping through the
+ channel list, you will eventually run out of stack space and the
+ application with exit with a seg fault. The backtrace was always
+ inside of a harmless snprintf() call, so it was tricky to track
+ down. However, it turned out that the call to snprintf() was just
+ the biggest stack consumer in this code path, so it would always
+ be the first one to hit the boundary. (closes issue #13338)
+ Reported by: ruddy
+
+2008-08-20 19:52 +0000 [r139151] Shaun Ruffell <sruffell at digium.com>
+
+ * codecs/codec_dahdi.c: Fix bug where the samples were not accurate
+ when in G723 mode, which would cause the timestamp field of the
+ RTP header to be invalid.
+
+2008-08-20 19:35 +0000 [r139145] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c, configure,
+ include/asterisk/autoconfig.h.in, configure.ac: Backport support
+ for Zaptel/DAHDI channel-level alarms from trunk/1.6, because not
+ doing so just makes it difficult for people with channels that
+ are in alarm when Asterisk starts up to get them going once the
+ alarm is cleared (closes issue #12160) Reported by: tzafrir
+ Patches: asterisk-chanalarms_14.patch uploaded by tzafrir
+ (license 46) Tested by: tzafrir
+
+2008-08-20 17:14 +0000 [r139074] Steve Murphy <murf at digium.com>
+
+ * main/cdr.c: (closes issue #13263) Reported by: brainy Tested by:
+ murf The specialized reset routine is tromping on the flags field
+ of the CDR. I made a change to not reset the DISABLED bit. This
+ should get rid of this problem.
+
+2008-08-20 15:37 +0000 [r139015] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_sip.c: sip_read should properly handle a NULL
+ return from sip_rtp_read. (closes issue #13257) Reported by:
+ travishein
+
+2008-08-19 23:22 +0000 [r138949] Jeff Peeler <jpeeler at digium.com>
+
+ * include/asterisk/dahdi_compat.h: add DAHDI_POLICY_WHEN_FULL
+ compatability define for Zaptel
+
+2008-08-19 23:17 +0000 [r138942] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_agent.c: Reset agent_pvt variables back to the
+ values in agents.conf (from what the corresponding channel
+ variables were set to) when the agent logs out. (closes issue
+ #13098) Reported by: davidw Patches:
+ 20080731__issue13098_agent_ackcall_not_reset.diff uploaded by
+ bbryant (license 36) Tested by: davidw
+
+2008-08-19 22:56 +0000 [r138938] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: Add configuration option to
+ chan_dahdi.conf to allow buffering policy and number of buffers
+ to be configured per channel. Syntax: buffers=<num of
+ buffers>,<policy> Where the number of buffers is some
+ non-negative integer and the policy is either "full", "half", or
+ "immediate".
+
+2008-08-19 18:50 +0000 [r138685-138886] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_chanspy.c: Add a lock and unlock prior to the
+ destruction of the chanspy_ds lock to ensure that no other
+ threads still have it locked. While this should not happen under
+ normal circumstances, it appears that if the spyer and spyee hang
+ up at nearly the same time, the following may occur. 1.
+ ast_channel_free is called on the spyee's channel. 2. The chanspy
+ datastore is removed from the spyee's channel in
+ ast_channel_free. 3. In the spyer's thread, the spyer attempts to
+ remove and destroy the datastore from the spyee channel, but the
+ datastore has already been removed in step 2, so the spyer
+ continues in the code. 4. The spyee's thread continues and calls
+ the datastore's destroy callback, chanspy_ds_destroy. This
+ involves locking the chanspy_ds. 5. Now the spyer attempts to
+ destroy the chanspy_ds lock. The problem is that in step 4, the
+ spyee has locked this lock, meaning that the spyer is attempting
+ to destroy a lock which is currently locked by another thread.
+ The backtrace provided in issue #12969 supports the idea that
+ this is possible (and has even occurred). This commit does not
+ close the issue, but should help in preventing one type of crash
+ associated with the use of app_chanspy.
+
+ * apps/app_queue.c: Change the inequalities used in app_queue with
+ regards to timeouts from being strict to non-strict for more
+ accuracy. (closes issue #13239) Reported by: atis Patches:
+ app_queue_timeouts_v2.patch uploaded by atis (license 242)
+
+2008-08-18 16:57 +0000 [r138663] Kevin P. Fleming <kpfleming at digium.com>
+
+ * codecs/codec_dahdi.c: look for transcoder in proper place based
+ on build against Zaptel or DAHDI
+
+2008-08-18 11:57 +0000 [r138569] Sean Bright <sean.bright at gmail.com>
+
+ * channels/chan_dahdi.c: You know what's awesome? Code that
+ compiles... ;)
+
+2008-08-18 02:05 +0000 [r138516] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: fix compilation warnings
+
+2008-08-16 01:12 +0000 [r138309-138360] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: fixes use count to properly decrement if
+ an active dahdi channel is destroyed allowing module to be
+ unloaded
+
+ * channels/chan_dahdi.c: add forgotten locks around ss_thread_count
+ in ss_thread for dahdi restart
+
+2008-08-15 22:33 +0000 [r138258] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_sip.c, configs/sip.conf.sample: More fixes for
+ realtime peers. (closes issue #12921) Reported by: Nuitari
+ Patches: 20080804__bug12921.diff.txt uploaded by Corydon76
+ (license 14) 20080815__bug12921.diff.txt uploaded by Corydon76
+ (license 14) Tested by: Corydon76
+
+2008-08-15 21:28 +0000 [r138119-138238] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: initialize condition variable
+ ss_thread_complete using ast_cond_init
+
+ * channels/chan_dahdi.c: declared static mutexes using
+ AST_MUTEX_DEFINE_STATIC macro
+
+ * channels/chan_dahdi.c: Fixes the dahdi restart functionality.
+ Dahdi restart allows one to restart all DAHDI channels, even if
+ they are currently in use. This is different from unloading and
+ then loading the module since unloading requires the use count to
+ be zero. Reloading the module is different in that the signalling
+ is not changed from what it was originally configured. Also, this
+ fixes not closing all the file descriptors for D-channels upon
+ module unload (which would prevent loading the module
+ afterwards). (closes issue #11017)
+
+2008-08-15 15:07 +0000 [r138027] Russell Bryant <russell at digium.com>
+
+ * main/autoservice.c: Ensure that when a hangup occurs in
+ autoservice, that a hangup frame gets properly deferred to be
+ read from the channel owner when it gets taken out of
+ autoservice. (closes issue #12874) Reported by: dimas Patches:
+ v1-12874.patch uploaded by dimas (license 88)
+
+2008-08-15 14:51 +0000 [r137847-138023] Tilghman Lesher <tlesher at digium.com>
+
+ * funcs/func_strings.c: Additional check for more string specifiers
+ than arguments. (closes issue #13299) Reported by: adomjan
+ Patches: 20080813__bug13299.diff.txt uploaded by Corydon76
+ (license 14) func_strings.c-sprintf.patch uploaded by adomjan
+ (license 487) Tested by: adomjan
+
+ * channels/chan_dahdi.c: Oops, wrong direction
+
+ * channels/chan_dahdi.c: When creating the secondary subchannel
+ name, it is necessary to compare to the existing channel name
+ without the "Zap/" or "DAHDI/" prefix, since our test string is
+ also without that prefix. (closes issue #13027) Reported by:
+ dferrer Patches: chan_zap-1.4.21.1_fix2.patch uploaded by dferrer
+ (license 525) (Slightly modified by me, to compensate for both
+ names)
+
+2008-08-14 14:05 +0000 [r137731] Russell Bryant <russell at digium.com>
+
+ * configs/sip.conf.sample: Comments in this config file were
+ aligned only if your tab size was set to 8. So, convert tabs to
+ spaces so that things should be aligned regardless of what tab
+ size you use in your editor.
+
+2008-08-14 02:03 +0000 [r137677-137679] Kevin P. Fleming <kpfleming at digium.com>
+
+ * Zaptel-to-DAHDI.txt: forgot one module name that changed
+
+ * include/asterisk/dahdi_compat.h, channels/chan_dahdi.c,
+ build_tools/menuselect-deps.in, configure, configure.ac,
+ codecs/codec_dahdi.c: add support for Zaptel versions that
+ contain the new transcoder interface
+
+2008-08-13 21:35 +0000 [r137580] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: Register DAHDISendKeypadFacility
+ application if dahdi_chan_mode is set to DAHDI + Zap. Mark
+ ZapSendKeypadFacility application as deprecated on usage.
+
+2008-08-13 20:46 +0000 [r137527-137530] Kevin P. Fleming <kpfleming at digium.com>
+
+ * Zaptel-to-DAHDI.txt (added): add document describing what users
+ will need to be aware of when upgrading to this version and using
+ DAHDI
+
+ * apps/app_meetme.c: remove some more chan_zap references
+
+ * doc/asterisk-conf.txt, channels/chan_dahdi.c: document
+ dahdichanname option in doc/asterisk-conf.txt make chan_dahdi
+ read its configuration from zapata.conf if dahdichanname has been
+ set to 'no'
+
+2008-08-13 14:33 +0000 [r137348-137405] Sean Bright <sean.bright at gmail.com>
+
+ * doc/cdrdriver.txt: Update docs to reflect the change to cdr_tds
+
+ * cdr/cdr_tds.c: Bring cdr_tds in line with the other CDR backends
+ and have it try to store CDR(userfield) if it is set. The new
+ behavior is to check for the userfield column on module load, and
+ if it exists, we will store CDR(userfield) when CDRs are written.
+ A similar patch already went into trunk and 1.6.0. (closes issue
+ #13290) Reported by: falves11
+
+2008-08-11 13:33 +0000 [r137188] Kevin P. Fleming <kpfleming at digium.com>
+
+ * apps/app_meetme.c: convert this module to be able to handle DAHDI
+ or Zaptel (reported on asterisk-users, don't know how this got
+ missed before)
+
+2008-08-11 00:20 +0000 [r137138] Tilghman Lesher <tlesher at digium.com>
+
+ * res/res_odbc.c: Deallocate database connection handle on
+ disconnect, as we allocate another one on connect. (closes issue
+ #13271) Reported by: dveiga
+
+2008-08-09 17:11 +0000 [r136999] Russell Bryant <russell at digium.com>
+
+ * configure, configure.ac: Ensure PBX_DAHDI_TRANSCODE will evaluate
+ to 0 if not found instead of empty. pointed out by tzafrir on
+ #asterisk-dev
+
+2008-08-09 15:25 +0000 [r136946] Tilghman Lesher <tlesher at digium.com>
+
+ * /, include/asterisk/compat.h, include/asterisk/astobj2.h: Merged
+ revisions 136945 via svnmerge from
+ https://origsvn.digium.com/svn/asterisk/branches/1.2 ........
+ r136945 | tilghman | 2008-08-09 10:24:36 -0500 (Sat, 09 Aug 2008)
+ | 2 lines Regression fixes for Solaris ........
+
+2008-08-08 00:15 +0000 [r136726] Steve Murphy <murf at digium.com>
+
+ * pbx/ael/ael-test/ref.ael-test8, pbx/ael/ael-test/ref.ael-test18,
+ pbx/ael/ael-test/ref.ael-vtest13,
+ pbx/ael/ael-test/ref.ael-ntest10, pbx/pbx_ael.c,
+ include/asterisk/ael_structs.h: (closes issue #13236) Reported
+ by: korihor Wow, this one was a challenge! I regrouped and ran a
+ new strategy for setting the ~~MACRO~~ value; I set it once per
+ extension, up near the top. It is only set if there is a switch
+ in the extension. So, I had to put in a chunk of code to detect a
+ switch in the pval tree. I moved the code to insert the set of
+ ~~exten~~ up to the beginning of the gen_prios routine, instead
+ of down in the switch code. I learned that I have to push the
+ detection of the switches down into the code, so everywhere I
+ create a new exten in gen_prios, I make sure to pass onto it the
+ values of the mother_exten first, and the exten next. I had to
+ add a couple fields to the exten struct to accomplish this, in
+ the ael_structs.h file. The checked field makes it so we don't
+ repeat the switch search if it's been done. I also updated the
+ regressions.
+
+2008-08-07 18:25 +0000 [r136560] Kevin P. Fleming <kpfleming at digium.com>
+
+ * build_tools/menuselect-deps.in, configure, configure.ac: change
+ the required dependency for codec_dahdi to only be satisfied by
+ DAHDI and not Zaptel, as the new transcoder interface is only in
+ DAHDI
+
+2008-08-07 18:14 +0000 [r136544] Shaun Ruffell <sruffell at digium.com>
+
+ * codecs/codec_dahdi.c: Updated codec_dahdi to use the new
+ transcoder interface in the first DAHDI release. Codec dahdi no
+ longer functions with the transcoder interface in zaptel at this
+ time (which the last zaptel release was 1.4.11). NOTE: Still
+ needs an update to the configure script to make sure that
+ codec_dahdi is only built if the new transcoder interface is
+ present in the drivers. (Issue: DAHDI-42)
+
+2008-08-07 16:50 +0000 [r136488] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_queue.c: Update persistent state on all exit conditions.
+ (closes issue #12916) Reported by: sgenyuk Patches:
+ app_queue.patch.txt uploaded by neutrino88 (license 297) Tested
+ by: sgenyuk, aragon
+
+2008-08-07 16:30 +0000 [r136404-136484] Kevin P. Fleming <kpfleming at digium.com>
+
+ * include/asterisk/doxyref.h: add a raw list of all libraries that
+ any part of Asterisk links directly to
+
+ * apps/app_voicemail.c: work around a bug in gcc-4.2.3 that
+ incorrectly ignores the casting away of 'const' for pointers when
+ the developer knows it is safe to do so
+
+ * Makefile: remove config.cache during distclean, in case the user
+ is using autoconf caching
+
+2008-08-07 01:31 +0000 [r136304-136348] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_dahdi.c: Also, parse
+ useincomingcalleridonzaptransfer (and add appropriate deprecation
+ warnings).
+
+ * channels/chan_dahdi.c: For backwards compatibility with previous
+ 1.4 versions which used "zapchan" in users.conf, ensure that we
+ still support it.
+
+2008-08-06 21:18 +0000 [r136241] Richard Mudgett <rmudgett at digium.com>
+
+ * channels/misdn_config.c, channels/chan_misdn.c,
+ configs/misdn.conf.sample: * The allowed_bearers setting in
+ misdn.conf misspelled one of its options: digital_restricted. *
+ Fixed some other spelling errors and typos.
+
+2008-08-06 20:42 +0000 [r136238] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_queue.c: We only need to unregister the QueueStatus
+ manager command once on an unload
+
+2008-08-06 20:14 +0000 [r136190] Tilghman Lesher <tlesher at digium.com>
+
+ * contrib/init.d/rc.redhat.asterisk: -C option takes a filename,
+ not a directory path. (closes issue #13007) Reported by:
+ klaus3000
+
+2008-08-06 18:58 +0000 [r136168] Russell Bryant <russell at digium.com>
+
+ * Makefile: Remove the use of --no-print-directory when compiling
+ subdirectories. This allows vim :make functionality to work
+ properly when errors have occurred in the build. Without printing
+ the directories, vim did not know how to find the file that the
+ error occurred in. If the extra bit of build noise annoys anyone,
+ just let me know, and I'll make this optional.
+
+2008-08-06 15:58 +0000 [r136062] Mark Michelson <mmichelson at digium.com>
+
+ * main/rtp.c, channels/chan_skinny.c: Since adding the
+ AST_CONTROL_SRCUPDATE frame type, there are places where
+ ast_rtp_new_source may be called where the tech_pvt of a channel
+ may not yet have an rtp structure allocated. This caused a crash
+ in chan_skinny, which was fixed earlier, but now the same crash
+ has been reported against chan_h323 as well. It seems that the
+ best solution is to modify ast_rtp_new_source to not attempt to
+ set the marker bit if the rtp structure passed in is NULL. This
+ change to ast_rtp_new_source also allows the removal of what is
+ now a redundant pointer check from chan_skinny. (closes issue
+ #13247) Reported by: pj
+
+2008-08-06 03:53 +0000 [r135899-135949] Tilghman Lesher <tlesher at digium.com>
+
+ * main/channel.c: Fix a longstanding bug in channel walking logic,
+ and fix the explanation to make sense. (Closes issue #13124)
+
+ * main/translate.c: Since powerof() can return an error condition,
+ it's foolhardy not to detect and deal with that condition.
+ (Related to issue #13240)
+
+ * include/asterisk/threadstorage.h, include/asterisk/utils.h: 1)
+ Bugfix for debugging code 2) Reduce compiler warnings for another
+ section of debugging code (Closes issue #13237)
+
+2008-08-06 00:29 +0000 [r135841-135850] Mark Michelson <mmichelson at digium.com>
+
+ * /: Remove properties that should not be here
+
+ * apps/app_skel.c: Revert inadvertent changes to app_skel that
+ occurred when I was testing for a memory leak
+
+ * include/asterisk/abstract_jb.h, main/channel.c, /,
+ apps/app_skel.c, main/abstract_jb.c, main/fixedjitterbuf.h:
+ Merging the issue11259 branch. The purpose of this branch was to
+ take into account "burps" which could cause jitterbuffers to
+ misbehave. One such example is if the L option to Dial() were
+ used to inject audio into a bridged conversation at regular
+ intervals. Since the audio here was not passed through the
+ jitterbuffer, it would cause a gap in the jitterbuffer's
+ timestamps which would cause a frames to be dropped for a brief
+ period. Now ast_generic_bridge will empty and reset the
+ jitterbuffer each time it is called. This causes injected audio
+ to be handled properly. ast_generic_bridge also will empty and
+ reset the jitterbuffer if it receives an AST_CONTROL_SRCUPDATE
+ frame since the change in audio source could negatively affect
+ the jitterbuffer. All of this was made possible by adding a new
+ public API call to the abstract_jb called ast_jb_empty_and_reset.
+ (closes issue #11259) Reported by: plack Tested by: putnopvut
+
+2008-08-05 23:13 +0000 [r135799] Steve Murphy <murf at digium.com>
+
+ * apps/app_dial.c, main/cdr.c, main/channel.c, res/res_features.c,
+ include/asterisk/cdr.h: (closes issue #12982) Reported by: bcnit
+ Tested by: murf I discovered that also, in the previous bug fixes
+ and changes, the cdr.conf 'unanswered' option is not being
+ obeyed, so I fixed this. And, yes, there are two 'answer' times
+ involved in this scenario, and I would agree with you, that the
+ first answer time is the time that should appear in the CDR. (the
+ second 'answer' time is the time that the bridge was begun). I
+ made the necessary adjustments, recording the first answer time
+ into the peer cdr, and then using that to override the bridge
+ cdr's value. To get the 'unanswered' CDRs to appear, I purposely
+ output them, using the dial cmd to mark them as DIALED (with a
+ new flag), and outputting them if they bear that flag, and you
+ are in the right mode. I also corrected one small mention of the
+ Zap device to equally consider the dahdi device. I heavily tested
+ 10-sec-wait macros in dial, and without the macro call; I tested
+ hangups while the macro was running vs. letting the macro
+ complete and the bridge form. Looks OK. Removed all the
+ instrumentation and debug.
+
+2008-08-05 21:34 +0000 [r135747] Tilghman Lesher <tlesher at digium.com>
+
[... 19326 lines stripped ...]
More information about the asterisk-commits
mailing list