[asterisk-commits] mmichelson: trunk r150302 - /trunk/main/manager.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Thu Oct 16 18:36:49 2008
New Revision: 150302

URL: http://svn.digium.com/view/asterisk?view=rev&rev=150302
Log:
Merged revisions 150298,150301 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r150298 | mmichelson | 2008-10-16 18:34:37 -0500 (Thu, 16 Oct 2008) | 10 lines

Don't try to call a dialplan function's read callback from
the manager's GetVar handler if an invalid channel has
been specified. Several dialplan functions, including
CHANNEL and SIP_HEADER, do not check for NULL-ness of
the channel being passed in.

(closes issue #13715)
Reported by: makoto


........
r150301 | mmichelson | 2008-10-16 18:35:07 -0500 (Thu, 16 Oct 2008) | 3 lines

And don't forget to return on the error condition


........

Modified:
    trunk/main/manager.c

Modified: trunk/main/manager.c
URL: http://svn.digium.com/view/asterisk/trunk/main/manager.c?view=diff&rev=150302&r1=150301&r2=150302
==============================================================================
--- trunk/main/manager.c (original)
+++ trunk/main/manager.c Thu Oct 16 18:36:49 2008
@@ -1805,6 +1805,10 @@
 	}
 
 	if (varname[strlen(varname) - 1] == ')') {
+		if (!c) {
+			astman_send_error(s, m, "No such channel");
+			return 0;
+		}
 		ast_func_read(c, (char *) varname, workspace, sizeof(workspace));
 		varval = workspace;
 	} else {