[asterisk-commits] seanbright: trunk r148200 - in /trunk: apps/ include/ main/ res/

[SVN commits to the Asterisk project]

Author: seanbright
Date: Thu Oct  9 19:42:13 2008
New Revision: 148200

URL: http://svn.digium.com/view/asterisk?view=rev&rev=148200
Log:
Don't include logger.h in asterisk.h by default as it is causing problems building
app_voicemail.  Instead, include it where it is needed.  This turned out to be a
relatively minor issue because other headers include logger.h as well.

Need to test -addons before merging this back to 1.6.0.

(closes issue #13605)
Reported by: tomo1657
Patches: 
      13605_seanbright.diff uploaded by seanbright (license 71)
Tested by: mmichelson

Modified:
    trunk/apps/app_voicemail.c
    trunk/include/asterisk.h
    trunk/main/cryptostub.c
    trunk/main/tdd.c
    trunk/res/res_config_sqlite.c

Modified: trunk/apps/app_voicemail.c
URL: http://svn.digium.com/view/asterisk/trunk/apps/app_voicemail.c?view=diff&rev=148200&r1=148199&r2=148200
==============================================================================
--- trunk/apps/app_voicemail.c (original)
+++ trunk/apps/app_voicemail.c Thu Oct  9 19:42:13 2008
@@ -63,12 +63,8 @@
 </category>
  ***/
 
-/* It is important to include the IMAP_STORAGE related headers
- * before asterisk.h since asterisk.h includes logger.h. logger.h
- * and c-client.h have conflicting definitions for AST_LOG_WARNING and
- * AST_LOG_DEBUG, so it's important that we use Asterisk's definitions
- * here instead of the c-client's 
- */
+#include "asterisk.h"
+
 #ifdef IMAP_STORAGE
 #include <ctype.h>
 #include <signal.h>
@@ -88,8 +84,6 @@
 #endif
 #endif
 
-#include "asterisk.h"
-
 ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
 
 #include "asterisk/paths.h"	/* use ast_config_AST_SPOOL_DIR */
@@ -99,6 +93,7 @@
 #include <time.h>
 #include <dirent.h>
 
+#include "asterisk/logger.h"
 #include "asterisk/lock.h"
 #include "asterisk/file.h"
 #include "asterisk/channel.h"

Modified: trunk/include/asterisk.h
URL: http://svn.digium.com/view/asterisk/trunk/include/asterisk.h?view=diff&rev=148200&r1=148199&r2=148200
==============================================================================
--- trunk/include/asterisk.h (original)
+++ trunk/include/asterisk.h Thu Oct  9 19:42:13 2008
@@ -25,8 +25,6 @@
 #endif
 
 #include "asterisk/compat.h"
-
-#include "asterisk/logger.h"
 
 /* Default to allowing the umask or filesystem ACLs to determine actual file
  * creation permissions

Modified: trunk/main/cryptostub.c
URL: http://svn.digium.com/view/asterisk/trunk/main/cryptostub.c?view=diff&rev=148200&r1=148199&r2=148200
==============================================================================
--- trunk/main/cryptostub.c (original)
+++ trunk/main/cryptostub.c Thu Oct  9 19:42:13 2008
@@ -28,6 +28,7 @@
 ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
 
 #include "asterisk/crypto.h"
+#include "asterisk/logger.h"
 
 static struct ast_key *stub_ast_key_get(const char *kname, int ktype)
 {

Modified: trunk/main/tdd.c
URL: http://svn.digium.com/view/asterisk/trunk/main/tdd.c?view=diff&rev=148200&r1=148199&r2=148200
==============================================================================
--- trunk/main/tdd.c (original)
+++ trunk/main/tdd.c Thu Oct  9 19:42:13 2008
@@ -35,6 +35,7 @@
 #include <math.h>
 #include <ctype.h>
 
+#include "asterisk/logger.h"
 #include "asterisk/ulaw.h"
 #include "asterisk/tdd.h"
 #include "asterisk/fskmodem.h"

Modified: trunk/res/res_config_sqlite.c
URL: http://svn.digium.com/view/asterisk/trunk/res/res_config_sqlite.c?view=diff&rev=148200&r1=148199&r2=148200
==============================================================================
--- trunk/res/res_config_sqlite.c (original)
+++ trunk/res/res_config_sqlite.c Thu Oct  9 19:42:13 2008
@@ -80,6 +80,7 @@
 
 #include <sqlite.h>
 
+#include "asterisk/logger.h"
 #include "asterisk/app.h"
 #include "asterisk/pbx.h"
 #include "asterisk/cdr.h"