[asterisk-commits] tilghman: branch 1.4 r118465 - /branches/1.4/main/asterisk.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Tue May 27 13:58:09 2008
New Revision: 118465

URL: http://svn.digium.com/view/asterisk?view=rev&rev=118465
Log:
NULL character should terminate only commands back to the core, not log
messages to the console.
(closes issue #12731)
 Reported by: seanbright
 Patches: 
       20080527__bug12731.diff.txt uploaded by Corydon76 (license 14)
 Tested by: seanbright

Modified:
    branches/1.4/main/asterisk.c

Modified: branches/1.4/main/asterisk.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/asterisk.c?view=diff&rev=118465&r1=118464&r2=118465
==============================================================================
--- branches/1.4/main/asterisk.c (original)
+++ branches/1.4/main/asterisk.c Tue May 27 13:58:09 2008
@@ -738,9 +738,16 @@
 		free(ae);
 }
 
+/* Sending commands from consoles back to the daemon requires a terminating NULL */
+static int fdsend(int fd, const char *s)
+{
+	return write(fd, s, strlen(s) + 1);
+}
+
+/* Sending messages from the daemon back to the display requires _excluding_ the terminating NULL */
 static int fdprint(int fd, const char *s)
 {
-	return write(fd, s, strlen(s) + 1);
+	return write(fd, s, strlen(s));
 }
 
 /*! \brief NULL handler so we can collect the child exit status */
@@ -1782,7 +1789,7 @@
 							printf(term_quit());
 							WELCOME_MESSAGE;
 							if (!ast_opt_mute)
-								fdprint(ast_consock, "logger mute silent");
+								fdsend(ast_consock, "logger mute silent");
 							else 
 								printf("log and verbose output currently muted ('logger mute' to unmute)\n");
 							break;
@@ -2094,7 +2101,7 @@
 
 	if (ast_opt_remote) {
 		snprintf(buf, sizeof(buf),"_COMMAND NUMMATCHES \"%s\" \"%s\"", lf->buffer, ptr); 
-		fdprint(ast_consock, buf);
+		fdsend(ast_consock, buf);
 		res = read(ast_consock, buf, sizeof(buf));
 		buf[res] = '\0';
 		nummatches = atoi(buf);
@@ -2106,7 +2113,7 @@
 			if (!(mbuf = ast_malloc(maxmbuf)))
 				return (char *)(CC_ERROR);
 			snprintf(buf, sizeof(buf),"_COMMAND MATCHESARRAY \"%s\" \"%s\"", lf->buffer, ptr); 
-			fdprint(ast_consock, buf);
+			fdsend(ast_consock, buf);
 			res = 0;
 			mbuf[0] = '\0';
 			while (!strstr(mbuf, AST_CLI_COMPLETE_EOF) && res != -1) {
@@ -2291,11 +2298,11 @@
 		pid = -1;
 	if (!data) {
 		snprintf(tmp, sizeof(tmp), "core set verbose atleast %d", option_verbose);
-		fdprint(ast_consock, tmp);
+		fdsend(ast_consock, tmp);
 		snprintf(tmp, sizeof(tmp), "core set debug atleast %d", option_debug);
-		fdprint(ast_consock, tmp);
+		fdsend(ast_consock, tmp);
 		if (!ast_opt_mute)
-			fdprint(ast_consock, "logger mute silent");
+			fdsend(ast_consock, "logger mute silent");
 		else 
 			printf("log and verbose output currently muted ('logger mute' to unmute)\n");
 	}