[asterisk-commits] qwell: trunk r111774 - /trunk/apps/app_voicemail.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Mar 28 14:08:36 CDT 2008


Author: qwell
Date: Fri Mar 28 14:08:35 2008
New Revision: 111774

URL: http://svn.digium.com/view/asterisk?view=rev&rev=111774
Log:
Replace magic number size from msgArray array with a define.

(same patch as before, I just split this part out)
(close issue #12326)
Reported by: travishein
Patches:
      app_voicemail_code_documentation.patch uploaded by travishein (license 385)

Modified:
    trunk/apps/app_voicemail.c

Modified: trunk/apps/app_voicemail.c
URL: http://svn.digium.com/view/asterisk/trunk/apps/app_voicemail.c?view=diff&rev=111774&r1=111773&r2=111774
==============================================================================
--- trunk/apps/app_voicemail.c (original)
+++ trunk/apps/app_voicemail.c Fri Mar 28 14:08:35 2008
@@ -399,6 +399,8 @@
 	char msg_format[512];
 };
 
+#define VMSTATE_MAX_MSG_ARRAY 256
+
 /*! Voicemail mailbox state */
 struct vm_state {
 	char curbox[80];
@@ -418,7 +420,7 @@
 #ifdef IMAP_STORAGE
 	ast_mutex_t lock;
 	int updated;                         /*!< decremented on each mail check until 1 -allows delay */
-	long msgArray[256];
+	long msgArray[VMSTATE_MAX_MSG_ARRAY];
 	MAILSTREAM *mailstream;
 	int vmArrayIndex;
 	char imapuser[80];                   /*!< IMAP server login */
@@ -9946,7 +9948,7 @@
 {
 	int x;
 	vms->vmArrayIndex = 0;
-	for (x = 0; x < 256; x++) {
+	for (x = 0; x < VMSTATE_MAX_MSG_ARRAY; x++) {
 		vms->msgArray[x] = 0;
 	}
 	ast_mutex_init(&vms->lock);
@@ -9955,7 +9957,7 @@
 static void check_msgArray(struct vm_state *vms) 
 {
 	int x;
-	for (x = 0; x < 256; x++) {
+	for (x = 0; x < VMSTATE_MAX_MSG_ARRAY; x++) {
 		if (vms->msgArray[x] != 0) {
 			ast_debug(1, "Item %d set to %ld\n", x, vms->msgArray[x]);
 		}
@@ -9972,7 +9974,7 @@
 static void copy_msgArray(struct vm_state *dst, struct vm_state *src)
 {
 	int x;
-	for (x = 0; x < 256; x++) {
+	for (x = 0; x < VMSTATE_MAX_MSG_ARRAY; x++) {
 		dst->msgArray[x] = src->msgArray[x];
 	}
 }




More information about the asterisk-commits mailing list