[asterisk-commits] murf: trunk r111497 - /trunk/main/pbx.c

[SVN commits to the Asterisk project]

Author: murf
Date: Thu Mar 27 16:25:55 2008
New Revision: 111497

URL: http://svn.digium.com/view/asterisk?view=rev&rev=111497
Log:
comment cleanup and iron out a really dumb mistake in handling the '.'-wildcard in the new exten pattern matcher.

Modified:
    trunk/main/pbx.c

Modified: trunk/main/pbx.c
URL: http://svn.digium.com/view/asterisk/trunk/main/pbx.c?view=diff&rev=111497&r1=111496&r2=111497
==============================================================================
--- trunk/main/pbx.c (original)
+++ trunk/main/pbx.c Thu Mar 27 16:25:55 2008
@@ -75,14 +75,15 @@
  *
  * A new algorithm to do searching based on a 'compiled' pattern tree is introduced
  * here, and shows a fairly flat (constant) search time, even for over
- * 1000 patterns. Might Still needs some work-- there are some fine points of the matching
+ * 1000 patterns. Might Still need some work-- there are some fine points of the matching
  * spec about tie-breaking based on the characters in character sets, but this
  * should be do-able via the weight system currently being used.
  *
  * Also, using a hash table for context/priority name lookup can help prevent
- * the find_extension routines from absorbing exponential cpu cycles. I've tested
- * find_extension with red-black trees, which have O(log2(n)) speed. Right now,
- * I'm using hash tables, which do searches (ideally) in O(1) time.
+ * the find_extension routines from absorbing exponential cpu cycles as the number 
+ * of extensions grow. I've previously tested find_extension with red-black trees, 
+ * which have O(log2(n)) speed. Right now, I'm using hash tables, which do 
+ * searches (ideally) in O(1) time.
  *
  */
 
@@ -1030,10 +1031,11 @@
 			/* how many chars will the . match against? */
 			int i = 0;
 			const char *str2 = str;
-			while (*str2++) {
+			while (*str2 && *str2 != '/') {
+				str2++;
 				i++;
 			}
-			if (p->exten && !(*(str+1)))
+			if (p->exten && *str2 != '/')
 				update_scoreboard(score, length+i, spec+(i*p->specificity), p->exten, '.', callerid, p->deleted, p);
 			if (p->next_char && p->next_char->x[0] == '/' && p->next_char->x[1] == 0) {
 				new_find_extension("/", score, p->next_char, length+i, spec+(p->specificity*i), callerid);
@@ -1043,10 +1045,11 @@
 			/* how many chars will the . match against? */
 			int i = 0;
 			const char *str2 = str;
-			while (*str2++) {
+			while (*str2 && *str2 != '/') {
+				str2++;
 				i++;
 			}
-			if (p->exten && !(*(str+1)))
+			if (p->exten && *str2 != '/')
 				update_scoreboard(score, length+1, spec+(p->specificity*i), p->exten, '!', callerid, p->deleted, p);
 			if (p->next_char && p->next_char->x[0] == '/' && p->next_char->x[1] == 0) {
 				new_find_extension("/", score, p->next_char, length+i, spec+(p->specificity*i), callerid);