[asterisk-commits] qwell: branch 1.4 r108682 - /branches/1.4/res/res_musiconhold.c

[SVN commits to the Asterisk project]

Author: qwell
Date: Fri Mar 14 09:29:05 2008
New Revision: 108682

URL: http://svn.digium.com/view/asterisk?view=rev&rev=108682
Log:
Fix a potential segfault if chan (or chan->music_state) is NULL.

Closes issue #12210, credit to edantie for pointing this out.

Modified:
    branches/1.4/res/res_musiconhold.c

Modified: branches/1.4/res/res_musiconhold.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/res/res_musiconhold.c?view=diff&rev=108682&r1=108681&r2=108682
==============================================================================
--- branches/1.4/res/res_musiconhold.c (original)
+++ branches/1.4/res/res_musiconhold.c Fri Mar 14 09:29:05 2008
@@ -200,23 +200,26 @@
 
 static void moh_files_release(struct ast_channel *chan, void *data)
 {
-	struct moh_files_state *state = chan->music_state;
-
-	if (chan && state) {
-		if (chan->stream) {
-                        ast_closestream(chan->stream);
-                        chan->stream = NULL;
-                }
-		if (option_verbose > 2)
-			ast_verbose(VERBOSE_PREFIX_3 "Stopped music on hold on %s\n", chan->name);
-
-		if (state->origwfmt && ast_set_write_format(chan, state->origwfmt)) {
-			ast_log(LOG_WARNING, "Unable to restore channel '%s' to format '%d'\n", chan->name, state->origwfmt);
-		}
-		state->save_pos = state->pos;
-	}
-	if (ast_atomic_dec_and_test(&state->class->inuse) && state->class->delete)
-		ast_moh_destroy_one(state->class);
+	struct moh_files_state *state;
+
+	if (chan) {
+		if ((state = chan->music_state)) {
+			if (chan->stream) {
+        	                ast_closestream(chan->stream);
+                	        chan->stream = NULL;
+	                }
+			if (option_verbose > 2)
+				ast_verbose(VERBOSE_PREFIX_3 "Stopped music on hold on %s\n", chan->name);
+	
+			if (state->origwfmt && ast_set_write_format(chan, state->origwfmt)) {
+				ast_log(LOG_WARNING, "Unable to restore channel '%s' to format '%d'\n", chan->name, state->origwfmt);
+			}
+			state->save_pos = state->pos;
+
+			if (ast_atomic_dec_and_test(&state->class->inuse) && state->class->delete)
+				ast_moh_destroy_one(state->class);
+		}
+	}
 }