[asterisk-commits] tilghman: trunk r121855 - in /trunk: ./ contrib/scripts/ include/asterisk/

[SVN commits to the Asterisk project]

Author: tilghman
Date: Wed Jun 11 12:44:39 2008
New Revision: 121855

URL: http://svn.digium.com/view/asterisk?view=rev&rev=121855
Log:
Expand CDR uniqueid field to 150 chars, to account for maximum systemname.
(Closes issue #12831)

Modified:
    trunk/UPGRADE.txt
    trunk/contrib/scripts/realtime_pgsql.sql
    trunk/include/asterisk/cdr.h

Modified: trunk/UPGRADE.txt
URL: http://svn.digium.com/view/asterisk/trunk/UPGRADE.txt?view=diff&rev=121855&r1=121854&r2=121855
==============================================================================
--- trunk/UPGRADE.txt (original)
+++ trunk/UPGRADE.txt Wed Jun 11 12:44:39 2008
@@ -150,6 +150,11 @@
   username and password parameters in cdr_odbc.conf, therefore, are no
   longer used.  The dsn parameter now points to an entry in res_odbc.conf.
 
+* The uniqueid field in the core Asterisk structure has been changed from a
+  maximum 31 character field to a 149 character field, to account for all
+  possible values the systemname prefix could be.  In the past, if the
+  systemname was too long, the uniqueid would have been truncated.
+
 Formats:
 
 * format_wav: The GAIN preprocessor definition and source code that used it

Modified: trunk/contrib/scripts/realtime_pgsql.sql
URL: http://svn.digium.com/view/asterisk/trunk/contrib/scripts/realtime_pgsql.sql?view=diff&rev=121855&r1=121854&r2=121855
==============================================================================
--- trunk/contrib/scripts/realtime_pgsql.sql (original)
+++ trunk/contrib/scripts/realtime_pgsql.sql Wed Jun 11 12:44:39 2008
@@ -25,7 +25,7 @@
 disposition character varying(45) DEFAULT '' NOT NULL,
 amaflags bigint DEFAULT 0::bigint NOT NULL,
 accountcode character varying(20) DEFAULT '' NOT NULL,
-uniqueid character varying(32) DEFAULT '' NOT NULL,
+uniqueid character varying(150) DEFAULT '' NOT NULL,
 userfield character varying(255) DEFAULT '' NOT NULL
 );
 

Modified: trunk/include/asterisk/cdr.h
URL: http://svn.digium.com/view/asterisk/trunk/include/asterisk/cdr.h?view=diff&rev=121855&r1=121854&r2=121855
==============================================================================
--- trunk/include/asterisk/cdr.h (original)
+++ trunk/include/asterisk/cdr.h Wed Jun 11 12:44:39 2008
@@ -90,8 +90,9 @@
 	char accountcode[AST_MAX_ACCOUNT_CODE];			
 	/*! flags */
 	unsigned int flags;				
-	/*! Unique Channel Identifier */
-	char uniqueid[32];
+	/*! Unique Channel Identifier
+	 * 150 = 127 (max systemname) + "-" + 10 (epoch timestamp) + "." + 10 (monotonically incrementing integer) + NULL */
+	char uniqueid[150];
 	/*! User field */
 	char userfield[AST_MAX_USER_FIELD];