[asterisk-commits] mmichelson: branch mmichelson/imap_consistency r133044 - /team/mmichelson/ima...

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Wed Jul 23 13:20:19 CDT 2008


Author: mmichelson
Date: Wed Jul 23 13:20:19 2008
New Revision: 133044

URL: http://svn.digium.com/view/asterisk?view=rev&rev=133044
Log:
Comment cleanup


Modified:
    team/mmichelson/imap_consistency/apps/app_voicemail.c

Modified: team/mmichelson/imap_consistency/apps/app_voicemail.c
URL: http://svn.digium.com/view/asterisk/team/mmichelson/imap_consistency/apps/app_voicemail.c?view=diff&rev=133044&r1=133043&r2=133044
==============================================================================
--- team/mmichelson/imap_consistency/apps/app_voicemail.c (original)
+++ team/mmichelson/imap_consistency/apps/app_voicemail.c Wed Jul 23 13:20:19 2008
@@ -1086,10 +1086,6 @@
 
 	fprintf(text_file_ptr, "%s\n", "[message]");
 
-	/* XXX I bet this could be optimized by having a single fprintf of the entire
-	 * contents of the text file. However, it may be that the buffering provided
-	 * by the standard I/O library already optimizes this well enough. Come back later.
-	 */
 	cid_num = get_header_by_tag(header_content, "X-Asterisk-VM-Caller-ID-Num:");
 	cid_name = get_header_by_tag(header_content, "X-Asterisk-VM-Caller-ID-Name:");
 	fprintf(text_file_ptr, "callerid=\"%s\" <%s>\n", S_OR(cid_name, ""), S_OR(cid_num, ""));
@@ -1298,8 +1294,8 @@
 		ast_free(buf);
 		if (option_debug > 2)
 			ast_log(LOG_DEBUG, "%s stored\n", fn);
-		/*XXX Temporary fix for msgArray problem. This may actually be
-		 * good enough for permanent usage, though.
+		/* Using messagecount to populate the last place in the msgArray
+		 * is less than optimal, but it's the only way given the current setup
 		 */
 		messagecount(vmu->context, vmu->mailbox, "INBOX");
 	}




More information about the asterisk-commits mailing list