[asterisk-commits] mvanbaak: trunk r130744 - in /trunk: ./ main/dnsmgr.c

[SVN commits to the Asterisk project]

Author: mvanbaak
Date: Mon Jul 14 12:21:18 2008
New Revision: 130744

URL: http://svn.digium.com/view/asterisk?view=rev&rev=130744
Log:
Merged revisions 130735 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r130735 | mvanbaak | 2008-07-14 19:10:21 +0200 (Mon, 14 Jul 2008) | 10 lines

notify the user that dnsmgr refresh wont work when dnsmgr is not enabled.
Previously this command would automagically appear and disappear.
This was confusing.

(closes issue #12796)
Reported by: chappell
Patches:
      dnsmgr_refresh_3.diff uploaded by chappell (license 8)
Tested by: russell, chappell, mvanbaak

........

Modified:
    trunk/   (props changed)
    trunk/main/dnsmgr.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/main/dnsmgr.c
URL: http://svn.digium.com/view/asterisk/trunk/main/dnsmgr.c?view=diff&rev=130744&r1=130743&r2=130744
==============================================================================
--- trunk/main/dnsmgr.c (original)
+++ trunk/main/dnsmgr.c Mon Jul 14 12:21:18 2008
@@ -285,20 +285,29 @@
 	case CLI_GENERATE:
 		return NULL;	
 	}
-	if (a->argc > 3)
+
+	if (!enabled) {
+		ast_cli(a->fd, "DNS Manager is disabled.\n");
+		return 0;
+	}
+
+	if (a->argc > 3) {
 		return CLI_SHOWUSAGE;
+	}
 
 	if (a->argc == 3) {
-		if ( regcomp(&info.filter, a->argv[2], REG_EXTENDED | REG_NOSUB) )
+		if (regcomp(&info.filter, a->argv[2], REG_EXTENDED | REG_NOSUB)) {
 			return CLI_SHOWUSAGE;
-		else
+		} else {
 			info.regex_present = 1;
+		}
 	}
 
 	refresh_list(&info);
 
-	if (info.regex_present)
+	if (info.regex_present) {
 		regfree(&info.filter);
+	}
 
 	return CLI_SUCCESS;
 }
@@ -414,7 +423,6 @@
 		pthread_kill(refresh_thread, SIGURG);
 		pthread_join(refresh_thread, NULL);
 		refresh_thread = AST_PTHREADT_NULL;
-		ast_cli_unregister(&cli_refresh);
 		res = 0;
 	}
 	else