[asterisk-commits] file: trunk r98830 - /trunk/main/manager.c

[SVN commits to the Asterisk project]

Author: file
Date: Mon Jan 14 14:01:19 2008
New Revision: 98830

URL: http://svn.digium.com/view/asterisk?view=rev&rev=98830
Log:
Make sure the user's manager secret exists, even if it is blank.
(closes issue #11749)
Reported by: srt

Modified:
    trunk/main/manager.c

Modified: trunk/main/manager.c
URL: http://svn.digium.com/view/asterisk/trunk/main/manager.c?view=diff&rev=98830&r1=98829&r2=98830
==============================================================================
--- trunk/main/manager.c (original)
+++ trunk/main/manager.c Mon Jan 14 14:01:19 2008
@@ -997,7 +997,7 @@
 		ast_log(LOG_NOTICE, "%s failed to pass IP ACL as '%s'\n", ast_inet_ntoa(s->sin.sin_addr), username);
 	} else if (!strcasecmp(astman_get_header(m, "AuthType"), "MD5")) {
 		const char *key = astman_get_header(m, "Key");
-		if (!ast_strlen_zero(key) && !ast_strlen_zero(s->challenge)) {
+		if (!ast_strlen_zero(key) && !ast_strlen_zero(s->challenge) && user->secret) {
 			int x;
 			int len = 0;
 			char md5key[256] = "";