[asterisk-commits] tilghman: trunk r96576 - in /trunk: ./ main/devicestate.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Fri Jan  4 17:12:43 2008
New Revision: 96576

URL: http://svn.digium.com/view/asterisk?view=rev&rev=96576
Log:
Merged revisions 96575 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r96575 | tilghman | 2008-01-04 17:03:40 -0600 (Fri, 04 Jan 2008) | 7 lines

Fix the problem of notification of a device state change to a device with a '-'
in the name.  Could probably do with a better fix in trunk, but this bug has
been open way too long without a better solution.
Reported by: stevedavies
Patch by: tilghman
(Closes issue #9668)

........

Modified:
    trunk/   (props changed)
    trunk/main/devicestate.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/main/devicestate.c
URL: http://svn.digium.com/view/asterisk/trunk/main/devicestate.c?view=diff&rev=96576&r1=96575&r2=96576
==============================================================================
--- trunk/main/devicestate.c (original)
+++ trunk/main/devicestate.c Fri Jan  4 17:12:43 2008
@@ -432,7 +432,7 @@
 	devstate_event(device, state, CACHE_OFF);
 }
 
-static int __ast_devstate_changed_literal(enum ast_device_state state, char *buf)
+static int __ast_devstate_changed_literal(enum ast_device_state state, char *buf, int norecurse)
 {
 	char *device;
 	struct state_change *change;
@@ -441,10 +441,6 @@
 	ast_debug(3, "Notification of state change to be queued on device/channel %s\n", buf);
 
 	device = buf;
-
-	tmp = strrchr(device, '-');
-	if (tmp)
-		*tmp = '\0';
 
 	if (state != AST_DEVICE_UNKNOWN) {
 		devstate_event(device, state, CACHE_ON);
@@ -461,6 +457,18 @@
 		AST_LIST_UNLOCK(&state_changes);
 	}
 
+	/* The problem with this API is that a device may be called with the unique
+	 * identifier appended or not, but it's separated from the channel name
+	 * with a '-', which is also a legitimate character in a channel name.  So,
+	 * we have to force both names to get their names checked for state changes
+	 * to ensure that the right one gets notified.  Not a huge performance hit,
+	 * but it might could be fixed by an enterprising programmer in trunk.
+	 */
+	if (!norecurse && (tmp = strrchr(device, '-'))) {
+		*tmp = '\0';
+		__ast_devstate_changed_literal(state, tmp, 1);
+	}
+	
 	return 1;
 }
 
@@ -470,7 +478,7 @@
 
 	buf = ast_strdupa(dev);
 
-	return __ast_devstate_changed_literal(state, buf);
+	return __ast_devstate_changed_literal(state, buf, 0);
 }
 
 int ast_device_state_changed_literal(const char *dev)
@@ -479,7 +487,7 @@
 
 	buf = ast_strdupa(dev);
 
-	return __ast_devstate_changed_literal(AST_DEVICE_UNKNOWN, buf);
+	return __ast_devstate_changed_literal(AST_DEVICE_UNKNOWN, buf, 0);
 }
 
 int ast_devstate_changed(enum ast_device_state state, const char *fmt, ...) 
@@ -491,7 +499,7 @@
 	vsnprintf(buf, sizeof(buf), fmt, ap);
 	va_end(ap);
 
-	return __ast_devstate_changed_literal(state, buf);
+	return __ast_devstate_changed_literal(state, buf, 0);
 }
 
 /*! \brief Accept change notification, add it to change queue */
@@ -504,7 +512,7 @@
 	vsnprintf(buf, sizeof(buf), fmt, ap);
 	va_end(ap);
 
-	return __ast_devstate_changed_literal(AST_DEVICE_UNKNOWN, buf);
+	return __ast_devstate_changed_literal(AST_DEVICE_UNKNOWN, buf, 0);
 }
 
 /*! \brief Go through the dev state change queue and update changes in the dev state thread */