[asterisk-commits] seanbright: trunk r161147 - /trunk/apps/app_voicemail.c

[SVN commits to the Asterisk project]

Author: seanbright
Date: Thu Dec  4 20:47:54 2008
New Revision: 161147

URL: http://svn.digium.com/view/asterisk?view=rev&rev=161147
Log:
Check the return value of fread/fwrite so the compiler doesn't complain.  Only a
problem when IMAP_STORAGE is enabled.

Modified:
    trunk/apps/app_voicemail.c

Modified: trunk/apps/app_voicemail.c
URL: http://svn.digium.com/view/asterisk/trunk/apps/app_voicemail.c?view=diff&rev=161147&r1=161146&r2=161147
==============================================================================
--- trunk/apps/app_voicemail.c (original)
+++ trunk/apps/app_voicemail.c Thu Dec  4 20:47:54 2008
@@ -1784,7 +1784,12 @@
 			*(vmu->email) = '\0';
 		return -1;
 	}
-	fread(buf, len, 1, p);
+	if (fread(buf, len, 1, p) < len) {
+		if (ferror(p)) {
+			ast_log(LOG_ERROR, "Short read while reading in mail file.\n");
+			return -1;
+		}
+	}
 	((char *)buf)[len] = '\0';
 	INIT(&str, mail_string, buf, len);
 	ret = init_mailstream(vms, NEW_FOLDER);
@@ -2131,7 +2136,11 @@
 	FILE *output;
 
 	output = fopen (filename, "w");
-	fwrite (buffer, len, 1, output);
+	if (fwrite(buffer, len, 1, output) < len) {
+		if (ferror(output)) {
+			ast_log(LOG_ERROR, "Short write while writing e-mail body.\n");
+		}
+	}
 	fclose (output);
 }