[asterisk-commits] murf: branch group/newcdr r114919 - in /team/group/newcdr: ./ apps/ build_too...
SVN commits to the Asterisk project
asterisk-commits at lists.digium.com
Wed Apr 30 19:54:40 CDT 2008
Author: murf
Date: Wed Apr 30 19:54:39 2008
New Revision: 114919
URL: http://svn.digium.com/view/asterisk?view=rev&rev=114919
Log:
Merged revisions 75254-75255,75259-75260,75307,75351,75365,75379,75381,75400,75402,75404,75406,75438,75442-75443,75446,75448,75451,75505,75530,75566,75584-75586,75620,75622,75624,75659,75706,75709-75710,75713-75714,75734,75750,75761,75805-75806,75808,75841,75857,75873-75875,75878,75894,75911,75929-75930,75977,75979,75981-75983,76015,76034-76035,76037,76055-76056,76070,76091,76138,76140,76175,76177,76179,76213,76216,76220-76222,76224,76228-76229,76231,76278-76279,76296,76313-76314,76330,76348-76349,76365-76366,76371,76390,76392,76408,76458,76467,76486,76520-76521,76523-76524,76547,76555,76558-76559,76562-76564,76619,76621,76655,76657,76703-76704,76706-76707,76709-76712,76755,76770,76785,76791,76804,76807,76841,76852,76874,76892,76925,76940,76984-76985,77023,77054,77072,77155-77156,77182,77217-77218,77233,77248,77266-77269,77284,77299,77319,77349,77351,77381,77411,77432,77461,77491,77520,77534,77537-77538,77541,77572,77602-77603,77616,77630-77631,77647-77648,77650,77653-77654,7
7668-77669,77682,77684,77697,77711-77712,77725-77726,77739,77753,77766,77769-77770,77772-77773,77779,77781,77784,77786-77787,77789-77793,77796-77797,77799-77801,77808,77810,77819-77821,77825,77828-77829,77833-77834,77838,77847,77851,77853,77855,77857-77858,77864,77866,77868,77870,77872,77875-77876,77878-77879,77884,77888-77889,77891,77895,77940-77941,77944,77946,77948,77950,77994,77997,78029,78064,78096,78102,78138,78140,78142,78144,78147,78167-78168,78173,78179,78181,78183,78185-78186,78192,78227,78243,78276,78278-78279,78312,78338,78342,78346-78347,78372,78378,78417-78418,78442,78451,78489,78521,78541,78570,78590,78635,78637,78648-78649,78679,78683,78685-78686,78718,78747,78750,78779,78807,78824,78828-78829,78861-78862,78906,78908,78952,78956,79005,79027,79045,79063,79068,79074,79098,79100,79109,79147,79175-79176,79208,79222,79238,79273,79275,79277,79306,79333,79335,79378-79379,79392,79403,79437,79471,79507,79524,79529,79558,79595,79611,79623,79634,79638,79660,79666,79687-
79688,79691,79714,79719,79724-79725,79736,79747,79749,79755,79764,79788,79794,79813,79824,79841,79858-79862,79885,79888,79894,79901,79903,79905,79907,79913,79915,79940,79949,79972,79980,79988-79990,79999,80023,80033,80037,80045-80046,80048,80050,80075,80087,80089,80113,80131,80133,80157,80184,80217,80226,80241-80242,80256,80258,80262,80303,80305,80331,80361,80387-80388,80391,80408,80425,80427-80429,80453,80468,80470,80498,80500,80508,80510,80540,80550 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
................
r75254 | mmichelson | 2007-07-16 12:18:19 -0600 (Mon, 16 Jul 2007) | 16 lines
Merged revisions 75253 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75253 | mmichelson | 2007-07-16 13:16:15 -0500 (Mon, 16 Jul 2007) | 8 lines
Restoring functionality from 1.2 wherein Retrydial will not exit if there is no announce file specified.
This change makes it so that if there is no announce file specified, the application will continue until finished (or caller hangs up).
If a bogus announce file is specified, then a warning message will be printed saying that the file could not be found, but execution will
still continue.
(closes issue #10186, reported by jon, patched by me)
........
................
r75255 | file | 2007-07-16 12:24:29 -0600 (Mon, 16 Jul 2007) | 2 lines
For my next trick I will make it so dialplan functions no longer need to call ast_module_user_add and ast_module_user_remove. These are now called in the ast_func_read and ast_func_write functions outside of the module.
................
r75259 | file | 2007-07-16 12:36:02 -0600 (Mon, 16 Jul 2007) | 2 lines
Add in check for the GCC attribute deprecated. It may be used soon!
................
r75260 | file | 2007-07-16 12:38:28 -0600 (Mon, 16 Jul 2007) | 2 lines
Change the function name slightly... just for kpfleming!
................
r75307 | kpfleming | 2007-07-16 14:58:56 -0600 (Mon, 16 Jul 2007) | 19 lines
Merged revisions 75306 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75306 | kpfleming | 2007-07-16 15:53:24 -0500 (Mon, 16 Jul 2007) | 11 lines
Merged revisions 75304 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75304 | kpfleming | 2007-07-16 15:46:58 -0500 (Mon, 16 Jul 2007) | 3 lines
provide proper copyright/license attribution for this structure that was copied from a BSD-licensed header file long, long ago...
........
................
................
r75351 | qwell | 2007-07-17 06:01:05 -0600 (Tue, 17 Jul 2007) | 6 lines
Fix an incorrect parenthesization (TODO: Find a better word) in app_dial
Pointed out by Fanzhou Zhao
Closes issue #10216
................
r75365 | rizzo | 2007-07-17 06:46:25 -0600 (Tue, 17 Jul 2007) | 7 lines
Initialize a variable to avoid a warning when the compiler
(and/or the optimization level) may think it is used uninitialized.
The code was indeed correct, but unfortunately the result of
some compiler checks such as -Wunused and -Wuninitialized depends
heavily on the optimization level.
................
r75379 | rizzo | 2007-07-17 08:32:15 -0600 (Tue, 17 Jul 2007) | 16 lines
Introduce ast_parse_arg() , a generic function to parse strings
in a consistent way. This is meant to replace the custom code
which is repeated all over the place in the various files when
parsing config files, CLI entries and other string information.
Right now the code supports parsing int32, uint32 and sockaddr_in with
optional default values and bound checks. It contains minimal error
checking, but that can be easily extended as the need arises.
Being a new API i am introducing this only in trunk, though I believe
that once the interface has been ironed out it might become a
worthwhile addition to 1.4 as well - basically, the first time
we will need to fix a piece of argument parsing code, we might as
well bring in this change and use the new API instead.
................
r75381 | file | 2007-07-17 08:48:17 -0600 (Tue, 17 Jul 2007) | 2 lines
Make trunk build once again.
................
r75400 | murf | 2007-07-17 13:40:29 -0600 (Tue, 17 Jul 2007) | 1 line
via 10206, I have added an option (e) to Dial to allow the h exten to get run on peer. Had to upgrade ast_flag stuff to 64 bits to do this.
................
r75402 | russell | 2007-07-17 13:46:13 -0600 (Tue, 17 Jul 2007) | 11 lines
Merged revisions 75401 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75401 | russell | 2007-07-17 14:45:07 -0500 (Tue, 17 Jul 2007) | 3 lines
Remove a duplicated newline character in AGI debug output.
(closes issue #10207, patch by seanbright)
........
................
r75404 | russell | 2007-07-17 14:01:54 -0600 (Tue, 17 Jul 2007) | 20 lines
Merged revisions 75403 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75403 | russell | 2007-07-17 15:01:12 -0500 (Tue, 17 Jul 2007) | 12 lines
(closes issue #10209)
Reported by: juggie
Patches:
10209-trunk-2.patch uploaded by juggie
Tested by: juggie, blitzrage
In ast_pbx_run(), mark a channel as hung up after an application returned -1,
or when it runs out of extensions to execute. This is so that code can detect
that this channel has been hung up for things like making sure DeadAGI is used
on actual dead channels, and is beneficial for other things, like making sure
someone doesn't try to start spying on a channel that is about to go away.
........
................
r75406 | mmichelson | 2007-07-17 14:05:19 -0600 (Tue, 17 Jul 2007) | 14 lines
Merged revisions 75405 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75405 | mmichelson | 2007-07-17 15:03:48 -0500 (Tue, 17 Jul 2007) | 6 lines
Fixing an error I made earlier. ast_fileexists can return -1 on failure, so I need to be sure that we only enter the if
statement if it is successful.
Related to my fix to issue #10186
........
................
r75438 | russell | 2007-07-17 14:34:52 -0600 (Tue, 17 Jul 2007) | 15 lines
Blocked revisions 75437 via svnmerge
........
r75437 | russell | 2007-07-17 15:33:06 -0500 (Tue, 17 Jul 2007) | 8 lines
(issue #10210)
Reported by: juggie
Patches:
10210-1.4-grr.patch uploaded by juggie (license #24)
Tested by: juggie, blitzrage
Log a warning if someone uses DeadAGI on a live channel.
........
................
r75442 | russell | 2007-07-17 14:42:50 -0600 (Tue, 17 Jul 2007) | 20 lines
Merged revisions 75441 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75441 | russell | 2007-07-17 15:42:12 -0500 (Tue, 17 Jul 2007) | 12 lines
Merged revisions 75440 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75440 | russell | 2007-07-17 15:41:41 -0500 (Tue, 17 Jul 2007) | 4 lines
After parsing information elements in IAX frames, set the data length to zero,
so that code later on does not think it has data to copy.
(ASA-2007-015)
........
................
................
r75443 | file | 2007-07-17 14:44:55 -0600 (Tue, 17 Jul 2007) | 9 lines
Blocked revisions 75439 via svnmerge
........
r75439 | file | 2007-07-17 17:40:57 -0300 (Tue, 17 Jul 2007) | 2 lines
Ensure that the pointer to STUN data does not go to unaccessible memory. (ASA-2007-017)
........
................
r75446 | russell | 2007-07-17 14:49:09 -0600 (Tue, 17 Jul 2007) | 21 lines
Merged revisions 75445 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75445 | russell | 2007-07-17 15:48:21 -0500 (Tue, 17 Jul 2007) | 13 lines
Merged revisions 75444 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75444 | russell | 2007-07-17 15:45:27 -0500 (Tue, 17 Jul 2007) | 5 lines
Ensure that when encoding the contents of an ast_frame into an iax_frame, that
the size of the destination buffer is known in the iax_frame so that code
won't write past the end of the allocated buffer when sending outgoing frames.
(ASA-2007-014)
........
................
................
r75448 | russell | 2007-07-17 14:52:20 -0600 (Tue, 17 Jul 2007) | 8 lines
Blocked revisions 75447 via svnmerge
........
r75447 | russell | 2007-07-17 15:51:25 -0500 (Tue, 17 Jul 2007) | 1 line
cast arguments to ast_log so that it builds without warnings for me
........
................
r75451 | russell | 2007-07-17 14:58:40 -0600 (Tue, 17 Jul 2007) | 19 lines
Merged revisions 75450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75450 | russell | 2007-07-17 15:57:56 -0500 (Tue, 17 Jul 2007) | 11 lines
Merged revisions 75449 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75449 | russell | 2007-07-17 15:57:09 -0500 (Tue, 17 Jul 2007) | 3 lines
Properly check for the length in the skinny packet to prevent an invalid memcpy.
(ASA-2007-016)
........
................
................
r75505 | murf | 2007-07-17 15:52:51 -0600 (Tue, 17 Jul 2007) | 1 line
Spotted this bug today myself, trying to reproduce a BE bug. Use a vert bar instead of a comma, when calling RAND.
................
r75530 | tilghman | 2007-07-18 06:38:36 -0600 (Wed, 18 Jul 2007) | 10 lines
Merged revisions 75529 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75529 | tilghman | 2007-07-18 07:29:41 -0500 (Wed, 18 Jul 2007) | 2 lines
Using a freed frame causes crashes (closes issue #9317)
........
................
r75566 | file | 2007-07-18 07:59:01 -0600 (Wed, 18 Jul 2007) | 2 lines
Minor code tweaks. Variables were being checked wrong in some situations and didn't need to be checked in others.
................
r75584 | file | 2007-07-18 08:20:19 -0600 (Wed, 18 Jul 2007) | 13 lines
Merged revisions 75583 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75583 | file | 2007-07-18 11:18:53 -0300 (Wed, 18 Jul 2007) | 5 lines
(closes issue #10224)
Reported by: irroot
Record the threadid of each running thread before shutting them down as the thread themselves may change the value.
........
................
r75585 | murf | 2007-07-18 08:35:07 -0600 (Wed, 18 Jul 2007) | 1 line
This corrects the problem with flags and %lld formats on 64-bit machines, where uint64_t is NOT acceptable for %lld, and also works on 32-bit machines. At least, with gcc.
................
r75586 | file | 2007-07-18 08:59:20 -0600 (Wed, 18 Jul 2007) | 2 lines
Clean up func_curl a bit.
................
r75620 | file | 2007-07-18 09:26:52 -0600 (Wed, 18 Jul 2007) | 10 lines
Merged revisions 75619 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75619 | file | 2007-07-18 12:25:45 -0300 (Wed, 18 Jul 2007) | 2 lines
Don't bother reloading chan_h323 if it did not load successfully in the first place. This would otherwise cause a crash.
........
................
r75622 | file | 2007-07-18 09:42:11 -0600 (Wed, 18 Jul 2007) | 13 lines
Merged revisions 75621 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75621 | file | 2007-07-18 12:41:06 -0300 (Wed, 18 Jul 2007) | 5 lines
(closes issue #10165)
Reported by: elandivar
It is possible for hold status to exist without call limits set, so we need to ensure update_call_counter is executed regardless.
........
................
r75624 | file | 2007-07-18 09:45:18 -0600 (Wed, 18 Jul 2007) | 10 lines
Merged revisions 75623 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75623 | file | 2007-07-18 12:44:02 -0300 (Wed, 18 Jul 2007) | 2 lines
Few more places that needs to check for onhold state.
........
................
r75659 | dhubbard | 2007-07-18 11:59:56 -0600 (Wed, 18 Jul 2007) | 17 lines
Merged revisions 75658 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75658 | dhubbard | 2007-07-18 12:56:30 -0500 (Wed, 18 Jul 2007) | 9 lines
Merged revisions 75657 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75657 | dhubbard | 2007-07-18 12:48:33 -0500 (Wed, 18 Jul 2007) | 1 line
removed the word 'pissed' from ast_log(...) function call for BE-90
........
................
................
r75706 | tilghman | 2007-07-18 13:47:20 -0600 (Wed, 18 Jul 2007) | 2 lines
Merge in ast_strftime branch, which changes timestamps to be accurate to the microsecond, instead of only to the second
................
r75709 | russell | 2007-07-18 13:50:21 -0600 (Wed, 18 Jul 2007) | 1 line
convert some lines indented with spaces to tabs
................
r75710 | qwell | 2007-07-18 13:51:18 -0600 (Wed, 18 Jul 2007) | 13 lines
Merged revisions 75707 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
(closes issue #9887)
........
r75707 | qwell | 2007-07-18 14:48:12 -0500 (Wed, 18 Jul 2007) | 4 lines
Fix issues with new 79x1 phones.
Issue 9887, patches by DEA
........
................
r75713 | file | 2007-07-18 14:01:52 -0600 (Wed, 18 Jul 2007) | 9 lines
Blocked revisions 75712 via svnmerge
........
r75712 | file | 2007-07-18 17:00:23 -0300 (Wed, 18 Jul 2007) | 2 lines
Backport GCC 4.2 fixes. Without these Asterisk won't build under devmode using GCC 4.2.
........
................
r75714 | qwell | 2007-07-18 14:05:45 -0600 (Wed, 18 Jul 2007) | 13 lines
Merged revisions 75711 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
(closes issue #9245)
........
r75711 | qwell | 2007-07-18 14:54:32 -0500 (Wed, 18 Jul 2007) | 4 lines
Fixes for 7935/7936 conference phones.
Issue 9245, patch by slimey.
........
................
r75734 | qwell | 2007-07-18 14:18:00 -0600 (Wed, 18 Jul 2007) | 9 lines
Merged revisions 75732 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75732 | qwell | 2007-07-18 15:17:27 -0500 (Wed, 18 Jul 2007) | 1 line
Umm, why are we transmitting dialtone on cfwdall?
........
................
r75750 | tilghman | 2007-07-18 14:43:54 -0600 (Wed, 18 Jul 2007) | 18 lines
Merged revisions 75749 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75749 | tilghman | 2007-07-18 15:40:18 -0500 (Wed, 18 Jul 2007) | 10 lines
Merged revisions 75748 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75748 | tilghman | 2007-07-18 15:31:36 -0500 (Wed, 18 Jul 2007) | 2 lines
Store prior to copy (closes issue #10193)
........
................
................
r75761 | russell | 2007-07-18 15:10:27 -0600 (Wed, 18 Jul 2007) | 21 lines
Merged revisions 75759 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75759 | russell | 2007-07-18 16:09:46 -0500 (Wed, 18 Jul 2007) | 13 lines
Merged revisions 75757 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75757 | russell | 2007-07-18 16:09:13 -0500 (Wed, 18 Jul 2007) | 5 lines
When traversing the queue of frames for possible retransmission after
receiving a VNAK, handle sequence number wraparound so that all frames that
should be retransmitted actually do get retransmitted.
(issue #10227, reported and patched by mihai)
........
................
................
r75805 | tilghman | 2007-07-18 16:40:03 -0600 (Wed, 18 Jul 2007) | 2 lines
Change IAX variables to use datastores (closes issue #9315)
................
r75806 | russell | 2007-07-18 16:52:54 -0600 (Wed, 18 Jul 2007) | 5 lines
I thought I noticed a memory leak earlier when I saw that the contents of this
list were not destroyed when the module is unloaded. However, after reading
the code related to the use of this list a lot today, I realized that it isn't
necessary. So, I have added a comment to explain why it isn't necessary.
................
r75808 | qwell | 2007-07-18 17:00:30 -0600 (Wed, 18 Jul 2007) | 9 lines
Merged revisions 75807 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75807 | qwell | 2007-07-18 17:59:18 -0500 (Wed, 18 Jul 2007) | 1 line
Need to make sure we set milliseconds and timestamp - pointed out by the recent ast_ time stuff from Tilghman
........
................
r75841 | tilghman | 2007-07-18 21:37:12 -0600 (Wed, 18 Jul 2007) | 2 lines
Fix trunk where I broke it earlier (for ast_strftime branch)
................
r75857 | tilghman | 2007-07-18 22:45:20 -0600 (Wed, 18 Jul 2007) | 2 lines
Allow chan_misdn to build in dev-mode
................
r75873 | rizzo | 2007-07-19 01:41:45 -0600 (Thu, 19 Jul 2007) | 4 lines
portability fix: use %f instead of %lf when printing double.
The l is useless.
................
r75874 | rizzo | 2007-07-19 01:51:34 -0600 (Thu, 19 Jul 2007) | 4 lines
ast_sip_ouraddrfor() never fails, so make it void
and remove the code that would never be called.
................
r75875 | rizzo | 2007-07-19 02:00:03 -0600 (Thu, 19 Jul 2007) | 4 lines
document the use of externip, externhost and other nat-related options,
as well as the handling of the sip socket.
................
r75878 | rizzo | 2007-07-19 02:07:04 -0600 (Thu, 19 Jul 2007) | 8 lines
print more of the network settings (externip, externhost etc.)
in the "sip show settings" cli output. I have put these in a
separate section, probably even bindaddr and SIP port should go
there.
There are more things to add here e.g. localnet and so on.
................
r75894 | rizzo | 2007-07-19 06:38:13 -0600 (Thu, 19 Jul 2007) | 4 lines
comment out some terribly expensive debugging code
in the body of ast_apply_ha()
................
r75911 | russell | 2007-07-19 08:46:49 -0600 (Thu, 19 Jul 2007) | 3 lines
Remove some debug code that was added in revision 75894, which removed some
other debug code. :)
................
r75929 | russell | 2007-07-19 09:53:50 -0600 (Thu, 19 Jul 2007) | 22 lines
Merged revisions 75928 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r75928 | russell | 2007-07-19 10:53:15 -0500 (Thu, 19 Jul 2007) | 14 lines
Merged revisions 75927 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75927 | russell | 2007-07-19 10:49:42 -0500 (Thu, 19 Jul 2007) | 6 lines
When processing full frames, take sequence number wraparound into account when
deciding whether or not we need to request retransmissions by sending a VNAK.
This code could cause VNAKs to be sent erroneously in some cases, and to not
be sent in other cases when it should have been.
(closes issue #10237, reported and patched by mihai)
........
................
................
r75930 | russell | 2007-07-19 09:59:19 -0600 (Thu, 19 Jul 2007) | 6 lines
(closes issue #10210, reported and patched by juggie)
This merges the trunk only part of the patches from this issue. In 1.4, res_agi
will issue a warning if you try to use DeadAGI on a channel that is not hung up.
Now, in trunk, it just plain won't let you do it.
................
r75977 | mmichelson | 2007-07-19 10:29:51 -0600 (Thu, 19 Jul 2007) | 18 lines
Merged revisions 75969 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75969 | mmichelson | 2007-07-19 11:26:10 -0500 (Thu, 19 Jul 2007) | 10 lines
Changes in handling return values of several functions in app_queue. This all started as a fix for issue #10008
but now includes all of the following changes:
1. Simplifying the code to handle positive return values from ast API calls.
2. Removing the background_file function.
3. The fix for issue #10008
(closes issue #10008, reported and patched by dimas)
........
................
r75979 | mmichelson | 2007-07-19 13:02:38 -0600 (Thu, 19 Jul 2007) | 11 lines
Merged revisions 75978 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r75978 | mmichelson | 2007-07-19 13:59:30 -0500 (Thu, 19 Jul 2007) | 3 lines
The diff on this looks pretty big but all I did was remove a pointless if statement (always evaluates true).
........
................
r75981 | qwell | 2007-07-19 14:36:55 -0600 (Thu, 19 Jul 2007) | 9 lines
Blocked revisions 75980 via svnmerge
........
r75980 | qwell | 2007-07-19 15:36:06 -0500 (Thu, 19 Jul 2007) | 2 lines
Remove some duplicate code.
........
................
r75982 | murf | 2007-07-19 16:00:59 -0600 (Thu, 19 Jul 2007) | 1 line
This repairs a 'warning: ISO C90 forbids mixed declarations and code' message that cripples my dev-mode enabled build
................
r75983 | murf | 2007-07-19 17:24:27 -0600 (Thu, 19 Jul 2007) | 1 line
After some study, thought, comparing, etc. I've backed out the previous universal mod to make ast_flags a 64 bit thing. Instead, I added a 64-bit version of ast_flags (ast_flags64), and 64-bit versions of the test-flag, set-flag, etc. macros, and an app_parse_options64 routine, and I use these in app_dial alone, to eliminate the 30-option limit it had grown to meet. There is room now for 32 more options and flags. I was heavily tempted to implement some of the other ideas that were presented, but this solution does not intro any new versions of dial, doesn't have a different API, has a minimal/zero impact on code outside of dial, and doesn't seriously (I hope) affect the code structure of dial. It's the best I can think of right now. My goal was NOT to rewrite dial. I leave that to a future, coordinated effort.
................
r76015 | tilghman | 2007-07-19 19:54:52 -0600 (Thu, 19 Jul 2007) | 2 lines
Reduce some logging contention by switching several locks over to rwlocks
................
r76034 | rizzo | 2007-07-20 08:38:36 -0600 (Fri, 20 Jul 2007) | 13 lines
expose struct ast_ha so external code can do things such as printing it
(e.g. chan_sip.c in a subsequent commit).
Obviously exposing the internals of a data structure is far from ideal
(especially in a case like this where the implementation is very
inefficient and will need to be changed at some point).
On the other hand, it was also unclear what additional APIs should
we provide instead, and because exposing the stucture has no impact
on source and binary compatibility, this seemed to me the best option at
this time.
................
r76035 | rizzo | 2007-07-20 08:54:01 -0600 (Fri, 20 Jul 2007) | 33 lines
Extend the 'network settings' section with indication on the
localnet settings (requires the change in SVN 76034), and also
give an indication on whether/why/how the remapping of addresses
in SIP message is done or not.
I think this is especially useful for debugging the configuration,
as the address remapping depends on a combination of at least 3
parameters (localnet, externhost, externip) and successful DNS lookup.
An example of the output of this section is below:
Network Settings:
---------------------------
SIP address remapping: Enabled using externhost
Externhost: foo.dyndns.net
Externip: 80.64.128.23:0
Externrefresh: 10
Internal IP: 12.34.56.78:5060
Localnet: 192.168.0.0/255.255.0.0
10.0.0.0/255.0.0.0
I leave to the community the judgement if the above info is a
useful addition for 1.4. It is not a bugfix, but it is neither a
new feature, only a useful diagnostic tool.
Note that I would like to move there also the bindaddress/port
information, in the usual addr:port format e.g.
Bindaddress: 0.0.0.0:5060
so that network information is all in one place.
................
r76037 | rizzo | 2007-07-20 09:06:54 -0600 (Fri, 20 Jul 2007) | 8 lines
Don't use a field size for the last argument of printf format,
because in this case the string is left-aligned and it is not
truncated anyways.
Omitting the field size prevents the generation of trailing whitespace,
which makes the string fit in smaller windows.
................
r76055 | file | 2007-07-20 10:49:58 -0600 (Fri, 20 Jul 2007) | 9 lines
Blocked revisions 76054 via svnmerge
........
r76054 | file | 2007-07-20 13:49:13 -0300 (Fri, 20 Jul 2007) | 2 lines
Move makeannouncement variable declaration to proper place.
........
................
r76056 | file | 2007-07-20 10:51:09 -0600 (Fri, 20 Jul 2007) | 2 lines
It is impossible for the externhost variable to not exist, it is however possible for it to be empty.
................
r76070 | file | 2007-07-20 11:11:39 -0600 (Fri, 20 Jul 2007) | 14 lines
Merged revisions 76067 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r76067 | file | 2007-07-20 14:10:17 -0300 (Fri, 20 Jul 2007) | 6 lines
(closes issue #10246)
Reported by: fkasumovic
Patches:
res_conver.patch uploaded by fkasumovic (license #101)
Use the last occurance of . to find the extension, not the first occurance.
........
................
r76091 | file | 2007-07-20 11:21:23 -0600 (Fri, 20 Jul 2007) | 22 lines
Merged revisions 76087 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r76087 | file | 2007-07-20 14:20:09 -0300 (Fri, 20 Jul 2007) | 14 lines
Merged revisions 76080 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r76080 | file | 2007-07-20 14:16:48 -0300 (Fri, 20 Jul 2007) | 6 lines
(closes issue #10247)
Reported by: fkasumovic
Patches:
chan_sip.patch uploaded by fkasumovic (license #101)
Drop any peer realm authentication entries when reloading so multiple entries do not get added to the peer.
........
................
................
r76138 | russell | 2007-07-20 12:28:15 -0600 (Fri, 20 Jul 2007) | 14 lines
Merged revisions 76132 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r76132 | russell | 2007-07-20 13:22:24 -0500 (Fri, 20 Jul 2007) | 6 lines
Use the define that specifies the default length of an artificially created
DTMF digit in the ast_senddigit() function. The define is set to 100ms by
default, which is the same thing that this function was using. But, using
the define lets changes take effect in this case, as well as the others where
it was already used.
........
................
r76140 | mmichelson | 2007-07-20 12:44:30 -0600 (Fri, 20 Jul 2007) | 14 lines
Merged revisions 76139 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r76139 | mmichelson | 2007-07-20 13:42:27 -0500 (Fri, 20 Jul 2007) | 6 lines
When using users.conf for the entries in the directory, if multiple users had the same last name, only the first user listed would be available
in the directory.
(closes issue #10200, reported by mrskippy, patched by me)
........
................
r76175 | qwell | 2007-07-20 14:33:34 -0600 (Fri, 20 Jul 2007) | 10 lines
Merged revisions 76174 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r76174 | qwell | 2007-07-20 15:32:55 -0500 (Fri, 20 Jul 2007) | 2 lines
It's possible for sub->owner to be NULL here if you cancel the call immediately after/during sending a digit.
........
................
r76177 | qwell | 2007-07-20 14:56:07 -0600 (Fri, 20 Jul 2007) | 9 lines
Blocked revisions 76176 via svnmerge
........
r76176 | qwell | 2007-07-20 15:54:10 -0500 (Fri, 20 Jul 2007) | 2 lines
Eliminate a compiler warning with gcc 4.2 by constifying a char *
........
................
r76179 | qwell | 2007-07-20 15:04:27 -0600 (Fri, 20 Jul 2007) | 14 lines
Blocked revisions 76178 via svnmerge
........
r76178 | qwell | 2007-07-20 16:03:57 -0500 (Fri, 20 Jul 2007) | 7 lines
Allow getting a call from an existing "sub" channel.
Cancel ringing if endpoint hangs up before answering.
Fixes were backported from trunk (there was apparently a bit of confusion during merge of a previous patch).
(closes issue #10241)
........
................
r76213 | murf | 2007-07-20 15:41:51 -0600 (Fri, 20 Jul 2007) | 9 lines
Merged revisions 76211 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r76211 | murf | 2007-07-20 15:36:05 -0600 (Fri, 20 Jul 2007) | 1 line
This patch from 10249 is worth applying! It prevents downloading sound files if they are already downloaded. Darn Practical, if you ask me
........
................
r76216 | qwell | 2007-07-20 16:25:41 -0600 (Fri, 20 Jul 2007) | 6 lines
Add support for default "say mode" (whether to use the "old" method or "new" method. "new" method being config file)
Add support for autocomplete of "say load" CLI command.
Patch by IgorG
(closes issue #10243)
................
r76220 | murf | 2007-07-20 18:57:00 -0600 (Fri, 20 Jul 2007) | 1 line
This update was supplied in 10154; to allow announcemnts if the 'r' option (ringing) is provided.
................
r76221 | rizzo | 2007-07-20 19:01:10 -0600 (Fri, 20 Jul 2007) | 47 lines
Enhance NAT support as discussed on the -dev list, i.e.:
+ extensive documentation changes both in sip.conf.sample and in the source;
+ allow "externip" and "externhost" to include a port number as well;
+ allow "bindaddr" to have a port number (making bindport unnecessary,
even though it is still present for backward compatibility);
+ introduce the new "stunaddr" parameter to specify an STUN server to
be used from the main SIP socket;
+ extend the "sip show settings" output to show all the above.
Internally:
+ change related data structures from struct in_addr to struct sockaddr_in
to store the port numbers as well;
+ reorganize ast_sip_ouraddrfor() (should also be renamed to sip_ouraddrfor()
because it is not a generic API, though it might become so if called with
a socket as an additional argument, in which case it can be moved elsewhere).
As mentioned in the documentation, media sessions still do not use STUN so the
port numbers may still be incorrect when Asterisk is behind a NAT
On passing, some of the debugging messages printing media addresses are
probably using the wrong values, but this will be checked/fixed in a
subsequent commit if needed.
Part of the following chunk in the function that handles a "sip reload" is
probably needed on previous versions as well, to avoid leaking the memory
used for the "localaddr" list:
@@ -17244,13 +17274,17 @@
/* Reset IP addresses */
memset(&bindaddr, 0, sizeof(bindaddr));
+ memset(&stunaddr, 0, sizeof(stunaddr));
+ memset(&internip, 0, sizeof(internip));
+ /* Free memory for local network address mask */
+ ---> ast_free_ha(localaddr); <-----
memset(&localaddr, 0, sizeof(localaddr));
memset(&externip, 0, sizeof(externip));
memset(&default_prefs, 0 , sizeof(default_prefs));
................
r76222 | murf | 2007-07-20 19:08:46 -0600 (Fri, 20 Jul 2007) | 1 line
One small documentation update made to accompany 10154, the upgrading of the queue ringing to allow periodic announcments
................
r76224 | rizzo | 2007-07-20 19:25:13 -0600 (Fri, 20 Jul 2007) | 6 lines
We have two 'technology' descriptors for a SIP channel, so
define and use a macro to determine whether we are pointing to
one of them, so when one goes away (or a new one appears) we don't
have to touch all the code.
................
r76228 | russell | 2007-07-20 20:03:43 -0600 (Fri, 20 Jul 2007) | 19 lines
Blocked revisions 76227 via svnmerge
................
r76227 | russell | 2007-07-20 21:02:54 -0500 (Fri, 20 Jul 2007) | 12 lines
Merged revisions 76226 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r76226 | russell | 2007-07-20 21:01:46 -0500 (Fri, 20 Jul 2007) | 4 lines
Backport a fix for a memory leak that was fixed in trunk in reivision 76221
by rizzo. The memory used for the localaddr list was not freed during a
configuration reload.
........
................
................
r76229 | rizzo | 2007-07-20 20:33:25 -0600 (Fri, 20 Jul 2007) | 12 lines
Use ast_str_append() instead of ast_build_string() to construct
the sdp messages. Overall the code is slightly more readable
(because the string is fully described by a single pointer),
and more efficient (because the length is stored explicitly
so you don't need to do strlen()).
(I have been using this code for almost a year now.)
I wish we had infix string operators to do this sort of things!
Nothing to backport from this change.
................
r76231 | rizzo | 2007-07-20 21:53:17 -0600 (Fri, 20 Jul 2007) | 6 lines
use explicit variables for things that don't need to
be stored in ast_flags. First victim is 'SIP_NO_HISTORY'
replaced by a 'do_history' field in the sip_pvt structure.
................
r76278 | rizzo | 2007-07-21 03:18:50 -0600 (Sat, 21 Jul 2007) | 3 lines
more two more flags to proper variables: ALREADYGONE and NEEDDESTROY.
................
r76279 | rizzo | 2007-07-21 03:35:48 -0600 (Sat, 21 Jul 2007) | 4 lines
whoops... was setting needdestroy on the wrong dialog.
(spotted by a diff with my own branch)
................
r76296 | file | 2007-07-21 08:39:52 -0600 (Sat, 21 Jul 2007) | 2 lines
Add support for using /dev/urandom to get random numbers on systems that support it.
................
r76313 | rizzo | 2007-07-21 11:32:00 -0600 (Sat, 21 Jul 2007) | 8 lines
Add a note to document how the temporary 'pvt' should be initialized
before using it.
I am unclear on the details right now so i hope someone can comment
more. The obvious (and lazy) approach would be to bzero() all of it
(except for the string pool), but isn't that too much work ?
Feedback wanted here...
................
r76314 | rizzo | 2007-07-21 11:57:47 -0600 (Sat, 21 Jul 2007) | 3 lines
move the SIP_REALTIME flag to a field in the user/peer structure.
................
r76330 | rizzo | 2007-07-22 02:42:24 -0600 (Sun, 22 Jul 2007) | 13 lines
document the way sipdebug works, and implement it through
variables and not flags.
NOTE:
The old behaviour (preserved in this commit) is that if sipdebug
is set in the config file, it can only be disabled by reloading the
config. I am not sure if this is accidental or voluntary, but it
is really unconvenient and I think it should be handled in the same
way as other options i.e. consider requests from the config file
or the cli (or the command line) to be fully equivalent and act on
the same status variable.
................
r76348 | rizzo | 2007-07-22 11:27:52 -0600 (Sun, 22 Jul 2007) | 4 lines
minor clarification on the usage of SIP_* flags.
Also correct some items that were misclassified.
................
r76349 | rizzo | 2007-07-22 12:03:07 -0600 (Sun, 22 Jul 2007) | 2 lines
move two per-packet flags to proper variables.
................
r76365 | rizzo | 2007-07-22 12:41:57 -0600 (Sun, 22 Jul 2007) | 13 lines
Cleanup of flags used in struct sip_request, moving them to
individual variables. Apart from SIP_PKT_IGNORE which was used
a zillion times, the other two are used seldom.
On passing:
- move the arrays to the end of struct sip_request, so a (small)
buffer overflow is less likely to overwrite the other fields;
- note that the 'ignore' argument to handle_invite_replaces() is not
used and should be removed (will be done in a separate commit).
Nothing to backport in this change.
................
r76366 | rizzo | 2007-07-22 12:46:52 -0600 (Sun, 22 Jul 2007) | 4 lines
remove unused argument from handle_invite_replaces(), and also leftover
SIP_PKT_* stuff from the previous commit.
................
r76371 | rizzo | 2007-07-22 13:08:37 -0600 (Sun, 22 Jul 2007) | 9 lines
comment and slightly restructure handle_request() in the part that handles
responses, so that there is a common exit point.
Mark two places where probably we could return -1 instead of 0 to report
an error to the caller.
(change triggered by investigations on how the 'SIP_PKT_IGNORE' field was used).
nothing to backport from this commit
................
r76390 | rizzo | 2007-07-22 14:44:06 -0600 (Sun, 22 Jul 2007) | 3 lines
add two comment blocks, one on reusing nonces, and one on the handling
of an 'authpeer' local variable.
................
r76392 | rizzo | 2007-07-22 15:00:10 -0600 (Sun, 22 Jul 2007) | 9 lines
Make sip_destroy() return NULL so the caller can do things like
foo = sip_destroy(foo);
and reduce the chance of bugs due to dangling pointers.
Also remove a duplicate prototype for the function.
nothing to backport.
................
r76408 | rizzo | 2007-07-22 15:38:26 -0600 (Sun, 22 Jul 2007) | 5 lines
rewrite "sip show {channels|subscriptions}" CLI handler
using the new-style cli format.
No functional changes, nothing to backport.
................
r76458 | rizzo | 2007-07-22 20:46:10 -0600 (Sun, 22 Jul 2007) | 2 lines
add a bit of comments on internal functions.
................
r76467 | rizzo | 2007-07-22 21:10:31 -0600 (Sun, 22 Jul 2007) | 5 lines
Add some documentation on the sipregistry states and the
handling of the sip_register structures.
This commit only changes comments and whitespace.
................
r76486 | russell | 2007-07-23 06:29:46 -0600 (Mon, 23 Jul 2007) | 14 lines
Merged revisions 76485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r76485 | russell | 2007-07-23 07:25:01 -0500 (Mon, 23 Jul 2007) | 6 lines
Use a signed integer for storing the number of bytes in the packet read from
the network. Using an unsigned value here made it impossible to handle an
error returned from recvfrom(). Furthermore, in the case that recvfrom()
did return an error, this would cause a crash due to a heap overflow.
(closes issue #10265, reported by and fix suggested by timrobbins)
........
................
r76520 | file | 2007-07-23 07:24:03 -0600 (Mon, 23 Jul 2007) | 14 lines
Merged revisions 76519 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r76519 | file | 2007-07-23 10:23:09 -0300 (Mon, 23 Jul 2007) | 6 lines
(closes issue #10268)
Reported by: mvanbaak
Patches:
chan_skinny_openbsd.diff uploaded by mvanbaak (license 7)
[... 67296 lines stripped ...]
More information about the asterisk-commits
mailing list