[asterisk-commits] mmichelson: branch 1.4 r114257 - in /branches/1.4: channels/ main/

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Fri Apr 18 12:44:29 2008
New Revision: 114257

URL: http://svn.digium.com/view/asterisk?view=rev&rev=114257
Log:
Clearing up error messages so they make a bit more sense. Also removing a redundant error
message.

Issue AST-15


Modified:
    branches/1.4/channels/chan_zap.c
    branches/1.4/main/callerid.c

Modified: branches/1.4/channels/chan_zap.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_zap.c?view=diff&rev=114257&r1=114256&r2=114257
==============================================================================
--- branches/1.4/channels/chan_zap.c (original)
+++ branches/1.4/channels/chan_zap.c Fri Apr 18 12:44:29 2008
@@ -6223,7 +6223,7 @@
 							}
 
 							if (res < 0) {
-								ast_log(LOG_WARNING, "CallerID feed failed: %s\n", strerror(errno));
+								ast_log(LOG_WARNING, "CallerID feed failed on channel '%s'\n", chan->name);
 								break;
 							} else if (res)
 								break;
@@ -6234,9 +6234,6 @@
 					if (res == 1) {
 						callerid_get(cs, &name, &number, &flags);
 						ast_log(LOG_NOTICE, "CallerID number: %s, name: %s, flags=%d\n", number, name, flags);
-					}
-					if (res < 0) {
-						ast_log(LOG_WARNING, "CallerID returned with error on channel '%s'\n", chan->name);
 					}
 
 					if (p->cid_signalling == CID_SIG_V23_JP) {

Modified: branches/1.4/main/callerid.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/callerid.c?view=diff&rev=114257&r1=114256&r2=114257
==============================================================================
--- branches/1.4/main/callerid.c (original)
+++ branches/1.4/main/callerid.c Fri Apr 18 12:44:29 2008
@@ -305,7 +305,7 @@
 		res = fsk_serie(&cid->fskd, buf, &mylen, &b);
 
 		if (mylen < 0) {
-			ast_log(LOG_ERROR, "fsk_serie made mylen < 0 (%d)\n", mylen);
+			ast_log(LOG_ERROR, "No start bit found in fsk data.\n");
 			free(obuf);
 			return -1;
 		}
@@ -561,7 +561,7 @@
 		olen = mylen;
 		res = fsk_serie(&cid->fskd, buf, &mylen, &b);
 		if (mylen < 0) {
-			ast_log(LOG_ERROR, "fsk_serie made mylen < 0 (%d)\n", mylen);
+			ast_log(LOG_ERROR, "No start bit found in fsk data.\n");
 			free(obuf);
 			return -1;
 		}