[asterisk-commits] murf: trunk r114187 - in /trunk: include/asterisk/lock.h main/utils.c

[SVN commits to the Asterisk project]

Author: murf
Date: Wed Apr 16 15:54:41 2008
New Revision: 114187

URL: http://svn.digium.com/view/asterisk?view=rev&rev=114187
Log:
A small enhancement-- I added the routine log_show_lock to utils.c, which if the mentioned lock has been acquired, this routine will log to the console the normal info about that lock you'd see from the CLI when you do a 'core show locks'. It's solely for debug-- if the lock is NOT acquired, there is no output. I use it to show 'unexpected' locks, to see where/why a lock is pre-locked. This command is to be called from points of interest, like just before a trylock, and helps to spot fleeting, highly temporal locks that normally are not locked...

Modified:
    trunk/include/asterisk/lock.h
    trunk/main/utils.c

Modified: trunk/include/asterisk/lock.h
URL: http://svn.digium.com/view/asterisk/trunk/include/asterisk/lock.h?view=diff&rev=114187&r1=114186&r2=114187
==============================================================================
--- trunk/include/asterisk/lock.h (original)
+++ trunk/include/asterisk/lock.h Wed Apr 16 15:54:41 2008
@@ -185,6 +185,18 @@
 #else
 #define ast_remove_lock_info(ignore)
 #endif
+
+
+
+/*!
+ * \brief log info for the current lock with ast_log().
+ *
+ * this function would be mostly for debug. If you come across a lock
+ * that is unexpectedly but momentarily locked, and you wonder who
+ * are fighting with for the lock, this routine could be called, IF
+ * you have the thread debugging stuff turned on.
+ */
+void log_show_lock(void *this_lock_addr);
 
 static void __attribute__((constructor)) init_empty_mutex(void)
 {

Modified: trunk/main/utils.c
URL: http://svn.digium.com/view/asterisk/trunk/main/utils.c?view=diff&rev=114187&r1=114186&r2=114187
==============================================================================
--- trunk/main/utils.c (original)
+++ trunk/main/utils.c Wed Apr 16 15:54:41 2008
@@ -714,6 +714,54 @@
 	return "UNKNOWN";
 }
 
+void log_show_lock(void *this_lock_addr)
+{
+	struct thr_lock_info *lock_info;
+	struct ast_str *str;
+
+	pthread_mutex_lock(&lock_infos_lock.mutex);
+	AST_LIST_TRAVERSE(&lock_infos, lock_info, entry) {
+		int i;
+		pthread_mutex_lock(&lock_info->lock);
+		for (i = 0; str && i < lock_info->num_locks; i++) {
+			int j;
+			ast_mutex_t *lock;
+			if (lock_info->locks[i].lock_addr == this_lock_addr) {
+				
+				ast_log(LOG_NOTICE, "---> %sLock #%d (%s): %s %d %s %s %p (%d)\n", 
+						lock_info->locks[i].pending > 0 ? "Waiting for " : lock_info->locks[i].pending < 0 ? "Tried and failed to get " : "", 
+						i,
+						lock_info->locks[i].file, 
+						locktype2str(lock_info->locks[i].type),
+						lock_info->locks[i].line_num,
+						lock_info->locks[i].func, 
+						lock_info->locks[i].lock_name,
+						lock_info->locks[i].lock_addr, 
+						lock_info->locks[i].times_locked);
+				
+				if (!lock_info->locks[i].pending || lock_info->locks[i].pending == -1)
+					continue;
+				
+				/* We only have further details for mutexes right now */
+				if (lock_info->locks[i].type != AST_MUTEX)
+					continue;
+				
+				lock = lock_info->locks[i].lock_addr;
+				
+				ast_reentrancy_lock(lock);
+				for (j = 0; str && j < lock->reentrancy; j++) {
+					ast_log(LOG_NOTICE, "--- ---> Locked Here: %s line %d (%s)\n",
+								   lock->file[j], lock->lineno[j], lock->func[j]);
+				}
+				ast_reentrancy_unlock(lock);	
+			}
+		}
+		pthread_mutex_unlock(&lock_info->lock);
+	}
+	pthread_mutex_unlock(&lock_infos_lock.mutex);
+}
+
+
 static char *handle_show_locks(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)
 {
 	struct thr_lock_info *lock_info;
@@ -740,7 +788,7 @@
 	               "=== Currently Held Locks ==============================================\n"
 	               "=======================================================================\n"
 	               "===\n"
-	               "=== <file> <line num> <function> <lock name> <lock addr> (times locked)\n"
+	               "=== <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock addr> (times locked)\n"
 	               "===\n");
 
 	if (!str)