[asterisk-commits] qwell: branch 1.4 r114133 - /branches/1.4/apps/app_queue.c

[SVN commits to the Asterisk project]

Author: qwell
Date: Tue Apr 15 11:18:08 2008
New Revision: 114133

URL: http://svn.digium.com/view/asterisk?view=rev&rev=114133
Log:
Allow autofill to work in the general section of queues.conf.
Additionally, don't try to (re)set options when they have empty values in realtime (all unset columns would have an empty value).

(closes issue #12445)
Reported by: atis
Patches:
      12445-autofill.diff uploaded by qwell (license 4)

Modified:
    branches/1.4/apps/app_queue.c

Modified: branches/1.4/apps/app_queue.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_queue.c?view=diff&rev=114133&r1=114132&r2=114133
==============================================================================
--- branches/1.4/apps/app_queue.c (original)
+++ branches/1.4/apps/app_queue.c Tue Apr 15 11:18:08 2008
@@ -822,7 +822,6 @@
 	q->reportholdtime = 0;
 	q->monjoin = 0;
 	q->wrapuptime = 0;
-	q->autofill = 0;
 	q->joinempty = 0;
 	q->leavewhenempty = 0;
 	q->memberdelay = 0;
@@ -1243,7 +1242,11 @@
 				*tmp++ = '-';
 		} else
 			tmp_name = v->name;
-		queue_set_param(q, tmp_name, v->value, -1, 0);
+
+		if (!ast_strlen_zero(v->value)) {
+			/* Don't want to try to set the option if the value is empty */
+			queue_set_param(q, tmp_name, v->value, -1, 0);
+		}
 	}
 
 	if (q->strategy == QUEUE_STRATEGY_ROUNDROBIN)