[asterisk-commits] juggie: branch group/NoLossCDR-Redux2 r113926 - in /team/group/NoLossCDR-Redu...

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Wed Apr 9 15:39:05 CDT 2008


Author: juggie
Date: Wed Apr  9 15:39:04 2008
New Revision: 113926

URL: http://svn.digium.com/view/asterisk?view=rev&rev=113926
Log:
Merged revisions 110780,110831,110881,110911,110930,110963,111012-111013,111017,111021-111022,111025,111028,111036,111067,111083,111123,111127,111130,111132,111185,111213,111246,111285,111295,111360,111410,111443,111497,111500,111533,111565,111606,111659,111662,111721,111773-111774,111777,111811,111857,111908-111909,111961,111996,111998,112033,112035,112069,112071,112124,112126,112148,112155,112205,112207,112210,112234,112241,112252,112289,112321,112351,112357,112360,112394,112426,112431,112469,112520,112564,112600,112653,112656,112708,112710,112712,112714,112785,112821,112874,112906,112939,112972,113009,113013,113066,113119,113170,113172,113207,113241,113243,113245,113297,113349,113400,113403,113452,113455,113505,113508,113559,113597,113647,113649,113682,113731,113752,113785,113834,113836,113838,113840,113875 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r110780 | qwell | 2008-03-25 18:51:55 -0400 (Tue, 25 Mar 2008) | 14 lines

Merged revisions 110779 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r110779 | qwell | 2008-03-25 17:51:17 -0500 (Tue, 25 Mar 2008) | 6 lines

Make file access in cdr_custom similar to cdr_csv.

Fixes issue #12268.

Patch borrowed from r82344

........

................
r110831 | mmichelson | 2008-03-25 20:02:31 -0400 (Tue, 25 Mar 2008) | 6 lines

This ensures that the manager interface is not enabled by default. Prior to this
change, it was possible to start Asterisk with the manager interface enabled, then
either comment out the enabled option or make manager.conf unopenable and the manager
interface would still be enabled.


................
r110881 | kpfleming | 2008-03-26 13:10:28 -0400 (Wed, 26 Mar 2008) | 18 lines

Merged revisions 110880 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r110880 | kpfleming | 2008-03-26 09:42:35 -0700 (Wed, 26 Mar 2008) | 10 lines

Merged revisions 110869 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r110869 | kpfleming | 2008-03-26 08:53:46 -0700 (Wed, 26 Mar 2008) | 2 lines

due to licensing restrictions, we cannot distribute the source code for iLBC encoding and decoding... so remove it, and add instructions on how the user can obtain it themselves

........

................

................
r110911 | juggie | 2008-03-26 13:24:54 -0400 (Wed, 26 Mar 2008) | 8 lines

update documentation to reflect the changes in the way configure detects net-snmp.

(closes issue #12067)
Reported by: juggie
Patches:
      12067_snmp_doc.patch uploaded by juggie (license 24)
Tested by: juggie

................
r110930 | juggie | 2008-03-26 13:28:49 -0400 (Wed, 26 Mar 2008) | 1 line

revert something dumb, because i was running svn diff in a subfolder not the root of trunk, before doing my commit and did not see it
................
r110963 | kpfleming | 2008-03-26 13:44:09 -0400 (Wed, 26 Mar 2008) | 10 lines

Merged revisions 110962 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r110962 | kpfleming | 2008-03-26 12:43:02 -0500 (Wed, 26 Mar 2008) | 2 lines

add note that the user will need to enable codec_ilbc to get it to build

........

................
r111012 | tilghman | 2008-03-26 14:39:06 -0400 (Wed, 26 Mar 2008) | 3 lines

Add the "config reload <conffile>" command, which allows you to tell Asterisk
to reload any file that references a given configuration file.

................
r111013 | tilghman | 2008-03-26 14:41:27 -0400 (Wed, 26 Mar 2008) | 2 lines

Oops, fix this, too

................
r111017 | file | 2008-03-26 14:42:52 -0400 (Wed, 26 Mar 2008) | 12 lines

Merged revisions 110628 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r110628 | file | 2008-03-25 11:37:35 -0300 (Tue, 25 Mar 2008) | 4 lines

Add an option (transmit_silence) which transmits silence during both Record() and DTMF generation. The reason this is an option is that in order to transmit silence we have to setup a translation path. This may not be needed/wanted in all cases.
(closes issue #10058)
Reported by: tracinet

........

................
r111021 | file | 2008-03-26 15:05:42 -0400 (Wed, 26 Mar 2008) | 12 lines

Merged revisions 111020 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111020 | file | 2008-03-26 16:04:35 -0300 (Wed, 26 Mar 2008) | 4 lines

If we are requested to authenticate a reinvite make sure that it contains T38 SDP if need be.
(closes issue #11995)
Reported by: fall

........

................
r111022 | qwell | 2008-03-26 15:05:51 -0400 (Wed, 26 Mar 2008) | 23 lines

Large cleanup of DSP code

Per comments from dimas:
1. The code now generates DTMF_BEGIN frames in addition to DTMF_END ones.

2. "quelching" rewritten - now each detector (MF/DTMF/generic tone) may mark fragment of a frame for suppression (squelching, muting) with a call to mute_fragment. Actual muting happens only once at the very end of ast_dsp_process where all marked fragments are zeroed. This way every detector sees original data in the frame without any piece of a frame being zeroed by a detector which was run before.

3. DTMF detector tries to "mute" one block before and one block after the block where actual tone was detected. Muting of previois block is something new for this patch. Obviously this operation is not always possible - if current frame does not contain data for previous block - it is too late. But at least we make our best.
Muting of next block was already done by the old code but it only affects part of the next block which is in the frame being processed. New code keeps this information in state structures so it will mute proper number of samples in the next frame(s) too.

4. Removed ast_dsp_digitdetect and ast_dsp_getdigits APIs because these are not used.

5. DSP API extended a bit - ast_dsp_was_muted() function added which returns true if DSP code was muting any fragment in the last frame. chan_zap uses this function to decide it needs to turn on confmute on the channel.
This is to replace AST_FRAME_DTMF 'm'/'u' (mute/unmute) functionality.


(closes issue #11968)
Reported by: dimas
Patches:
      v2-11968-dsp.patch uploaded by dimas (license 88)
      v4-11968-zap.patch uploaded by dimas (license 88)
Tested by: dimas, qwell

................
r111025 | kpfleming | 2008-03-26 15:08:00 -0400 (Wed, 26 Mar 2008) | 18 lines

Merged revisions 111024 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r111024 | kpfleming | 2008-03-26 14:06:56 -0500 (Wed, 26 Mar 2008) | 10 lines

Merged revisions 111019 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r111019 | kpfleming | 2008-03-26 13:58:37 -0500 (Wed, 26 Mar 2008) | 2 lines

add a script to make getting the iLBC source code simple for end users

........

................

................
r111028 | qwell | 2008-03-26 15:16:31 -0400 (Wed, 26 Mar 2008) | 4 lines

Only try to detect silence when we actually need to, instead of...always.

If this is wrong, I'd love to hear why.

................
r111036 | tilghman | 2008-03-26 15:19:31 -0400 (Wed, 26 Mar 2008) | 2 lines

Add a linkedlist macro that maintains a sorted list

................
r111067 | mmichelson | 2008-03-26 15:26:23 -0400 (Wed, 26 Mar 2008) | 17 lines

Merged revisions 111049 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111049 | mmichelson | 2008-03-26 14:22:16 -0500 (Wed, 26 Mar 2008) | 9 lines

Add a lock to the vm_state structure and use the lock around mail_open calls
to prevent concurrent access of the same mailstream. This, along with trunk's
ability to configure TCP timeouts for IMAP storage will help to prevent
crashes and hangs when using voicemail with IMAP storage.

(closes issue #10487)
Reported by: ewilhelmsen


........

................
r111083 | file | 2008-03-26 15:29:26 -0400 (Wed, 26 Mar 2008) | 4 lines

Add expiry value to the sip show subscriptions CLI command.
(closes issue #12025)
Reported by: agx

................
r111123 | mmichelson | 2008-03-26 15:39:23 -0400 (Wed, 26 Mar 2008) | 12 lines

Merged revisions 111121 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111121 | mmichelson | 2008-03-26 14:37:36 -0500 (Wed, 26 Mar 2008) | 4 lines

This code change is made just for clarification. It does exactly
the same thing as before. It just doesn't look as wrong.


........

................
r111127 | kpfleming | 2008-03-26 15:52:27 -0400 (Wed, 26 Mar 2008) | 18 lines

Merged revisions 111126 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r111126 | kpfleming | 2008-03-26 14:51:24 -0500 (Wed, 26 Mar 2008) | 10 lines

Merged revisions 111125 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r111125 | kpfleming | 2008-03-26 14:49:30 -0500 (Wed, 26 Mar 2008) | 2 lines

update UPGRADE notes to document usage of the script

........

................

................
r111130 | file | 2008-03-26 15:56:40 -0400 (Wed, 26 Mar 2008) | 14 lines

Merged revisions 111129 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111129 | file | 2008-03-26 16:55:08 -0300 (Wed, 26 Mar 2008) | 6 lines

Update autosupport script.
(closes issue #12310)
Reported by: angler
Patches:
      autosupport.diff uploaded by angler (license 106)

........

................
r111132 | tilghman | 2008-03-26 15:58:09 -0400 (Wed, 26 Mar 2008) | 2 lines

Simplify new macro, simplify configfile logic, now that list is sorted

................
r111185 | tilghman | 2008-03-26 16:34:05 -0400 (Wed, 26 Mar 2008) | 2 lines

Oops, missed one

................
r111213 | twilson | 2008-03-26 17:23:29 -0400 (Wed, 26 Mar 2008) | 2 lines

Stupid strcasecmp function :-)

................
r111246 | qwell | 2008-03-26 19:27:33 -0400 (Wed, 26 Mar 2008) | 17 lines

Merged revisions 111245 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111245 | qwell | 2008-03-26 18:26:33 -0500 (Wed, 26 Mar 2008) | 9 lines

Remove excessive smoother optimization that was causing audio glitches (small "pops")
 after (about 200ms later) an "incorrectly" sized frame was received.

While it would be very nice to keep this as optimized as possible, it makes no sense
 for the smoother to be dropping random bits of audio like this.  Isn't that the
 whole point of a smoother?

Closes issue #12093.

........

................
r111285 | qwell | 2008-03-26 20:25:56 -0400 (Wed, 26 Mar 2008) | 9 lines

Merged revisions 111280 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111280 | qwell | 2008-03-26 19:25:13 -0500 (Wed, 26 Mar 2008) | 1 line

Put this flag back so we don't change the API.
........

................
r111295 | qwell | 2008-03-26 20:27:35 -0400 (Wed, 26 Mar 2008) | 1 line

But we can change the API here.
................
r111360 | murf | 2008-03-27 00:47:12 -0400 (Thu, 27 Mar 2008) | 23 lines

Merged revisions 111341 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111341 | murf | 2008-03-26 21:21:05 -0600 (Wed, 26 Mar 2008) | 15 lines


(closes issue #12302)
Reported by: pj
Tested by: murf

These changes will set a channel variable ~~EXTEN~~ just before generating code
for a switch, with the value of ${EXTEN}. The exten is marked as having a switch, 
and ever after that, till the end of the exten, we substitute any ${EXTEN} 
with ${~~EXTEN~~} instead in application arguments; (and the ${EXTEN: also). 
The reason for this, is that because switches are coded using 
separate extensions to provide pattern matching, and
jumping to/from these switch extensions messes up the ${EXTEN} value, 
which blows the minds of users.


........

................
r111410 | murf | 2008-03-27 09:29:41 -0400 (Thu, 27 Mar 2008) | 17 lines

Merged revisions 111391 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111391 | murf | 2008-03-27 07:03:28 -0600 (Thu, 27 Mar 2008) | 9 lines

These small documentation updates made in response to a query in
asterisk-users, where a user was using Playback, but needed the
features of Background, and had no idea that Background existed,
or that it might provide the features he needed. I thought the
best way to avert these kinds of queries was to provide "See Also"
references in all three of "Background", "Playback", "WaitExten".
Perhaps a project to do this with all related apps is in order.


........

................
r111443 | tilghman | 2008-03-27 15:26:45 -0400 (Thu, 27 Mar 2008) | 14 lines

Merged revisions 111442 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111442 | tilghman | 2008-03-27 14:23:12 -0500 (Thu, 27 Mar 2008) | 6 lines

For FreeBSD, at least, the ifa_addr element could be NULL.
(closes issue #12300)
 Reported by: festr
 Patches: 
       acl.c.patch uploaded by festr (license 443)

........

................
r111497 | murf | 2008-03-27 17:25:55 -0400 (Thu, 27 Mar 2008) | 1 line

comment cleanup and iron out a really dumb mistake in handling the '.'-wildcard in the new exten pattern matcher.
................
r111500 | twilson | 2008-03-27 18:10:25 -0400 (Thu, 27 Mar 2008) | 2 lines

Fix another little http problem.  In making it match coding guidelines, a comparison was dropped

................
r111533 | mmichelson | 2008-03-27 20:12:52 -0400 (Thu, 27 Mar 2008) | 10 lines

Fix a crash that would happen when attempting to unload the app_queue module.

The problem was that when the refcount on the queue hit 0, the destructor was
called, and inside the destructor, another function was called which would increase
the refcount back to 1 again and then decrease it again back to 0 for every member
in the queue. This meant that the destructor was being recursively called, leading
to a double free of the queue. This is now fixed by making sure to unlink the
queue from the queues container prior to the final unref of the queue.


................
r111565 | file | 2008-03-27 20:55:47 -0400 (Thu, 27 Mar 2008) | 2 lines

Forgetting to unregister a manager action is bad, mmmk?

................
r111606 | tilghman | 2008-03-28 10:37:28 -0400 (Fri, 28 Mar 2008) | 11 lines

Merged revisions 111605 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111605 | tilghman | 2008-03-28 09:35:45 -0500 (Fri, 28 Mar 2008) | 3 lines

Update debugging text, since Valgrind eliminated the --log-file-exactly option.
(Closes issue #12320)

........

................
r111659 | qwell | 2008-03-28 12:20:59 -0400 (Fri, 28 Mar 2008) | 16 lines

Merged revisions 111658 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111658 | qwell | 2008-03-28 11:19:56 -0500 (Fri, 28 Mar 2008) | 8 lines

The file size of WAV49 does not need to be an even number.

(closes issue #12128)
Reported by: mdu113
Patches:
      12128-noevenlength.diff uploaded by qwell (license 4)
Tested by: qwell, mdu113

........

................
r111662 | mmichelson | 2008-03-28 12:36:59 -0400 (Fri, 28 Mar 2008) | 9 lines

The copy_request function did not take into account the necessary null terminator
for the string to be copied into. This resulted in parse_request reading invalid
memory beyond the end of the string, and in some cases led to crashes. Thanks
to falves11 for providing the valgrind output which led to the closure of this issue.

(closes issue #12284)
Reported by: falves11


................
r111721 | qwell | 2008-03-28 13:57:12 -0400 (Fri, 28 Mar 2008) | 9 lines

Merged revisions 111720 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111720 | qwell | 2008-03-28 12:55:05 -0500 (Fri, 28 Mar 2008) | 1 line

Remove unimplemented softkeys.  Prompted by issue #12325.
........

................
r111773 | qwell | 2008-03-28 15:06:54 -0400 (Fri, 28 Mar 2008) | 7 lines

Add a bit of doxygen documentation for app_voicemail.

(issue #12326)
Reported by: travishein
Patches:
      app_voicemail_code_documentation.patch uploaded by travishein (license 385)

................
r111774 | qwell | 2008-03-28 15:08:35 -0400 (Fri, 28 Mar 2008) | 8 lines

Replace magic number size from msgArray array with a define.

(same patch as before, I just split this part out)
(close issue #12326)
Reported by: travishein
Patches:
      app_voicemail_code_documentation.patch uploaded by travishein (license 385)

................
r111777 | mmichelson | 2008-03-28 15:14:51 -0400 (Fri, 28 Mar 2008) | 6 lines

Temporary revert of 111662. It's causing lots of trouble and appears to not be
the proper solution to the problem reported anyway.

(related to issue #12884)


................
r111811 | mmichelson | 2008-03-28 16:03:16 -0400 (Fri, 28 Mar 2008) | 11 lines

This time the fix is proper for issue 12284. I have tested it thoroughly and found
that valgrind no longer complains and that calls do complete correctly.

The fix is along the same lines as before: Make sure the final null terminator gets copied
into the new sip_request's data pointer. Without it, parse_request will read and potentially
write past the end of the string, causing potential crashes.

(closes issue #12284...for real this time!)
reported by falves11


................
r111857 | qwell | 2008-03-28 17:46:02 -0400 (Fri, 28 Mar 2008) | 20 lines

Merged revisions 111856 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111856 | qwell | 2008-03-28 16:45:35 -0500 (Fri, 28 Mar 2008) | 12 lines

Allow gsm to compile correctly on x86 with gcc4 optimizations.

(closes issue #11243)
Reported by: whiskerp
Patches:
      11243-maybe-asm.diff uploaded by qwell (license 4)
Tested by: Seggy (IRC)

Note: While I did write this patch, I would not have found this if fossil
 had not reported and fixed issue #12253.  A huge thanks to him for helping
 to (indirectly) find the problem here.

........

................
r111908 | russell | 2008-03-28 18:45:43 -0400 (Fri, 28 Mar 2008) | 3 lines

Note a minor race condition that I noticed while reviewing Jeff's changes
to this code.

................
r111909 | russell | 2008-03-28 18:50:46 -0400 (Fri, 28 Mar 2008) | 3 lines

Make some notes about common usage of pbx_builtin_getvar_helper() that is not
thread-safe.

................
r111961 | file | 2008-03-31 10:20:39 -0400 (Mon, 31 Mar 2008) | 4 lines

Initialize all these here tmp pointers at declaration. They confused some compilers a wee bit.
(closes issue #12333)
Reported by: ovi

................
r111996 | russell | 2008-03-31 12:37:13 -0400 (Mon, 31 Mar 2008) | 2 lines

This fixes a high fence violation that MALLOC_DEBUG reported to me.

................
r111998 | russell | 2008-03-31 13:14:58 -0400 (Mon, 31 Mar 2008) | 7 lines

Ensure configure gets run on a clean checkout.

(closes issue #12197)
Reported by: juggie
Patches:
      12197.diff uploaded by juggie (license 24)

................
r112033 | twilson | 2008-03-31 16:45:05 -0400 (Mon, 31 Mar 2008) | 2 lines

Handle blank prefix= in http.conf

................
r112035 | twilson | 2008-03-31 17:01:59 -0400 (Mon, 31 Mar 2008) | 2 lines

Yeah, simplify that logic a bit...

................
r112069 | qwell | 2008-03-31 17:48:30 -0400 (Mon, 31 Mar 2008) | 13 lines

Merged revisions 112068 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112068 | qwell | 2008-03-31 16:48:05 -0500 (Mon, 31 Mar 2008) | 5 lines

Fix a silly infinite loop when choosing an invalid option.

(closes issue #12315)
Reported by: jmls

........

................
r112071 | qwell | 2008-03-31 18:16:34 -0400 (Mon, 31 Mar 2008) | 7 lines

I missed a place when this define was changed.

(closes issue #12334)
Reported by: ovi
Patches:
      12334-asterisk.patch uploaded by dimas (license 88)

................
r112124 | russell | 2008-04-01 12:35:04 -0400 (Tue, 01 Apr 2008) | 2 lines

Now that zaptel trunk has been removed, add the PSTN deprecation notice to chan_zap, as well.

................
r112126 | file | 2008-04-01 12:50:37 -0400 (Tue, 01 Apr 2008) | 13 lines

Merged revisions 112125 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112125 | file | 2008-04-01 13:45:14 -0300 (Tue, 01 Apr 2008) | 5 lines

Ensure that we do not exceed the hold's maximum size with a single frame.
(closes issue #12047)
Reported by: fabianoheringer
Tested by: fabianoheringer

........

................
r112148 | mmichelson | 2008-04-01 13:23:19 -0400 (Tue, 01 Apr 2008) | 18 lines

Merged revisions 112138 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112138 | mmichelson | 2008-04-01 12:21:21 -0500 (Tue, 01 Apr 2008) | 10 lines

Initialize the __res_state structure used for dns purposes
to all 0's prior to using it. This is due to valgrind's complaints
on issue #12284 as well as an excerpt found in "Description" portion
of the online man page found here:

http://www.iti.cs.tu-bs.de/cgi-bin/UNIXhelp/man-cgi?res_nquery+3RESOLV

(pertains to issue #12284 but does not necessarily close it)


........

................
r112155 | file | 2008-04-01 13:24:45 -0400 (Tue, 01 Apr 2008) | 6 lines

Demote a log message down to a warning.
(closes issue #12345)
Reported by: caio1982
Patches:
      limit_msg.diff uploaded by caio1982 (license 22)

................
r112205 | file | 2008-04-01 13:48:52 -0400 (Tue, 01 Apr 2008) | 12 lines

Merged revisions 112204 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112204 | file | 2008-04-01 14:43:46 -0300 (Tue, 01 Apr 2008) | 4 lines

Do not pass audio until the remote side has indicated they are providing early media, or if the channel has been answered.
(closes issue #11823)
Reported by: SDamm

........

................
r112207 | jpeeler | 2008-04-01 13:53:08 -0400 (Tue, 01 Apr 2008) | 3 lines

This adds DNS SRV record support to DNS manager.  If there is a SRV record for a given domain, the hostname and port listed in the SRV record will be used. If no SRV record exists or a SRV lookup is not attempted, the DNS lookup on the specified domain will be performed as normal. Chan_sip has been modified to take advantage of the new SRV support.


................
r112210 | file | 2008-04-01 14:06:13 -0400 (Tue, 01 Apr 2008) | 12 lines

Merged revisions 112209 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112209 | file | 2008-04-01 15:02:43 -0300 (Tue, 01 Apr 2008) | 4 lines

Disable Packet2Packet bridging when we need to feed DTMF frames into the core. Some implementations do not like how we switch between things.
(closes issue #12212)
Reported by: bamby

........

................
r112234 | tilghman | 2008-04-01 14:23:40 -0400 (Tue, 01 Apr 2008) | 2 lines

Fix last commit

................
r112241 | qwell | 2008-04-01 14:24:56 -0400 (Tue, 01 Apr 2008) | 7 lines

More voicemail doxygen additions/cleanup.

(issue #12343)
Reported by: travishein
Patches:
      app_voicemail_code_documentation.patch uploaded by travishein (license 385)

................
r112252 | qwell | 2008-04-01 14:27:08 -0400 (Tue, 01 Apr 2008) | 7 lines

Minor formatting cleanup.

(closes issue #12343)
Reported by: travishein
Patches:
      app_voicemail_code_convention.patch uploaded by travishein (license 385)

................
r112289 | murf | 2008-04-01 16:02:19 -0400 (Tue, 01 Apr 2008) | 21 lines

(closes issue #12298)
Reported by: falves11
Patches:
      12298.patch1 uploaded by murf (license 17)
Tested by: murf

I have hopes that the changes made over the last few days will
finalize and solidify this code. While there are bound to be 
small tweaks still needed, I feel that the job (at last) is
somewhat completed. Finally, I had a chance to comprehend how
the scoring of extension patterns was done in the previous
version, and I've come very close to using the exact same
criteria in the new pattern matching code. The left-right
sorting is now replicated in the trie structure itself, such
that the first match found will the 'best' match. Compared
the results against 1.4 for several extensions. Replicated
falves11's setup and it works. Used some devious patterns
provided by jsmith, supplemented with a few of my own.
Looks good.


................
r112321 | jpeeler | 2008-04-01 18:07:30 -0400 (Tue, 01 Apr 2008) | 2 lines

Existing DNS manager lookups extended to check for SRV records.

................
r112351 | russell | 2008-04-01 18:25:45 -0400 (Tue, 01 Apr 2008) | 2 lines

Fix a typo that prevented configuration of non-dynamic peers.

................
r112357 | murf | 2008-04-01 18:45:10 -0400 (Tue, 01 Apr 2008) | 1 line

Bumped across another test set for the new exten pattern matcher, which revealed a problem with the CANMATCH/MATCHMORE modes. Direct matches were getting in the way. Fixed.
................
r112360 | jpeeler | 2008-04-01 18:55:28 -0400 (Tue, 01 Apr 2008) | 2 lines

Added dnsmgr status output for sip show registry.

................
r112394 | mmichelson | 2008-04-02 10:32:43 -0400 (Wed, 02 Apr 2008) | 14 lines

Merged revisions 112393 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112393 | mmichelson | 2008-04-02 09:32:00 -0500 (Wed, 02 Apr 2008) | 6 lines

Ensure that there is no timeout if none is specified.

(closes issue #12349)
Reported by: johnlange


........

................
r112426 | twilson | 2008-04-02 11:25:48 -0400 (Wed, 02 Apr 2008) | 2 lines

Re-add HTTP post support by moving to res_http_post.c

................
r112431 | file | 2008-04-02 11:26:51 -0400 (Wed, 02 Apr 2008) | 7 lines

Since the SIP request structure gets reused multiple times with TCP handling we have to clear the debug state or else we will keep spitting out debug even after it has been turned off.
(closes issue #12169)
Reported by: pj
Patches:
      12169-debugoff-2.diff uploaded by qwell (license 4)
Tested by: pj

................
r112469 | mmichelson | 2008-04-02 13:36:49 -0400 (Wed, 02 Apr 2008) | 21 lines

Merged revisions 112468 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112468 | mmichelson | 2008-04-02 12:36:04 -0500 (Wed, 02 Apr 2008) | 13 lines

Fix a race condition in the manager. It is possible that a new manager event
could be appended during a brief time when the manager is not waiting for input.
If an event comes during this period, we need to set an indicator that there is an
event pending so that the manager doesn't attempt to wait forever for an event that
already happened.

(closes issue #12354)
Reported by: bamby
Patches:
      manager_race_condition.diff uploaded by bamby (license 430)
	  (comments added by me)


........

................
r112520 | tilghman | 2008-04-02 15:34:52 -0400 (Wed, 02 Apr 2008) | 6 lines

Make MISDN generate channel rename events when the name changes.
(closes issue #11142)
 Reported by: julianjm
 Patches: 
       chan_misdn_tmpchan_trunk_v1.diff uploaded by julianjm (license 99)

................
r112564 | tilghman | 2008-04-03 03:49:05 -0400 (Thu, 03 Apr 2008) | 7 lines

Use a 32k file buffer on recordings, which increases the efficiency of file recording.
(closes issue #11962)
 Reported by: garlew
 Patches: 
       recording.patch uploaded by garlew (license 376)
       bug-11962.diff uploaded by snuffy (license 35)

................
r112600 | mmichelson | 2008-04-03 10:35:47 -0400 (Thu, 03 Apr 2008) | 17 lines

Merged revisions 112599 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112599 | mmichelson | 2008-04-03 09:32:20 -0500 (Thu, 03 Apr 2008) | 9 lines

Fix the testing of the "res" variable so that it is more logically correct and 
makes the correct warning and debug messages print.

(closes issue #12361)
Reported by: one47
Patches:
      chan_zap_deferred_digit.patch uploaded by one47 (license 23)


........

................
r112653 | dhubbard | 2008-04-03 18:13:11 -0400 (Thu, 03 Apr 2008) | 1 line

add a Zaptel timer check to verify the timer is responding when Zaptel support is compiled into Asterisk and Zaptel drivers are loaded.  This will help people not waste their valuable time debugging side effects.
................
r112656 | dhubbard | 2008-04-03 18:19:43 -0400 (Thu, 03 Apr 2008) | 1 line

satisfy buildbot
................
r112708 | dhubbard | 2008-04-03 20:32:05 -0400 (Thu, 03 Apr 2008) | 1 line

blocked for trunk....woot
................
r112710 | file | 2008-04-03 20:49:01 -0400 (Thu, 03 Apr 2008) | 9 lines

Blocked revisions 112709 via svnmerge

........
r112709 | file | 2008-04-03 21:48:01 -0300 (Thu, 03 Apr 2008) | 2 lines

One thing at a time... let's get 1.4 building.

........

................
r112712 | file | 2008-04-03 20:53:19 -0400 (Thu, 03 Apr 2008) | 10 lines

Merged revisions 112711 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112711 | file | 2008-04-03 21:52:36 -0300 (Thu, 03 Apr 2008) | 2 lines

Pass in the path to Zaptel for systems that install Zaptel headers in a separate location.

........

................
r112714 | dhubbard | 2008-04-03 20:57:33 -0400 (Thu, 03 Apr 2008) | 1 line

sleep long enough for the zaptel timer error message to display before exit
................
r112785 | phsultan | 2008-04-04 13:32:46 -0400 (Fri, 04 Apr 2008) | 15 lines

Merged revisions 112766 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112766 | phsultan | 2008-04-04 19:16:59 +0200 (Fri, 04 Apr 2008) | 7 lines

Prevent call connections when codecs don't match.

(closes issue #10604)
Reported by: keepitcool
Patches:
      branch-1.4-10604-2.diff uploaded by phsultan (license 73)
Tested by: phsultan
........

................
r112821 | phsultan | 2008-04-04 15:28:49 -0400 (Fri, 04 Apr 2008) | 9 lines

Merged revisions 112820 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112820 | phsultan | 2008-04-04 21:26:15 +0200 (Fri, 04 Apr 2008) | 1 line

Free newly allocated channel before returning
........

................
r112874 | murf | 2008-04-04 21:33:13 -0400 (Fri, 04 Apr 2008) | 15 lines

Found a little problem with the sip request handling that could lead to a quick crash of asterisk, and a road to a DOS attack if left unfixed.

Attaching to a running asterisk with "telnet hostname 5060", I would input "something", then hit return three times, and asterisk crashes.

I traced it to handle_request_do(), which zeroes out the data (an ast_str ptr) if the string is too short. 
Instead of freeing the struct and nulling the pointer, it now just resets it, because this 
ast_str is expected by the calling routine to still be there after handle_request_do() returns.

This appears to fix the crash. I assume that it was introduced with ast_str's being adopted.  It's a subtle and easy-to-miss sort of problem.

I also found all the places where the req.data is freed, and made sure the ptr is Nulled out as well; 
no good leaving bad ptrs laying around-- I didn't need to do this, but it seemed a good thing to do...



................
r112906 | twilson | 2008-04-05 00:59:25 -0400 (Sat, 05 Apr 2008) | 2 lines

Multi-line support for phoneprov

................
r112939 | twilson | 2008-04-05 03:58:42 -0400 (Sat, 05 Apr 2008) | 2 lines

Clean up some memory leak/ref counting issues

................
r112972 | tilghman | 2008-04-05 09:24:12 -0400 (Sat, 05 Apr 2008) | 6 lines

AsyncAGI should not close the manager session on error.
(closes issue #12370)
 Reported by: srt
 Patches: 
       asterisk-12370.diff uploaded by srt (license 378)

................
r113009 | file | 2008-04-07 10:54:42 -0400 (Mon, 07 Apr 2008) | 2 lines

Put my slinfactory changes back in.

................
r113013 | jpeeler | 2008-04-07 11:18:10 -0400 (Mon, 07 Apr 2008) | 15 lines

Merged revisions 113012 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113012 | jpeeler | 2008-04-07 10:16:44 -0500 (Mon, 07 Apr 2008) | 7 lines

(closes issue #12362)
(closes issue #12372)
Reported by: vinsik
Tested by: tecnoxarxa

This one line change makes an if inside a for loop (in realtime_peer) check all the ast_variables the loop was intending to test rather than just the first one.

........

................
r113066 | mmichelson | 2008-04-07 12:12:30 -0400 (Mon, 07 Apr 2008) | 21 lines

Merged revisions 113065 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113065 | mmichelson | 2008-04-07 11:08:45 -0500 (Mon, 07 Apr 2008) | 13 lines

This fix prevents a deadlock that was experienced in chan_local. There was
deadlock prevention in place in chan_local, but it would not work in a specific
case because the channel was recursively locked. By unlocking the channel prior
to calling the generator's generate callback in ast_read_generator_actions(), we
prevent the recursive locking, and therefore the deadlock.

(closes issue #12307)
Reported by: callguy
Patches:
      12307.patch uploaded by putnopvut (license 60)
Tested by: callguy


........

................
r113119 | qwell | 2008-04-07 14:02:51 -0400 (Mon, 07 Apr 2008) | 16 lines

Merged revisions 113118 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113118 | qwell | 2008-04-07 13:00:09 -0500 (Mon, 07 Apr 2008) | 8 lines

Allow playback with noanswer (and add earlyrtp option).

(closes issue #9077)
Reported by: pj
Patches:
      earlyrtp.diff uploaded by wedhorn (license 30)
Tested by: pj, qwell, DEA, wedhorn

........

................
r113170 | twilson | 2008-04-07 14:57:21 -0400 (Mon, 07 Apr 2008) | 2 lines

atoi(NULL) is bad

................
r113172 | tilghman | 2008-04-07 15:06:46 -0400 (Mon, 07 Apr 2008) | 11 lines

Merged revisions 113117 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113117 | tilghman | 2008-04-07 12:51:49 -0500 (Mon, 07 Apr 2008) | 3 lines

Force ast_mktime() to check for DST, since strptime(3) does not.
(Closes issue #12374)

........

................
r113207 | mmichelson | 2008-04-07 16:22:06 -0400 (Mon, 07 Apr 2008) | 7 lines

This is a "fix" for something that's been bugging the crap out of me for a while.
The variable name "flag" to distinguish between whether a message is being forwarded or
is new is not a helpful name. The newly added doxygen documentation to app_voicemail is
tremendously helpful, but I still just...hate this variable name. I think is_new_message
is more indicative of what its purpose is.


................
r113241 | jpeeler | 2008-04-07 17:35:48 -0400 (Mon, 07 Apr 2008) | 23 lines

Merged revisions 113013 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r113013 | jpeeler | 2008-04-07 10:18:10 -0500 (Mon, 07 Apr 2008) | 15 lines

Merged revisions 113012 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113012 | jpeeler | 2008-04-07 10:16:44 -0500 (Mon, 07 Apr 2008) | 7 lines

(closes issue #12362)
(closes issue #12372)
Reported by: vinsik
Tested by: tecnoxarxa

This one line change makes an if inside a for loop (in realtime_peer) check all the ast_variables the loop was intending to test rather than just the first one.

........

................

................
r113243 | qwell | 2008-04-07 17:49:27 -0400 (Mon, 07 Apr 2008) | 1 line

Document 'originate' permission in manager sample config.
................
r113245 | tilghman | 2008-04-07 18:16:46 -0400 (Mon, 07 Apr 2008) | 2 lines

Additional note

................
r113297 | file | 2008-04-08 11:05:35 -0400 (Tue, 08 Apr 2008) | 12 lines

Merged revisions 113296 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113296 | file | 2008-04-08 12:03:43 -0300 (Tue, 08 Apr 2008) | 4 lines

If audio suddenly gets fed into one side of a channel after a lapse of frames flush the other factory so that old audio does not remain in the factory causing the sync code to not execute.
(closes issue #12296)
Reported by: jvandal

........

................
r113349 | tilghman | 2008-04-08 11:48:58 -0400 (Tue, 08 Apr 2008) | 15 lines

Merged revisions 113348 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113348 | tilghman | 2008-04-08 10:39:16 -0500 (Tue, 08 Apr 2008) | 7 lines

Move check for still-bridged channels out a little further, to avoid possible
deadlocks.  (Closes issue #12252)
Reported by: callguy
 Patches: 
       20080319__bug12252.diff.txt uploaded by Corydon76 (license 14)
 Tested by: callguy

........

................
r113400 | tilghman | 2008-04-08 12:54:21 -0400 (Tue, 08 Apr 2008) | 14 lines

Merged revisions 113399 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113399 | tilghman | 2008-04-08 11:51:28 -0500 (Tue, 08 Apr 2008) | 6 lines

Add security note on astgenkey's manpage.
(closes issue #12373)
 Reported by: lmamane
 Patches: 
       20080406__bug12373.diff.txt uploaded by Corydon76 (license 14)

........

................
r113403 | qwell | 2008-04-08 13:00:55 -0400 (Tue, 08 Apr 2008) | 9 lines

Merged revisions 113402 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113402 | qwell | 2008-04-08 11:56:52 -0500 (Tue, 08 Apr 2008) | 1 line

Work around some silliness caused by sys/capability.h - this should fix compile errors a number of users have been experiencing.
........

................
r113452 | qwell | 2008-04-08 13:32:42 -0400 (Tue, 08 Apr 2008) | 9 lines

Move AST_FEATURE_FLAG_* and FEATURE_RETURN_* to features.h so that they can be used by modules.

(closes issue #12384)
Reported by: fnordian
Patches:
      features.patch uploaded by fnordian (license 110)

(patch modified by me, to give FEATURE_RETURN_* an AST_ prefix)

................
r113455 | qwell | 2008-04-08 14:08:35 -0400 (Tue, 08 Apr 2008) | 12 lines

Merged revisions 113454 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113454 | qwell | 2008-04-08 13:07:49 -0500 (Tue, 08 Apr 2008) | 4 lines

Add support for several new(ish) devices - most notably, 7942/7945, 7962/7965, 7975.

Thanks to Greg Oliver for providing me the required information.

........

................
r113505 | qwell | 2008-04-08 14:49:21 -0400 (Tue, 08 Apr 2008) | 9 lines

Merged revisions 113504 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113504 | qwell | 2008-04-08 13:48:55 -0500 (Tue, 08 Apr 2008) | 1 line

Add a little more that is required for previously added devices.
........

................
r113508 | mmichelson | 2008-04-08 15:09:16 -0400 (Tue, 08 Apr 2008) | 15 lines

Blocked revisions 113507 via svnmerge

........
r113507 | mmichelson | 2008-04-08 14:07:38 -0500 (Tue, 08 Apr 2008) | 8 lines

Fix potential buffer overflow that could happen if more than 100 announce files
were specified when calling ParkAndAnnounce. This overflow is not exploitable remotely
and so there is no need for a security advisory.

(closes issue #12386)
Reported by: davidw


........

................
r113559 | tilghman | 2008-04-08 17:33:11 -0400 (Tue, 08 Apr 2008) | 6 lines

Add commandline tool for doing CLI commands through AMI (instead of using asterisk -rx)
(closes issue #12389)
 Reported by: davevg
 Patches: 
       astcli uploaded by davevg (license 209)

................
r113597 | twilson | 2008-04-08 21:36:58 -0400 (Tue, 08 Apr 2008) | 10 lines

Merged revisions 113596 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113596 | twilson | 2008-04-08 20:34:25 -0500 (Tue, 08 Apr 2008) | 2 lines

Initialize fr->cacheable to make valgrind happy

........

................
r113647 | tilghman | 2008-04-09 09:23:44 -0400 (Wed, 09 Apr 2008) | 6 lines

Additional enhancements

[... 9646 lines stripped ...]



More information about the asterisk-commits mailing list