[asterisk-commits] mmichelson: branch group/manager2 r113595 - /team/group/manager2/res/

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Tue Apr  8 19:59:47 2008
New Revision: 113595

URL: http://svn.digium.com/view/asterisk?view=rev&rev=113595
Log:
Add some TODO's. I'm out for the night.


Modified:
    team/group/manager2/res/res_manager2.c

Modified: team/group/manager2/res/res_manager2.c
URL: http://svn.digium.com/view/asterisk/team/group/manager2/res/res_manager2.c?view=diff&rev=113595&r1=113594&r2=113595
==============================================================================
--- team/group/manager2/res/res_manager2.c (original)
+++ team/group/manager2/res/res_manager2.c Tue Apr  8 19:59:47 2008
@@ -216,11 +216,16 @@
 		return NULL;
 	}
 
+	/* TODO: Find a way to get the corresponding subscriber 
+	 * A simple way is to read from ser->f and retrieve a subscriber from
+	 * our list of subscribers based on the input.
+	 */
 	sub->f = ser->f;
 
 	setup_thread(sub);
 
 	/* Just for testing purposes, let's subscribe to queue member device state changes */
+	/* TODO: Change this to use what has been set up in the subscriber's filter */
 	ast_event_subscribe(AST_EVENT_QUEUE_MEMBER_STATUS, info_cb, sub, AST_EVENT_IE_END);
 	ast_pthread_create_background(&sub->thread, NULL, event_spitter, sub);
 	return NULL;
@@ -273,6 +278,7 @@
 	 *
 	 * We use port 666 and wildcard address.
 	 */
+	/* TODO Read this info from the config file instead of hardcoding things here */
 	memset(&event_server.sin, 0, sizeof(event_server.sin));
 	event_server.sin.sin_port = htons(666);
 	event_server.sin.sin_family = AF_INET;
@@ -320,7 +326,7 @@
  * information (just a name right now). We defer filtering setup to
  * the setup_filter() function
  */
-static struct subscriber *sub_init(struct ast_config *cfg, const char *subscriber_name)
+static struct subscriber *subscriber_init(struct ast_config *cfg, const char *subscriber_name)
 {
 	struct subscriber *sub_iter = NULL, *new_subscriber = NULL;
 	int already_exists = 0;
@@ -364,7 +370,7 @@
 
 	while ((cat = ast_category_browse(cfg, cat))) {
 		struct subscriber *sub = NULL;
-		if (!(sub = sub_init(cfg, cat))) {
+		if (!(sub = subscriber_init(cfg, cat))) {
 			/* OH CRAP */
 			continue;
 		}