[asterisk-commits] mmichelson: branch 1.4 r113507 - /branches/1.4/apps/app_parkandannounce.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Tue Apr  8 14:07:38 2008
New Revision: 113507

URL: http://svn.digium.com/view/asterisk?view=rev&rev=113507
Log:
Fix potential buffer overflow that could happen if more than 100 announce files
were specified when calling ParkAndAnnounce. This overflow is not exploitable remotely
and so there is no need for a security advisory.

(closes issue #12386)
Reported by: davidw


Modified:
    branches/1.4/apps/app_parkandannounce.c

Modified: branches/1.4/apps/app_parkandannounce.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_parkandannounce.c?view=diff&rev=113507&r1=113506&r2=113507
==============================================================================
--- branches/1.4/apps/app_parkandannounce.c (original)
+++ branches/1.4/apps/app_parkandannounce.c Tue Apr  8 14:07:38 2008
@@ -211,7 +211,7 @@
 	tpl_working = template;
 	tpl_current=strsep(&tpl_working, ":");
 
-	while(tpl_current && looptemp < sizeof(tmp)) {
+	while(tpl_current && looptemp < ARRAY_LEN(tmp)) {
 		tmp[looptemp]=tpl_current;
 		looptemp++;
 		tpl_current=strsep(&tpl_working,":");