[asterisk-commits] russell: trunk r85516 - in /trunk: ./ pbx/pbx_realtime.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Oct 12 10:41:27 CDT 2007


Author: russell
Date: Fri Oct 12 10:41:27 2007
New Revision: 85516

URL: http://svn.digium.com/view/asterisk?view=rev&rev=85516
Log:
Merged revisions 85515 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r85515 | russell | 2007-10-12 10:40:35 -0500 (Fri, 12 Oct 2007) | 7 lines

Fix the potential use of an uninitialized buffer in a log message.

(closes issue #10958)
Reported by: dimas
Patches: 
      realtime.patch uploaded by dimas (license 88)

........

Modified:
    trunk/   (props changed)
    trunk/pbx/pbx_realtime.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/pbx/pbx_realtime.c
URL: http://svn.digium.com/view/asterisk/trunk/pbx/pbx_realtime.c?view=diff&rev=85516&r1=85515&r2=85516
==============================================================================
--- trunk/pbx/pbx_realtime.c (original)
+++ trunk/pbx/pbx_realtime.c Fri Oct 12 10:41:27 2007
@@ -178,12 +178,12 @@
 
 	if (var) {
 		char *tmp="";
-		char app[256];
+		char *app = NULL;
 		struct ast_variable *v;
 
 		for (v = var; v ; v = v->next) {
 			if (!strcasecmp(v->name, "app"))
-				ast_copy_string(app, v->value, sizeof(app));
+				app = ast_strdupa(v->value);
 			else if (!strcasecmp(v->name, "appdata"))
 				tmp = ast_strdupa(v->value);
 		}
@@ -215,6 +215,8 @@
 				res = pbx_exec(chan, a, appdata);
 			} else
 				ast_log(LOG_NOTICE, "No such application '%s' for extension '%s' in context '%s'\n", app, exten, context);
+		} else {
+			ast_log(LOG_WARNING, "No application specified for realtime extension '%s' in context '%s'\n", exten, context);
 		}
 	}
 	return res;




More information about the asterisk-commits mailing list