[asterisk-commits] rizzo: trunk r89543 - /trunk/channels/chan_h323.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Sat Nov 24 07:57:46 CST 2007


Author: rizzo
Date: Sat Nov 24 07:57:46 2007
New Revision: 89543

URL: http://svn.digium.com/view/asterisk?view=rev&rev=89543
Log:
remove a DEBUG_THREADS message that accesses private lock fields.
If needed, the code to extract this information should be implemented
in some generic header or library and the function called here.

(closed bug #11362)


Modified:
    trunk/channels/chan_h323.c

Modified: trunk/channels/chan_h323.c
URL: http://svn.digium.com/view/asterisk/trunk/channels/chan_h323.c?view=diff&rev=89543&r1=89542&r2=89543
==============================================================================
--- trunk/channels/chan_h323.c (original)
+++ trunk/channels/chan_h323.c Sat Nov 24 07:57:46 2007
@@ -2357,10 +2357,13 @@
 		if (!pvt->owner || !ast_channel_trylock(pvt->owner))
 			break;
 #if 1
+		ast_log(LOG_NOTICE, "Avoiding H.323 destory deadlock on %s\n", call_token);
 #ifdef DEBUG_THREADS
-		ast_log(LOG_NOTICE, "Avoiding H.323 destory deadlock on %s, locked at %ld/%d by %s (%s:%d)\n", call_token, pvt->owner->lock.thread[0], pvt->owner->lock.reentrancy, pvt->owner->lock.func[0], pvt->owner->lock.file[0], pvt->owner->lock.lineno[0]);
-#else
-		ast_log(LOG_NOTICE, "Avoiding H.323 destory deadlock on %s\n", call_token);
+		/* XXX to be completed
+		 * If we want to print more info on who is holding the lock,
+		 * implement the relevant code in lock.h and use the routines
+		 * supplied there.
+		 */
 #endif
 #endif
 		ast_mutex_unlock(&pvt->lock);




More information about the asterisk-commits mailing list