[asterisk-commits] russell: branch 1.4 r63886 - /branches/1.4/main/manager.c

[asterisk-commits at lists.digium.com]

Author: russell
Date: Fri May 11 11:05:43 2007
New Revision: 63886

URL: http://svn.digium.com/view/asterisk?view=rev&rev=63886
Log:
When MD5 authentication is not possible because there is no challenge present,
either because the Challenge action was never issued, or some other reason,
give a proper error message and return an error instead of claiming that the
user wasn't found.
(reported by jsmith on IRC)

Modified:
    branches/1.4/main/manager.c

Modified: branches/1.4/main/manager.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/manager.c?view=diff&rev=63886&r1=63885&r2=63886
==============================================================================
--- branches/1.4/main/manager.c (original)
+++ branches/1.4/main/manager.c Fri May 11 11:05:43 2007
@@ -946,6 +946,11 @@
 							ast_config_destroy(cfg);
 							return -1;
 						}
+					} else {
+						ast_log(LOG_DEBUG, "MD5 authentication is not possible.  challenge: '%s'\n", 
+							S_OR(s->challenge, ""));
+						ast_config_destroy(cfg);
+						return -1;
 					}
 				} else if (password && !strcmp(password, pass)) {
 					break;