[asterisk-commits] file: branch 1.2 r57869 - /branches/1.2/apps/app_voicemail.c

[asterisk-commits at lists.digium.com]

Author: file
Date: Mon Mar  5 11:49:18 2007
New Revision: 57869

URL: http://svn.digium.com/view/asterisk?view=rev&rev=57869
Log:
Make create_dirpath use our standard for return values. -1 is failure, 0 is success. (issue #9205 reported by ballares)

Modified:
    branches/1.2/apps/app_voicemail.c

Modified: branches/1.2/apps/app_voicemail.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/apps/app_voicemail.c?view=diff&rev=57869&r1=57868&r2=57869
==============================================================================
--- branches/1.2/apps/app_voicemail.c (original)
+++ branches/1.2/apps/app_voicemail.c Mon Mar  5 11:49:18 2007
@@ -785,7 +785,7 @@
  * @context String. Ignored if is null or empty string.
  * @ext     String. Ignored if is null or empty string.
  * @mailbox String. Ignored if is null or empty string. 
- * @returns 0 on failure, 1 on success.
+ * @returns -1 on failure, 0 on success.
  * */
 static int create_dirpath(char *dest, int len, char *context, char *ext, char *mailbox)
 {
@@ -795,24 +795,24 @@
 		make_dir(dest, len, context, "", "");
 		if(mkdir(dest, mode) && errno != EEXIST) {
 			ast_log(LOG_WARNING, "mkdir '%s' failed: %s\n", dest, strerror(errno));
-			return 0;
+			return -1;
 		}
 	}
 	if(ext && ext[0] != '\0') {
 		make_dir(dest, len, context, ext, "");
 		if(mkdir(dest, mode) && errno != EEXIST) {
 			ast_log(LOG_WARNING, "mkdir '%s' failed: %s\n", dest, strerror(errno));
-			return 0;
+			return -1;
 		}
 	}
 	if(mailbox && mailbox[0] != '\0') {
 		make_dir(dest, len, context, ext, mailbox);
 		if(mkdir(dest, mode) && errno != EEXIST) {
 			ast_log(LOG_WARNING, "mkdir '%s' failed: %s\n", dest, strerror(errno));
-			return 0;
-		}
-	}
-	return 1;
+			return -1;
+		}
+	}
+	return 0;
 }
 
 /* only return failure if ast_lock_path returns 'timeout',
@@ -1970,7 +1970,7 @@
 
 	snprintf(fn, sizeof(fn), "%s%s/%s/greet", VM_SPOOL_DIR, context, ext);
 
-	if (!(res = create_dirpath(dest, sizeof(dest), context, ext, "greet"))) {
+	if ((res = create_dirpath(dest, sizeof(dest), context, ext, "greet"))) {
 		ast_log(LOG_WARNING, "Failed to make directory(%s)\n", fn);
 		return -1;
 	}
@@ -2477,7 +2477,7 @@
 		snprintf(prefile, sizeof(prefile), "%s%s/%s/unavail", VM_SPOOL_DIR, vmu->context, ext);
 	}
 	snprintf(tempfile, sizeof(tempfile), "%s%s/%s/temp", VM_SPOOL_DIR, vmu->context, ext);
-	if (!(res = create_dirpath(dest, sizeof(dest), vmu->context, ext, "temp"))) {
+	if ((res = create_dirpath(dest, sizeof(dest), vmu->context, ext, "temp"))) {
 		ast_log(LOG_WARNING, "Failed to make directory (%s)\n", tempfile);
 		return -1;
 	}
@@ -4864,7 +4864,7 @@
 		adsi_transmit_message(chan, buf, bytes, ADSI_MSG_DISPLAY);
 	}
 	snprintf(prefile,sizeof(prefile), "%s%s/%s/temp", VM_SPOOL_DIR, vmu->context, vms->username);
-	if (!(res = create_dirpath(dest, sizeof(dest), vmu->context, vms->username, "temp"))) {
+	if ((res = create_dirpath(dest, sizeof(dest), vmu->context, vms->username, "temp"))) {
 		ast_log(LOG_WARNING, "Failed to create directory (%s).\n", prefile);
 		return -1;
 	}