[asterisk-commits] russell: branch 1.4 r67558 - /branches/1.4/apps/app_meetme.c

[asterisk-commits at lists.digium.com]

Author: russell
Date: Tue Jun  5 18:01:44 2007
New Revision: 67558

URL: http://svn.digium.com/view/asterisk?view=rev&rev=67558
Log:
Fix some crashes related to the use of the "meetme" CLI command.  The code for
this command was not locking the conference list at all.
(issue #9351, reported by and patch submitted by Junk-Y, committed patch
 is different and by me)

Modified:
    branches/1.4/apps/app_meetme.c

Modified: branches/1.4/apps/app_meetme.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_meetme.c?view=diff&rev=67558&r1=67557&r2=67558
==============================================================================
--- branches/1.4/apps/app_meetme.c (original)
+++ branches/1.4/apps/app_meetme.c Tue Jun  5 18:01:44 2007
@@ -825,8 +825,10 @@
 	if (argc == 1) {
 		/* 'MeetMe': List all the conferences */	
 		now = time(NULL);
+		AST_LIST_LOCK(&confs);
 		if (AST_LIST_EMPTY(&confs)) {
 			ast_cli(fd, "No active MeetMe conferences.\n");
+			AST_LIST_UNLOCK(&confs);
 			return RESULT_SUCCESS;
 		}
 		ast_cli(fd, header_format, "Conf Num", "Parties", "Marked", "Activity", "Creation");
@@ -843,6 +845,7 @@
 
 			total += cnf->users; 	
 		}
+		AST_LIST_UNLOCK(&confs);
 		ast_cli(fd, "* Total number of MeetMe users: %d\n", total);
 		return RESULT_SUCCESS;
 	}
@@ -897,6 +900,7 @@
 			return RESULT_SUCCESS;	
 		}
 		/* Find the right conference */
+		AST_LIST_LOCK(&confs);
 		AST_LIST_TRAVERSE(&confs, cnf, list) {
 			if (strcmp(cnf->confno, argv[2]) == 0)
 				break;
@@ -904,11 +908,12 @@
 		if (!cnf) {
 			if ( !concise )
 				ast_cli(fd, "No such conference: %s.\n",argv[2]);
+			AST_LIST_UNLOCK(&confs);
 			return RESULT_SUCCESS;
 		}
 		/* Show all the users */
+		time(&now);
 		AST_LIST_TRAVERSE(&cnf->userlist, user, list) {
-			now = time(NULL);
 			hr = (now - user->jointime) / 3600;
 			min = ((now - user->jointime) % 3600) / 60;
 			sec = (now - user->jointime) % 60;
@@ -936,7 +941,7 @@
 		}
 		if ( !concise )
 			ast_cli(fd,"%d users in that conference.\n",cnf->users);
-
+		AST_LIST_UNLOCK(&confs);
 		return RESULT_SUCCESS;
 	} else 
 		return RESULT_SHOWUSAGE;