[asterisk-commits] file: branch 1.4 r67064 - /branches/1.4/res/res_features.c

[asterisk-commits at lists.digium.com]

Author: file
Date: Mon Jun  4 12:41:59 2007
New Revision: 67064

URL: http://svn.digium.com/view/asterisk?view=rev&rev=67064
Log:
Returning a value that indicates the parking of a call was a success when it really wasn't (because the parking slot selected was in use) is the wrong thing to do. (issue #9723 reported by mdu113)

Modified:
    branches/1.4/res/res_features.c

Modified: branches/1.4/res/res_features.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/res/res_features.c?view=diff&rev=67064&r1=67063&r2=67064
==============================================================================
--- branches/1.4/res/res_features.c (original)
+++ branches/1.4/res/res_features.c Mon Jun  4 12:41:59 2007
@@ -328,7 +328,7 @@
 			ast_mutex_unlock(&parking_lock);
 			free(pu);
 			ast_log(LOG_WARNING, "Requested parking extension already exists: %s@%s\n", parkingexten, parking_con);
-			return 0;	/* Continue execution if possible */
+			return -1; /* We failed to park this call, plain and simple so we need to error out */
 		}
 		ast_copy_string(pu->parkingexten, parkingexten, sizeof(pu->parkingexten));
 		x = atoi(parkingexten);