[asterisk-commits] rizzo: trunk r76313 - /trunk/channels/chan_sip.c

[SVN commits to the Asterisk project]

Author: rizzo
Date: Sat Jul 21 12:32:00 2007
New Revision: 76313

URL: http://svn.digium.com/view/asterisk?view=rev&rev=76313
Log:
Add a note to document how the temporary 'pvt' should be initialized
before using it.
I am unclear on the details right now so i hope someone can comment
more. The obvious (and lazy) approach would be to bzero() all of it
(except for the string pool), but isn't that too much work ?
Feedback wanted here...


Modified:
    trunk/channels/chan_sip.c

Modified: trunk/channels/chan_sip.c
URL: http://svn.digium.com/view/asterisk/trunk/channels/chan_sip.c?view=diff&rev=76313&r1=76312&r2=76313
==============================================================================
--- trunk/channels/chan_sip.c (original)
+++ trunk/channels/chan_sip.c Sat Jul 21 12:32:00 2007
@@ -6353,6 +6353,13 @@
 		return -1;
 	}
 
+	/* XXX the structure may be dirty from previous usage.
+	 * Here we should state clearly how we should reinitialize it
+	 * before using it.
+	 * E.g. certainly the threadstorage should be left alone,
+	 * but other thihngs such as flags etc. maybe need cleanup ?
+	 */
+	 
 	/* Initialize the bare minimum */
 	p->method = intended_method;