[asterisk-commits] russell: branch 1.2 r75449 - /branches/1.2/channels/chan_skinny.c

[SVN commits to the Asterisk project]

Author: russell
Date: Tue Jul 17 15:57:09 2007
New Revision: 75449

URL: http://svn.digium.com/view/asterisk?view=rev&rev=75449
Log:
Properly check for the length in the skinny packet to prevent an invalid memcpy.
(ASA-2007-016)

Modified:
    branches/1.2/channels/chan_skinny.c

Modified: branches/1.2/channels/chan_skinny.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/channels/chan_skinny.c?view=diff&rev=75449&r1=75448&r2=75449
==============================================================================
--- branches/1.2/channels/chan_skinny.c (original)
+++ branches/1.2/channels/chan_skinny.c Tue Jul 17 15:57:09 2007
@@ -2862,7 +2862,7 @@
 			return -1;
 		}
 		dlen = letohl(*(int *)s->inbuf);
-		if (dlen < 0) {
+		if (dlen < 4) {
 			ast_log(LOG_WARNING, "Skinny Client sent invalid data.\n");
 			return -1;
 		}