[asterisk-commits] russell: trunk r72930 - /trunk/res/res_agi.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Mon Jul 2 14:01:17 CDT 2007


Author: russell
Date: Mon Jul  2 14:01:16 2007
New Revision: 72930

URL: http://svn.digium.com/view/asterisk?view=rev&rev=72930
Log:
Add a note that the AGI commands array is not handled in a thread-safe way

Modified:
    trunk/res/res_agi.c

Modified: trunk/res/res_agi.c
URL: http://svn.digium.com/view/asterisk/trunk/res/res_agi.c?view=diff&rev=72930&r1=72929&r2=72930
==============================================================================
--- trunk/res/res_agi.c (original)
+++ trunk/res/res_agi.c Mon Jul  2 14:01:16 2007
@@ -1603,6 +1603,13 @@
 " Usage: NoOp\n"
 "	Does nothing.\n";
 
+/*!
+ * \brief AGI commands
+ *
+ * \todo XXX This array is not handled in a thread safe way.  There is no
+ * synchronization done at all between the agi register and unregister functions
+ * and the rest of this module which uses the entries here.
+ */
 static agi_command commands[MAX_COMMANDS] = {
 	{ { "answer", NULL }, handle_answer, "Answer channel", usage_answer },
 	{ { "channel", "status", NULL }, handle_channelstatus, "Returns status of the connected channel", usage_channelstatus },




More information about the asterisk-commits mailing list