[asterisk-commits] russell: branch 1.4 r52645 - /branches/1.4/main/rtp.c

[asterisk-commits at lists.digium.com]

Author: russell
Date: Mon Jan 29 15:26:27 2007
New Revision: 52645

URL: http://svn.digium.com/view/asterisk?view=rev&rev=52645
Log:
Fix a problem with packet-to-packet bridging and DTMF mode translation.  P2P
bridging can only be used when the DTMF modes don't match if the core is
monitoring DTMF in both directions.  Then, the core will handle the translation.
Otherwise, this bridging method can not be used.
(issue #8936)

Modified:
    branches/1.4/main/rtp.c

Modified: branches/1.4/main/rtp.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/rtp.c?view=diff&rev=52645&r1=52644&r2=52645
==============================================================================
--- branches/1.4/main/rtp.c (original)
+++ branches/1.4/main/rtp.c Mon Jan 29 15:26:27 2007
@@ -3187,11 +3187,19 @@
 	 * |-----------|------------|-----------------------|
 	 * | Inband    | False      | True                  |
 	 * | RFC2833   | True       | True                  |
-	 * | SIP Info  | False      | False                 |
+	 * | SIP INFO  | False      | False                 |
 	 * --------------------------------------------------
+	 * However, if DTMF from both channels is being monitored by the core, then
+	 * we can still do packet-to-packet bridging, because passing through the 
+	 * core will handle DTMF mode translation.
 	 */
 	if ( (ast_test_flag(p0, FLAG_HAS_DTMF) != ast_test_flag(p1, FLAG_HAS_DTMF)) ||
 		 (!c0->tech->send_digit_begin != !c1->tech->send_digit_begin)) {
+		if (!ast_test_flag(p0, FLAG_P2P_NEED_DTMF) || !ast_test_flag(p1, FLAG_P2P_NEED_DTMF)) {
+			ast_channel_unlock(c0);
+			ast_channel_unlock(c1);
+			return AST_BRIDGE_FAILED_NOWARN;
+		}
 		audio_p0_res = AST_RTP_TRY_PARTIAL;
 		audio_p1_res = AST_RTP_TRY_PARTIAL;
 	}