[asterisk-commits] bweschke: branch 1.4 r53129 - in /branches/1.4: UPGRADE.txt apps/app_queue.c

[asterisk-commits at lists.digium.com]

Author: bweschke
Date: Fri Feb  2 15:26:45 2007
New Revision: 53129

URL: http://svn.digium.com/view/asterisk?view=rev&rev=53129
Log:
 I'm baaaaaaaaaack. :)

 Post a warning to the console that things might possibly be misconfigured when queue member's states are still 'Not in Use' when we're about to bridge them with a caller from queue. Also, put some documentation quoted from oej's queues.txt efforts started in /trunk today. 
 This commit puts #7433 into feedback state for 1.4, and pending no further negative feedback, it will finally be closed.


Modified:
    branches/1.4/UPGRADE.txt
    branches/1.4/apps/app_queue.c

Modified: branches/1.4/UPGRADE.txt
URL: http://svn.digium.com/view/asterisk/branches/1.4/UPGRADE.txt?view=diff&rev=53129&r1=53128&r2=53129
==============================================================================
--- branches/1.4/UPGRADE.txt (original)
+++ branches/1.4/UPGRADE.txt Fri Feb  2 15:26:45 2007
@@ -163,6 +163,23 @@
   option, it will default to "no" to keep backward compatability with the old 
   behavior.
 
+* Queues depend on the channel driver reporting the proper state
+  for each member of the queue. To get proper signalling on
+  queue members that use the SIP channel driver, you need to
+  enable a call limit (could be set to a high value so it
+  is not put into action) and also make sure that both inbound
+  and outbound calls are accounted for.
+
+  Example:
+
+       [general]
+       limitonpeer = yes
+
+       [peername]
+       type=friend
+       call-limit=10
+
+
 * The app_queue application now has the ability to use MixMonitor to 
   record conversations queue members are having with queue callers. Please
   see configs/queues.conf.sample for more information on this option.

Modified: branches/1.4/apps/app_queue.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_queue.c?view=diff&rev=53129&r1=53128&r2=53129
==============================================================================
--- branches/1.4/apps/app_queue.c (original)
+++ branches/1.4/apps/app_queue.c Fri Feb  2 15:26:45 2007
@@ -2637,6 +2637,10 @@
 		ast_copy_string(oldexten, qe->chan->exten, sizeof(oldexten));
 		time(&callstart);
 
+		if (member->status == AST_DEVICE_NOT_INUSE)
+			ast_log(LOG_WARNING, "The device state of this queue member, %s, is still 'Not in Use' when it probably should not be! Please check UPGRADE.txt for correct configuration settings.\n", member->membername);
+			
+
 		bridge = ast_bridge_call(qe->chan,peer, &bridge_config);
 
 		if (strcasecmp(oldcontext, qe->chan->context) || strcasecmp(oldexten, qe->chan->exten)) {