[asterisk-commits] mmichelson: trunk r93042 - in /trunk: funcs/ include/asterisk/ main/

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Fri Dec 14 12:47:44 2007
New Revision: 93042

URL: http://svn.digium.com/view/asterisk?view=rev&rev=93042
Log:
After reading Russell's e-mail to the dev list stating that checking option_verbose is not
equivalent to the check done by ast_verb, I wrote a macro, VERBOSITY_LEVEL, which does this
check. I did a quick look in the source and used this macro in some places where option_verbose
was used.

I also converted some verbose messages in logger.c to use ast_verb instead of ast_verbose.


Modified:
    trunk/funcs/func_timeout.c
    trunk/include/asterisk/logger.h
    trunk/main/logger.c
    trunk/main/manager.c
    trunk/main/pbx.c

Modified: trunk/funcs/func_timeout.c
URL: http://svn.digium.com/view/asterisk/trunk/funcs/func_timeout.c?view=diff&rev=93042&r1=93041&r2=93042
==============================================================================
--- trunk/funcs/func_timeout.c (original)
+++ trunk/funcs/func_timeout.c Fri Dec 14 12:47:44 2007
@@ -106,7 +106,7 @@
 	case 'a':
 	case 'A':
 		ast_channel_setwhentohangup(chan, x);
-		if(option_verbose > 2) {
+		if (VERBOSITY_LEVEL(2)) {
 			if (chan->whentohangup) {
 				struct timeval tv = { chan->whentohangup, 0 };
 				ast_strftime(timestr, sizeof(timestr), "%Y-%m-%d %H:%M:%S.%3q %Z",

Modified: trunk/include/asterisk/logger.h
URL: http://svn.digium.com/view/asterisk/trunk/include/asterisk/logger.h?view=diff&rev=93042&r1=93041&r2=93042
==============================================================================
--- trunk/include/asterisk/logger.h (original)
+++ trunk/include/asterisk/logger.h Fri Dec 14 12:47:44 2007
@@ -154,8 +154,10 @@
 		ast_log(LOG_DEBUG, __VA_ARGS__); \
 } while (0)
 
+#define VERBOSITY_LEVEL(level) (option_verbose >= (level) || (ast_opt_verb_file && ast_verbose_get_by_file(__FILE__) >= (level)))
+
 #define ast_verb(level, ...) do { \
-	if (option_verbose >= (level) || (ast_opt_verb_file && ast_verbose_get_by_file(__FILE__) >= (level)) ) { \
+	if (VERBOSITY_LEVEL((level)) ) { \
 		if (level >= 4) \
 			ast_verbose(VERBOSE_PREFIX_4 __VA_ARGS__); \
 		else if (level == 3) \

Modified: trunk/main/logger.c
URL: http://svn.digium.com/view/asterisk/trunk/main/logger.c?view=diff&rev=93042&r1=93041&r2=93042
==============================================================================
--- trunk/main/logger.c (original)
+++ trunk/main/logger.c Fri Dec 14 12:47:44 2007
@@ -586,8 +586,7 @@
 		eventlog = fopen(old, "a");
 		if (eventlog) {
 			ast_log(LOG_EVENT, "Restarted Asterisk Event Logger\n");
-			if (option_verbose)
-				ast_verbose("Asterisk Event Logger restarted\n");
+			ast_verb(1, "Asterisk Event Logger restarted\n");
 		} else {
 			ast_log(LOG_ERROR, "Unable to create event log: %s\n", strerror(errno));
 			res = -1;
@@ -605,8 +604,7 @@
 			ast_queue_log("NONE", "NONE", "NONE", "CONFIGRELOAD", "%s", "");
 			AST_RWLIST_WRLOCK(&logchannels);
 			ast_log(LOG_EVENT, "Restarted Asterisk Queue Logger\n");
-			if (option_verbose)
-				ast_verbose("Asterisk Queue Logger restarted\n");
+			ast_verb(1, "Asterisk Queue Logger restarted\n");
 		} else {
 			ast_log(LOG_ERROR, "Unable to create queue log: %s\n", strerror(errno));
 			res = -1;

Modified: trunk/main/manager.c
URL: http://svn.digium.com/view/asterisk/trunk/main/manager.c?view=diff&rev=93042&r1=93041&r2=93042
==============================================================================
--- trunk/main/manager.c (original)
+++ trunk/main/manager.c Fri Dec 14 12:47:44 2007
@@ -2677,7 +2677,7 @@
 		if (s->sessiontimeout && (now > s->sessiontimeout) && !s->inuse) {
 			AST_LIST_REMOVE_CURRENT(list);
 			ast_atomic_fetchadd_int(&num_sessions, -1);
-			if (s->authenticated && (option_verbose > 1) && manager_displayconnects(s)) {
+			if (s->authenticated && (VERBOSITY_LEVEL(1)) && manager_displayconnects(s)) {
 				ast_verb(2, "HTTP Manager '%s' timed out from %s\n",
 					s->username, ast_inet_ntoa(s->sin.sin_addr));
 			}

Modified: trunk/main/pbx.c
URL: http://svn.digium.com/view/asterisk/trunk/main/pbx.c?view=diff&rev=93042&r1=93041&r2=93042
==============================================================================
--- trunk/main/pbx.c (original)
+++ trunk/main/pbx.c Fri Dec 14 12:47:44 2007
@@ -2649,7 +2649,7 @@
 			c->priority = priority;
 			pbx_substitute_variables(passdata, sizeof(passdata), c, e);
 			ast_debug(1, "Launching '%s'\n", app->name);
-			if (option_verbose > 2) {
+			if (VERBOSITY_LEVEL(2)) {
 				char tmp[80], tmp2[80], tmp3[EXT_DATA_SIZE];
 				ast_verb(3, "Executing [%s@%s:%d] %s(\"%s\", \"%s\") %s\n",
 					exten, context, priority,