[asterisk-commits] tilghman: branch group/ast_storage r78858 - in /team/group/ast_storage: ./ ap...

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Thu Aug 9 16:39:38 CDT 2007


Author: tilghman
Date: Thu Aug  9 16:39:33 2007
New Revision: 78858

URL: http://svn.digium.com/view/asterisk?view=rev&rev=78858
Log:
Merged revisions 74769,74813,74816,74843,74850,74865,74867,74891,74923,74956,74999,75034,75054,75075,75077,75082,75109,75163-75164,75183,75200,75227,75254-75255,75259-75260,75307,75351,75365,75379,75381,75400,75402,75404,75406,75438,75442-75443,75446,75448,75451,75505,75530,75566,75584-75586,75620,75622,75624,75659,75706,75709-75710,75713-75714,75734,75750,75761,75805-75806,75808,75841,75857,75873-75875,75878,75894,75911,75929-75930,75977,75979,75981-75983,76015,76034-76035,76037,76055-76056,76070,76091,76138,76140,76175,76177,76179,76213,76216,76220-76222,76224,76228-76229,76231,76278-76279,76296,76313-76314,76330,76348-76349,76365-76366,76371,76390,76392,76408,76458,76467,76486,76520-76521,76523-76524,76547,76555,76558-76559,76562-76564,76619,76621,76655,76657,76703-76704,76706-76707,76709-76712,76755,76770,76785,76791,76804,76807,76841,76852,76874,76892,76925,76940,76984-76985,77023,77054,77072,77155-77156,77182,77217-77218,77233,77248,77266-77269,77284,77299,77319,77349,7
 7351,77381,77411,77432,77461,77491,77520,77534,77537-77538,77541,77572,77602-77603,77616,77630-77631,77647-77648,77650,77653-77654,77668-77669,77682,77684,77697,77711-77712,77725-77726,77739,77753,77766,77769-77770,77772-77773,77779,77781,77784,77786-77787,77789-77793,77796-77797,77799-77801,77808,77810,77819-77821,77825,77828-77829,77833-77834,77838,77847,77851,77853,77855,77857-77858,77864,77866,77868,77870,77872,77875-77876,77878-77879,77884,77888-77889,77891,77895,77940-77941,77944,77946,77948,77950,77994,77997,78029,78064,78096,78102,78138,78140,78142,78144,78147,78167-78168,78173,78179,78181,78183,78185-78186,78192,78227,78243,78276,78278-78279,78312,78338,78342,78346-78347,78372,78378,78417-78418,78442,78451,78489,78521,78541,78570,78590,78635,78637,78648-78649,78679,78683,78685-78686,78718,78747,78750 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r74769 | russell | 2007-07-11 18:05:34 -0500 (Wed, 11 Jul 2007) | 21 lines

Merged revisions 74767 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r74767 | russell | 2007-07-11 17:57:07 -0500 (Wed, 11 Jul 2007) | 13 lines

Merged revisions 74766 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74766 | russell | 2007-07-11 17:53:26 -0500 (Wed, 11 Jul 2007) | 5 lines

The function make_trunk() can fail and return -1 instead of a valid new call
number.  Fix the uses of this function to handle this instead of treating it
as the new call number.  This would cause a deadlock and memory corruption.
(possible cause of issue #9614 and others, patch by me)

........

................

................
r74813 | rizzo | 2007-07-12 10:42:56 -0500 (Thu, 12 Jul 2007) | 15 lines

a little bit of code cleanup to rtp.c, mostly to function 
ast_rtp_new_with_bindaddr(): 

1. add comments to the logic of the main loop;
2. use a common exit point on failure so the cleanup is done only in one place;
3. handle failures in rtp_socket() in the main loop of the function;

No functional changes except for #3 above, so it is not yet
worthwhile merging this and other changes to 1.4

Once the cleanup work on this file will be complete (which among
other things should include some extensions to the stun support)
it might be a good thing to push all the changes to 1.4


................
r74816 | file | 2007-07-12 10:55:49 -0500 (Thu, 12 Jul 2007) | 18 lines

Merged revisions 74815 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r74815 | file | 2007-07-12 12:53:55 -0300 (Thu, 12 Jul 2007) | 10 lines

Merged revisions 74814 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74814 | file | 2007-07-12 12:51:24 -0300 (Thu, 12 Jul 2007) | 2 lines

Only print out a warning for situations where it is actually helpful. (issue #10187 reported by denke)

........

................

................
r74843 | qwell | 2007-07-12 11:18:06 -0500 (Thu, 12 Jul 2007) | 11 lines

Blocked revisions 74839 via svnmerge

........
r74839 | qwell | 2007-07-12 11:16:59 -0500 (Thu, 12 Jul 2007) | 4 lines

Fix dialing in skinny that was broken in some cases.

Issue 10136, fix provided by DEA.

........

................
r74850 | rizzo | 2007-07-12 11:21:12 -0500 (Thu, 12 Jul 2007) | 7 lines

more cleanup, this time to stun_handle_packet(). Among other things:
+ mark a potentially dangerous write-past-end-of-buffer
+ localize some variables in the block generating stun replies.

As before, not ready yet for a merge to 1.4


................
r74865 | qwell | 2007-07-12 11:49:17 -0500 (Thu, 12 Jul 2007) | 9 lines

Merged revisions 74864 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r74864 | qwell | 2007-07-12 11:48:49 -0500 (Thu, 12 Jul 2007) | 1 line

Add device ID for 7921 wireless skinny phone
........

................
r74867 | qwell | 2007-07-12 11:54:02 -0500 (Thu, 12 Jul 2007) | 9 lines

Merged revisions 74866 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r74866 | qwell | 2007-07-12 11:53:35 -0500 (Thu, 12 Jul 2007) | 1 line

It helps if I actually add this stuff for the 7921 too - otherwise it won't actually do much of anything.
........

................
r74891 | file | 2007-07-12 12:17:56 -0500 (Thu, 12 Jul 2007) | 10 lines

Merged revisions 74888 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r74888 | file | 2007-07-12 14:16:28 -0300 (Thu, 12 Jul 2007) | 2 lines

When waiting for a digit ensure that a begin frame was received with it, not just an end frame. (issue #10084 reported by rushowr)

........

................
r74923 | file | 2007-07-12 14:19:03 -0500 (Thu, 12 Jul 2007) | 10 lines

Merged revisions 74922 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r74922 | file | 2007-07-12 16:17:59 -0300 (Thu, 12 Jul 2007) | 2 lines

Whoops... didn't want this to be returned to 0 each iteration.

........

................
r74956 | murf | 2007-07-12 15:46:32 -0500 (Thu, 12 Jul 2007) | 9 lines

Merged revisions 74955 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r74955 | murf | 2007-07-12 14:42:08 -0600 (Thu, 12 Jul 2007) | 1 line

This patch resolves 10143; thanks to irroot for the patch; looked acceptable. Let the community decide if it messes things up
........

................
r74999 | mmichelson | 2007-07-12 18:02:33 -0500 (Thu, 12 Jul 2007) | 6 lines

Merged revisions 74997 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
........

................
r75034 | rizzo | 2007-07-13 11:22:09 -0500 (Fri, 13 Jul 2007) | 44 lines

Small improvement to the STUN support so it can be used by
sockets other than RTP ones.

The main change is a new API function in main/rtp.c (see there
for a description)

    int ast_stun_request(int s, struct sockaddr_in *dst,
        const char *username, struct sockaddr_in *answer)

which can be used to send an STUN request on a socket, and
optionally wait for a reply and store the STUN_MAPPED_ADDRESS
into the 'answer' argument (obviously, the version that
waits for a reply is blocking, but this is no different
from DNS resolutions).

Internally there are minor modifications to let stun_handle_packet()
be somewhat configurable on how to parse the body of responses.

At the moment i am not committing any change to the clients,
but adding STUN client support is extremely simple, e.g. chan_sip.c
could do something like this:

    + add a variable to store the stun server address;

	static struct sockaddr_in stunaddr = { 0, };   /*!< stun server address */

    + add code to parse a config file of the form "stunaddr=my.stun.server.org:3478"
      (not shown for brevity);

    + right after binding the main sip socket, talk to the stun server to
      determine the externally visible address

	    if (stunaddr.sin_addr.s_addr != 0)
		ast_stun_request(sipsock, &stunaddr, NULL, &externip);

      so now 'externip' is set with the externally visible address.

so it is really trivial.

Similarly ast_stun_request could be called when creating the RTP
socket (possibly adding a struct sockaddr_in field in the struct
ast_rtp to store the externalip).


................
r75054 | russell | 2007-07-13 14:19:51 -0500 (Fri, 13 Jul 2007) | 28 lines

Merged revisions 75053 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75053 | russell | 2007-07-13 14:11:26 -0500 (Fri, 13 Jul 2007) | 20 lines

Merged revisions 75052 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75052 | russell | 2007-07-13 14:10:00 -0500 (Fri, 13 Jul 2007) | 12 lines

(closes issue #9660)
Reported by: mmacvicar
Patches submitted by: bbryant, russell
Tested by: mmacvicar, marco, arcivanov, jmhunter, explidous

When using a TDM400P (and probably other analog cards) there was a chance that
you could hang up and pick the phone back up where it has been long enough to
be not considered a flash hook, but too soon such that the device reports that
it is busy and the person on the phone will only hear silence.  This patch
makes chan_zap more tolerant of this and gives the device a couple of seconds 
to succeed so the person on the phone happily gets their dialtone.

........

................

................
r75075 | russell | 2007-07-13 15:14:23 -0500 (Fri, 13 Jul 2007) | 22 lines

Merged revisions 75067 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75067 | russell | 2007-07-13 15:10:40 -0500 (Fri, 13 Jul 2007) | 14 lines

Merged revisions 75059 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75059 | russell | 2007-07-13 15:07:21 -0500 (Fri, 13 Jul 2007) | 6 lines

Ensure that adding a user to the list of users of a specific music on hold
class is not done at the same time as any of the other operations on this list
to prevent list corruption.  Using the global moh_data lock for this is not
ideal, but it is what is used to protect these lists everywhere else in the
module, and I am only changing what is necessary to fix the bug.

........

................

................
r75077 | russell | 2007-07-13 15:15:16 -0500 (Fri, 13 Jul 2007) | 1 line

resolve a compiler warning
................
r75082 | mmichelson | 2007-07-13 15:16:40 -0500 (Fri, 13 Jul 2007) | 21 lines

Merged revisions 75078 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75078 | mmichelson | 2007-07-13 15:15:30 -0500 (Fri, 13 Jul 2007) | 13 lines

Merged revisions 75066 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75066 | mmichelson | 2007-07-13 15:10:39 -0500 (Fri, 13 Jul 2007) | 5 lines

Fixed an issue where chanspy flags were uninitialized if no options were passed.
What triggered this investigation was an IRC chat where some people's quiet flags were
set while others' weren't even though none of them had specified the q option.


........

................

................
r75109 | russell | 2007-07-13 15:37:27 -0500 (Fri, 13 Jul 2007) | 19 lines

Merged revisions 75108 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75108 | russell | 2007-07-13 15:36:16 -0500 (Fri, 13 Jul 2007) | 11 lines

Merged revisions 75107 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75107 | russell | 2007-07-13 15:35:22 -0500 (Fri, 13 Jul 2007) | 3 lines

Fix a couple potential minor memory leaks.  load_moh_classes() could return
without destroying the loaded configuration.

........

................

................
r75163 | russell | 2007-07-15 21:44:49 -0500 (Sun, 15 Jul 2007) | 4 lines

Cast the 2nd argument to iconv() to a void *, as some systems define it as a
(const char *), while others define it as (char *).  This is done to suppress
compiler warnings about it.

................
r75164 | russell | 2007-07-15 21:51:56 -0500 (Sun, 15 Jul 2007) | 5 lines

Merge a bunch of doxygen updates to header files.  This includes changes to
use the \retval tag for documenting return values, fixing various warnings
when generating the documentation, and various other things.
(closes issue #10203, snuffy)

................
r75183 | file | 2007-07-16 08:35:20 -0500 (Mon, 16 Jul 2007) | 2 lines

It is no longer required for each module that deals with a channel to call ast_module_user_hangup_all in it's unload function. The loader will automatically perform this action for it.

................
r75200 | file | 2007-07-16 09:39:29 -0500 (Mon, 16 Jul 2007) | 2 lines

Applications no longer need to call ast_module_user_add and ast_module_user_remove. This is now taken care of in the pbx_exec function outside of the application.

................
r75227 | file | 2007-07-16 10:57:01 -0500 (Mon, 16 Jul 2007) | 2 lines

I found this sillyness when I did my ast_module_user conversion. Return immediately if no data was passed to the Verbose application.

................
r75254 | mmichelson | 2007-07-16 13:18:19 -0500 (Mon, 16 Jul 2007) | 16 lines

Merged revisions 75253 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75253 | mmichelson | 2007-07-16 13:16:15 -0500 (Mon, 16 Jul 2007) | 8 lines

Restoring functionality from 1.2 wherein Retrydial will not exit if there is no announce file specified.
This change makes it so that if there is no announce file specified, the application will continue until finished (or caller hangs up).
If a bogus announce file is specified, then a warning message will be printed saying that the file could not be found, but execution will
still continue. 

(closes issue #10186, reported by jon, patched by me)


........

................
r75255 | file | 2007-07-16 13:24:29 -0500 (Mon, 16 Jul 2007) | 2 lines

For my next trick I will make it so dialplan functions no longer need to call ast_module_user_add and ast_module_user_remove. These are now called in the ast_func_read and ast_func_write functions outside of the module.

................
r75259 | file | 2007-07-16 13:36:02 -0500 (Mon, 16 Jul 2007) | 2 lines

Add in check for the GCC attribute deprecated. It may be used soon!

................
r75260 | file | 2007-07-16 13:38:28 -0500 (Mon, 16 Jul 2007) | 2 lines

Change the function name slightly... just for kpfleming!

................
r75307 | kpfleming | 2007-07-16 15:58:56 -0500 (Mon, 16 Jul 2007) | 19 lines

Merged revisions 75306 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75306 | kpfleming | 2007-07-16 15:53:24 -0500 (Mon, 16 Jul 2007) | 11 lines

Merged revisions 75304 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75304 | kpfleming | 2007-07-16 15:46:58 -0500 (Mon, 16 Jul 2007) | 3 lines

provide proper copyright/license attribution for this structure that was copied from a BSD-licensed header file long, long ago...


........

................

................
r75351 | qwell | 2007-07-17 07:01:05 -0500 (Tue, 17 Jul 2007) | 6 lines

Fix an incorrect parenthesization (TODO: Find a better word) in app_dial

Pointed out by Fanzhou Zhao

Closes issue #10216

................
r75365 | rizzo | 2007-07-17 07:46:25 -0500 (Tue, 17 Jul 2007) | 7 lines

Initialize a variable to avoid a warning when the compiler
(and/or the optimization level) may think it is used uninitialized.
The code was indeed correct, but unfortunately the result of
some compiler checks such as -Wunused and -Wuninitialized depends
heavily on the optimization level.


................
r75379 | rizzo | 2007-07-17 09:32:15 -0500 (Tue, 17 Jul 2007) | 16 lines

Introduce ast_parse_arg() , a generic function to parse strings
in a consistent way. This is meant to replace the custom code
which is repeated all over the place in the various files when
parsing config files, CLI entries and other string information.

Right now the code supports parsing int32, uint32 and sockaddr_in with
optional default values and bound checks. It contains minimal error
checking, but that can be easily extended as the need arises.

Being a new API i am introducing this only in trunk, though I believe
that once the interface has been ironed out it might become a
worthwhile addition to 1.4 as well - basically, the first time
we will need to fix a piece of argument parsing code, we might as
well bring in this change and use the new API instead.


................
r75381 | file | 2007-07-17 09:48:17 -0500 (Tue, 17 Jul 2007) | 2 lines

Make trunk build once again.

................
r75400 | murf | 2007-07-17 14:40:29 -0500 (Tue, 17 Jul 2007) | 1 line

via 10206, I have added an option (e) to Dial to allow the h exten to get run on peer. Had to upgrade ast_flag stuff to 64 bits to do this.
................
r75402 | russell | 2007-07-17 14:46:13 -0500 (Tue, 17 Jul 2007) | 11 lines

Merged revisions 75401 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75401 | russell | 2007-07-17 14:45:07 -0500 (Tue, 17 Jul 2007) | 3 lines

Remove a duplicated newline character in AGI debug output.
(closes issue #10207, patch by seanbright)

........

................
r75404 | russell | 2007-07-17 15:01:54 -0500 (Tue, 17 Jul 2007) | 20 lines

Merged revisions 75403 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75403 | russell | 2007-07-17 15:01:12 -0500 (Tue, 17 Jul 2007) | 12 lines

(closes issue #10209)
Reported by: juggie
Patches:
      10209-trunk-2.patch uploaded by juggie
Tested by: juggie, blitzrage

In ast_pbx_run(), mark a channel as hung up after an application returned -1, 
or when it runs out of extensions to execute.  This is so that code can detect
that this channel has been hung up for things like making sure DeadAGI is used
on actual dead channels, and is beneficial for other things, like making sure
someone doesn't try to start spying on a channel that is about to go away.

........

................
r75406 | mmichelson | 2007-07-17 15:05:19 -0500 (Tue, 17 Jul 2007) | 14 lines

Merged revisions 75405 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75405 | mmichelson | 2007-07-17 15:03:48 -0500 (Tue, 17 Jul 2007) | 6 lines

Fixing an error I made earlier. ast_fileexists can return -1 on failure, so I need to be sure that we only enter the if
statement if it is successful.

Related to my fix to issue #10186


........

................
r75438 | russell | 2007-07-17 15:34:52 -0500 (Tue, 17 Jul 2007) | 15 lines

Blocked revisions 75437 via svnmerge

........
r75437 | russell | 2007-07-17 15:33:06 -0500 (Tue, 17 Jul 2007) | 8 lines

(issue #10210)
Reported by: juggie
Patches:
      10210-1.4-grr.patch uploaded by juggie (license #24)
Tested by: juggie, blitzrage

Log a warning if someone uses DeadAGI on a live channel.

........

................
r75442 | russell | 2007-07-17 15:42:50 -0500 (Tue, 17 Jul 2007) | 20 lines

Merged revisions 75441 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75441 | russell | 2007-07-17 15:42:12 -0500 (Tue, 17 Jul 2007) | 12 lines

Merged revisions 75440 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75440 | russell | 2007-07-17 15:41:41 -0500 (Tue, 17 Jul 2007) | 4 lines

After parsing information elements in IAX frames, set the data length to zero,
so that code later on does not think it has data to copy.
(ASA-2007-015)

........

................

................
r75443 | file | 2007-07-17 15:44:55 -0500 (Tue, 17 Jul 2007) | 9 lines

Blocked revisions 75439 via svnmerge

........
r75439 | file | 2007-07-17 17:40:57 -0300 (Tue, 17 Jul 2007) | 2 lines

Ensure that the pointer to STUN data does not go to unaccessible memory. (ASA-2007-017)

........

................
r75446 | russell | 2007-07-17 15:49:09 -0500 (Tue, 17 Jul 2007) | 21 lines

Merged revisions 75445 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75445 | russell | 2007-07-17 15:48:21 -0500 (Tue, 17 Jul 2007) | 13 lines

Merged revisions 75444 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75444 | russell | 2007-07-17 15:45:27 -0500 (Tue, 17 Jul 2007) | 5 lines

Ensure that when encoding the contents of an ast_frame into an iax_frame, that
the size of the destination buffer is known in the iax_frame so that code
won't write past the end of the allocated buffer when sending outgoing frames.
(ASA-2007-014)

........

................

................
r75448 | russell | 2007-07-17 15:52:20 -0500 (Tue, 17 Jul 2007) | 8 lines

Blocked revisions 75447 via svnmerge

........
r75447 | russell | 2007-07-17 15:51:25 -0500 (Tue, 17 Jul 2007) | 1 line

cast arguments to ast_log so that it builds without warnings for me
........

................
r75451 | russell | 2007-07-17 15:58:40 -0500 (Tue, 17 Jul 2007) | 19 lines

Merged revisions 75450 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75450 | russell | 2007-07-17 15:57:56 -0500 (Tue, 17 Jul 2007) | 11 lines

Merged revisions 75449 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75449 | russell | 2007-07-17 15:57:09 -0500 (Tue, 17 Jul 2007) | 3 lines

Properly check for the length in the skinny packet to prevent an invalid memcpy.
(ASA-2007-016)

........

................

................
r75505 | murf | 2007-07-17 16:52:51 -0500 (Tue, 17 Jul 2007) | 1 line

Spotted this bug today myself, trying to reproduce a BE bug. Use a vert bar instead of a comma, when calling RAND.
................
r75530 | tilghman | 2007-07-18 07:38:36 -0500 (Wed, 18 Jul 2007) | 10 lines

Merged revisions 75529 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75529 | tilghman | 2007-07-18 07:29:41 -0500 (Wed, 18 Jul 2007) | 2 lines

Using a freed frame causes crashes (closes issue #9317)

........

................
r75566 | file | 2007-07-18 08:59:01 -0500 (Wed, 18 Jul 2007) | 2 lines

Minor code tweaks. Variables were being checked wrong in some situations and didn't need to be checked in others.

................
r75584 | file | 2007-07-18 09:20:19 -0500 (Wed, 18 Jul 2007) | 13 lines

Merged revisions 75583 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75583 | file | 2007-07-18 11:18:53 -0300 (Wed, 18 Jul 2007) | 5 lines

(closes issue #10224)
Reported by: irroot

Record the threadid of each running thread before shutting them down as the thread themselves may change the value.

........

................
r75585 | murf | 2007-07-18 09:35:07 -0500 (Wed, 18 Jul 2007) | 1 line

This corrects the problem with flags and %lld formats on 64-bit machines, where uint64_t is NOT acceptable for %lld, and also works on 32-bit machines. At least, with gcc.
................
r75586 | file | 2007-07-18 09:59:20 -0500 (Wed, 18 Jul 2007) | 2 lines

Clean up func_curl a bit.

................
r75620 | file | 2007-07-18 10:26:52 -0500 (Wed, 18 Jul 2007) | 10 lines

Merged revisions 75619 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75619 | file | 2007-07-18 12:25:45 -0300 (Wed, 18 Jul 2007) | 2 lines

Don't bother reloading chan_h323 if it did not load successfully in the first place. This would otherwise cause a crash.

........

................
r75622 | file | 2007-07-18 10:42:11 -0500 (Wed, 18 Jul 2007) | 13 lines

Merged revisions 75621 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75621 | file | 2007-07-18 12:41:06 -0300 (Wed, 18 Jul 2007) | 5 lines

(closes issue #10165)
Reported by: elandivar

It is possible for hold status to exist without call limits set, so we need to ensure update_call_counter is executed regardless.

........

................
r75624 | file | 2007-07-18 10:45:18 -0500 (Wed, 18 Jul 2007) | 10 lines

Merged revisions 75623 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75623 | file | 2007-07-18 12:44:02 -0300 (Wed, 18 Jul 2007) | 2 lines

Few more places that needs to check for onhold state.

........

................
r75659 | dhubbard | 2007-07-18 12:59:56 -0500 (Wed, 18 Jul 2007) | 17 lines

Merged revisions 75658 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75658 | dhubbard | 2007-07-18 12:56:30 -0500 (Wed, 18 Jul 2007) | 9 lines

Merged revisions 75657 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75657 | dhubbard | 2007-07-18 12:48:33 -0500 (Wed, 18 Jul 2007) | 1 line

removed the word 'pissed' from ast_log(...) function call for BE-90
........

................

................
r75706 | tilghman | 2007-07-18 14:47:20 -0500 (Wed, 18 Jul 2007) | 2 lines

Merge in ast_strftime branch, which changes timestamps to be accurate to the microsecond, instead of only to the second

................
r75709 | russell | 2007-07-18 14:50:21 -0500 (Wed, 18 Jul 2007) | 1 line

convert some lines indented with spaces to tabs
................
r75710 | qwell | 2007-07-18 14:51:18 -0500 (Wed, 18 Jul 2007) | 13 lines

Merged revisions 75707 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #9887)
........
r75707 | qwell | 2007-07-18 14:48:12 -0500 (Wed, 18 Jul 2007) | 4 lines

Fix issues with new 79x1 phones.

Issue 9887, patches by DEA

........

................
r75713 | file | 2007-07-18 15:01:52 -0500 (Wed, 18 Jul 2007) | 9 lines

Blocked revisions 75712 via svnmerge

........
r75712 | file | 2007-07-18 17:00:23 -0300 (Wed, 18 Jul 2007) | 2 lines

Backport GCC 4.2 fixes. Without these Asterisk won't build under devmode using GCC 4.2.

........

................
r75714 | qwell | 2007-07-18 15:05:45 -0500 (Wed, 18 Jul 2007) | 13 lines

Merged revisions 75711 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #9245)
........
r75711 | qwell | 2007-07-18 14:54:32 -0500 (Wed, 18 Jul 2007) | 4 lines

Fixes for 7935/7936 conference phones.

Issue 9245, patch by slimey.

........

................
r75734 | qwell | 2007-07-18 15:18:00 -0500 (Wed, 18 Jul 2007) | 9 lines

Merged revisions 75732 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75732 | qwell | 2007-07-18 15:17:27 -0500 (Wed, 18 Jul 2007) | 1 line

Umm, why are we transmitting dialtone on cfwdall?
........

................
r75750 | tilghman | 2007-07-18 15:43:54 -0500 (Wed, 18 Jul 2007) | 18 lines

Merged revisions 75749 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75749 | tilghman | 2007-07-18 15:40:18 -0500 (Wed, 18 Jul 2007) | 10 lines

Merged revisions 75748 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75748 | tilghman | 2007-07-18 15:31:36 -0500 (Wed, 18 Jul 2007) | 2 lines

Store prior to copy (closes issue #10193)

........

................

................
r75761 | russell | 2007-07-18 16:10:27 -0500 (Wed, 18 Jul 2007) | 21 lines

Merged revisions 75759 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75759 | russell | 2007-07-18 16:09:46 -0500 (Wed, 18 Jul 2007) | 13 lines

Merged revisions 75757 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75757 | russell | 2007-07-18 16:09:13 -0500 (Wed, 18 Jul 2007) | 5 lines

When traversing the queue of frames for possible retransmission after
receiving a VNAK, handle sequence number wraparound so that all frames that 
should be retransmitted actually do get retransmitted.
(issue #10227, reported and patched by mihai)

........

................

................
r75805 | tilghman | 2007-07-18 17:40:03 -0500 (Wed, 18 Jul 2007) | 2 lines

Change IAX variables to use datastores (closes issue #9315)

................
r75806 | russell | 2007-07-18 17:52:54 -0500 (Wed, 18 Jul 2007) | 5 lines

I thought I noticed a memory leak earlier when I saw that the contents of this
list were not destroyed when the module is unloaded.  However, after reading
the code related to the use of this list a lot today, I realized that it isn't
necessary.  So, I have added a comment to explain why it isn't necessary.

................
r75808 | qwell | 2007-07-18 18:00:30 -0500 (Wed, 18 Jul 2007) | 9 lines

Merged revisions 75807 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75807 | qwell | 2007-07-18 17:59:18 -0500 (Wed, 18 Jul 2007) | 1 line

Need to make sure we set milliseconds and timestamp - pointed out by the recent ast_ time stuff from Tilghman
........

................
r75841 | tilghman | 2007-07-18 22:37:12 -0500 (Wed, 18 Jul 2007) | 2 lines

Fix trunk where I broke it earlier (for ast_strftime branch)

................
r75857 | tilghman | 2007-07-18 23:45:20 -0500 (Wed, 18 Jul 2007) | 2 lines

Allow chan_misdn to build in dev-mode

................
r75873 | rizzo | 2007-07-19 02:41:45 -0500 (Thu, 19 Jul 2007) | 4 lines

portability fix: use %f instead of %lf when printing double.
The l is useless.


................
r75874 | rizzo | 2007-07-19 02:51:34 -0500 (Thu, 19 Jul 2007) | 4 lines

ast_sip_ouraddrfor() never fails, so make it void
and remove the code that would never be called.


................
r75875 | rizzo | 2007-07-19 03:00:03 -0500 (Thu, 19 Jul 2007) | 4 lines

document the use of externip, externhost and other nat-related options,
as well as the handling of the sip socket.


................
r75878 | rizzo | 2007-07-19 03:07:04 -0500 (Thu, 19 Jul 2007) | 8 lines

print more of the network settings (externip, externhost etc.)
in the "sip show settings" cli output. I have put these in a
separate section, probably even bindaddr and SIP port should go
there.

There are more things to add here e.g. localnet and so on.


................
r75894 | rizzo | 2007-07-19 07:38:13 -0500 (Thu, 19 Jul 2007) | 4 lines

comment out some terribly expensive debugging code
in the body of ast_apply_ha()


................
r75911 | russell | 2007-07-19 09:46:49 -0500 (Thu, 19 Jul 2007) | 3 lines

Remove some debug code that was added in revision 75894, which removed some
other debug code.  :)

................
r75929 | russell | 2007-07-19 10:53:50 -0500 (Thu, 19 Jul 2007) | 22 lines

Merged revisions 75928 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r75928 | russell | 2007-07-19 10:53:15 -0500 (Thu, 19 Jul 2007) | 14 lines

Merged revisions 75927 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75927 | russell | 2007-07-19 10:49:42 -0500 (Thu, 19 Jul 2007) | 6 lines

When processing full frames, take sequence number wraparound into account when
deciding whether or not we need to request retransmissions by sending a VNAK.
This code could cause VNAKs to be sent erroneously in some cases, and to not
be sent in other cases when it should have been.
(closes issue #10237, reported and patched by mihai)

........

................

................
r75930 | russell | 2007-07-19 10:59:19 -0500 (Thu, 19 Jul 2007) | 6 lines

(closes issue #10210, reported and patched by juggie)

This merges the trunk only part of the patches from this issue.  In 1.4, res_agi
will issue a warning if you try to use DeadAGI on a channel that is not hung up.
Now, in trunk, it just plain won't let you do it.

................
r75977 | mmichelson | 2007-07-19 11:29:51 -0500 (Thu, 19 Jul 2007) | 18 lines

Merged revisions 75969 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75969 | mmichelson | 2007-07-19 11:26:10 -0500 (Thu, 19 Jul 2007) | 10 lines

Changes in handling return values of several functions in app_queue. This all started as a fix for issue #10008
but now includes all of the following changes:

1. Simplifying the code to handle positive return values from ast API calls.
2. Removing the background_file function.
3. The fix for issue #10008

(closes issue #10008, reported and patched by dimas)


........

................
r75979 | mmichelson | 2007-07-19 14:02:38 -0500 (Thu, 19 Jul 2007) | 11 lines

Merged revisions 75978 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75978 | mmichelson | 2007-07-19 13:59:30 -0500 (Thu, 19 Jul 2007) | 3 lines

The diff on this looks pretty big but all I did was remove a pointless if statement (always evaluates true).


........

................
r75981 | qwell | 2007-07-19 15:36:55 -0500 (Thu, 19 Jul 2007) | 9 lines

Blocked revisions 75980 via svnmerge

........
r75980 | qwell | 2007-07-19 15:36:06 -0500 (Thu, 19 Jul 2007) | 2 lines

Remove some duplicate code.

........

................
r75982 | murf | 2007-07-19 17:00:59 -0500 (Thu, 19 Jul 2007) | 1 line

This repairs a 'warning: ISO C90 forbids mixed declarations and code' message that cripples my dev-mode enabled build
................
r75983 | murf | 2007-07-19 18:24:27 -0500 (Thu, 19 Jul 2007) | 1 line

After some study, thought, comparing, etc. I've backed out the previous universal mod to make ast_flags a 64 bit thing. Instead, I added a 64-bit version of ast_flags (ast_flags64), and 64-bit versions of the test-flag, set-flag, etc. macros, and an app_parse_options64 routine, and I use these in app_dial alone, to eliminate the 30-option limit it had grown to meet. There is room now for 32 more options and flags. I was heavily tempted to implement some of the other ideas that were presented, but this solution does not intro any new versions of dial, doesn't have a different API, has a minimal/zero impact on code outside of dial, and doesn't seriously (I hope) affect the code structure of dial. It's the best I can think of right now. My goal was NOT to rewrite dial. I leave that to a future, coordinated effort.
................
r76015 | tilghman | 2007-07-19 20:54:52 -0500 (Thu, 19 Jul 2007) | 2 lines

Reduce some logging contention by switching several locks over to rwlocks

................
r76034 | rizzo | 2007-07-20 09:38:36 -0500 (Fri, 20 Jul 2007) | 13 lines

expose struct ast_ha so external code can do things such as printing it
(e.g. chan_sip.c in a subsequent commit).

Obviously exposing the internals of a data structure is far from ideal
(especially in a case like this where the implementation is very
inefficient and will need to be changed at some point).

On the other hand, it was also unclear what additional APIs should
we provide instead, and because exposing the stucture has no impact
on source and binary compatibility, this seemed to me the best option at
this time.


................
r76035 | rizzo | 2007-07-20 09:54:01 -0500 (Fri, 20 Jul 2007) | 33 lines

Extend the 'network settings' section with indication on the
localnet settings (requires the change in SVN 76034), and also
give an indication on whether/why/how the remapping of addresses
in SIP message is done or not.

I think this is especially useful for debugging the configuration,
as the address remapping depends on a combination of at least 3
parameters (localnet, externhost, externip) and successful DNS lookup.

An example of the output of this section is below:

	Network Settings:
	---------------------------
	  SIP address remapping:  Enabled using externhost
	  Externhost:             foo.dyndns.net
	  Externip:               80.64.128.23:0
	  Externrefresh:          10
	  Internal IP:            12.34.56.78:5060
	  Localnet:               192.168.0.0/255.255.0.0
				  10.0.0.0/255.0.0.0

I leave to the community the judgement if the above info is a
useful addition for 1.4. It is not a bugfix, but it is neither a
new feature, only a useful diagnostic tool.

Note that I would like to move there also the bindaddress/port
information, in the usual addr:port format e.g.

          Bindaddress:            0.0.0.0:5060

so that network information is all in one place.


................
r76037 | rizzo | 2007-07-20 10:06:54 -0500 (Fri, 20 Jul 2007) | 8 lines

Don't use a field size for the last argument of printf format,
because in this case the string is left-aligned and it is not
truncated anyways.

Omitting the field size prevents the generation of trailing whitespace,
which makes the string fit in smaller windows.


................
r76055 | file | 2007-07-20 11:49:58 -0500 (Fri, 20 Jul 2007) | 9 lines

Blocked revisions 76054 via svnmerge

........
r76054 | file | 2007-07-20 13:49:13 -0300 (Fri, 20 Jul 2007) | 2 lines

Move makeannouncement variable declaration to proper place.

........

................
r76056 | file | 2007-07-20 11:51:09 -0500 (Fri, 20 Jul 2007) | 2 lines

It is impossible for the externhost variable to not exist, it is however possible for it to be empty.

................
r76070 | file | 2007-07-20 12:11:39 -0500 (Fri, 20 Jul 2007) | 14 lines

Merged revisions 76067 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76067 | file | 2007-07-20 14:10:17 -0300 (Fri, 20 Jul 2007) | 6 lines

(closes issue #10246)
Reported by: fkasumovic
Patches:
      res_conver.patch uploaded by fkasumovic (license #101)
Use the last occurance of . to find the extension, not the first occurance.

........

................
r76091 | file | 2007-07-20 12:21:23 -0500 (Fri, 20 Jul 2007) | 22 lines

Merged revisions 76087 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76087 | file | 2007-07-20 14:20:09 -0300 (Fri, 20 Jul 2007) | 14 lines

Merged revisions 76080 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76080 | file | 2007-07-20 14:16:48 -0300 (Fri, 20 Jul 2007) | 6 lines

(closes issue #10247)
Reported by: fkasumovic
Patches:
      chan_sip.patch uploaded by fkasumovic (license #101)
Drop any peer realm authentication entries when reloading so multiple entries do not get added to the peer.

........

................

................
r76138 | russell | 2007-07-20 13:28:15 -0500 (Fri, 20 Jul 2007) | 14 lines

Merged revisions 76132 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76132 | russell | 2007-07-20 13:22:24 -0500 (Fri, 20 Jul 2007) | 6 lines

Use the define that specifies the default length of an artificially created
DTMF digit in the ast_senddigit() function.  The define is set to 100ms by
default, which is the same thing that this function was using.  But, using
the define lets changes take effect in this case, as well as the others where
it was already used.

........

................
r76140 | mmichelson | 2007-07-20 13:44:30 -0500 (Fri, 20 Jul 2007) | 14 lines

Merged revisions 76139 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76139 | mmichelson | 2007-07-20 13:42:27 -0500 (Fri, 20 Jul 2007) | 6 lines

When using users.conf for the entries in the directory, if multiple users had the same last name, only the first user listed would be available
in the directory.

(closes issue #10200, reported by mrskippy, patched by me)


........

................
r76175 | qwell | 2007-07-20 15:33:34 -0500 (Fri, 20 Jul 2007) | 10 lines

Merged revisions 76174 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76174 | qwell | 2007-07-20 15:32:55 -0500 (Fri, 20 Jul 2007) | 2 lines

It's possible for sub->owner to be NULL here if you cancel the call immediately after/during sending a digit.

........

................
r76177 | qwell | 2007-07-20 15:56:07 -0500 (Fri, 20 Jul 2007) | 9 lines

Blocked revisions 76176 via svnmerge

........
r76176 | qwell | 2007-07-20 15:54:10 -0500 (Fri, 20 Jul 2007) | 2 lines

Eliminate a compiler warning with gcc 4.2 by constifying a char *

........

................

[... 53379 lines stripped ...]



More information about the asterisk-commits mailing list