[asterisk-commits] phsultan: branch phsultan/res_jabber-openssl r78716 - in /team/phsultan/res_j...

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Thu Aug 9 11:06:28 CDT 2007


Author: phsultan
Date: Thu Aug  9 11:06:26 2007
New Revision: 78716

URL: http://svn.digium.com/view/asterisk?view=rev&rev=78716
Log:
Merged revisions 77299,77319,77349,77351,77381,77411,77432,77461,77491,77520,77534,77537-77538,77541,77572,77602-77603,77616,77630-77631,77647-77648,77650,77653-77654,77668-77669,77682,77684,77697,77711-77712,77725-77726,77739,77753,77766,77769-77770,77772-77773,77779,77781,77784,77786-77787,77789-77793,77796-77797,77799-77801,77808,77810,77819-77821,77825,77828-77829,77833-77834,77838,77847,77851,77853,77855,77857-77858,77864,77866,77868,77870,77872,77875-77876,77878-77879,77884,77888-77889,77891,77895,77940-77941,77944,77946,77948,77950,77994,77997,78029,78064,78096,78102,78138,78140,78142,78144,78147,78167-78168,78173,78179,78181,78183,78185-78186,78192,78227,78243,78276,78278-78279,78312,78338,78342,78346-78347,78372,78378,78417-78418,78442,78451,78489,78521,78541,78570,78590,78635,78637,78648-78649,78679,78683,78685-78686 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r77299 | russell | 2007-07-26 17:49:18 +0200 (Thu, 26 Jul 2007) | 12 lines

Do a massive conversion for using the ast_verb() macro
(closes issue #10277, patches by mvanbaak)

Basically, this changes ...

if (option_verbose > 2)
   ast_verbose(VERBOSE_PREFIX_3, "Something\n");

to ...

ast_verb(3, "Something\n");

................
r77319 | mmichelson | 2007-07-26 20:31:28 +0200 (Thu, 26 Jul 2007) | 16 lines

Merged revisions 77318 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77318 | mmichelson | 2007-07-26 13:30:29 -0500 (Thu, 26 Jul 2007) | 8 lines

Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice.
This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur.
Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so
I have removed the check for conn's existence from my_unload_module.

(closes issue 10295, reported by junky, patched by me with input from prashant_jois)


........

................
r77349 | tilghman | 2007-07-26 21:29:12 +0200 (Thu, 26 Jul 2007) | 10 lines

Merged revisions 77348 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77348 | tilghman | 2007-07-26 14:27:18 -0500 (Thu, 26 Jul 2007) | 2 lines

Oops, that builtin define should be all-lowercase.

........

................
r77351 | tilghman | 2007-07-26 21:33:47 +0200 (Thu, 26 Jul 2007) | 10 lines

Merged revisions 77350 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77350 | tilghman | 2007-07-26 14:32:17 -0500 (Thu, 26 Jul 2007) | 2 lines

Missed one

........

................
r77381 | mmichelson | 2007-07-26 22:39:46 +0200 (Thu, 26 Jul 2007) | 15 lines

Merged revisions 77380 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77380 | mmichelson | 2007-07-26 15:35:17 -0500 (Thu, 26 Jul 2007) | 7 lines

Fixes to get ast_backtrace working properly. The AST_DEVMODE macro was never defined so the majority of ast_backtrace never
attempted compilation. The makefile now defines AST_DEVMODE if configure was run with --enable-dev-mode. Also, changes were 
made to acccomodate 64 bit systems in ast_backtrace.

Thanks to qwell, kpfleming, and Corydon76 for their roles in allowing me to get this committed


........

................
r77411 | russell | 2007-07-26 23:24:42 +0200 (Thu, 26 Jul 2007) | 18 lines

Merged revisions 77410 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77410 | russell | 2007-07-26 16:23:23 -0500 (Thu, 26 Jul 2007) | 10 lines

AST_DEVMODE was defined in trunk, but not in 1.4.  When Asterisk is compiled
under dev mode, AST_DEVMODE will get defined in buildopts.h.  Change 1.4 to
define it in the same way that trunk does.  Also, revert the change that added
this define in the Makefile

The advantage to doing it this way is that buildopts.h gets installed when
you install Asterisk.  Then, when building any out of tree modules, or
building asterisk-addons, these modules know which options the rest of Asterisk
was built with.

........

................
r77432 | kpfleming | 2007-07-27 00:17:25 +0200 (Fri, 27 Jul 2007) | 15 lines

Merged revisions 77424,77429 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77424 | kpfleming | 2007-07-26 17:14:21 -0500 (Thu, 26 Jul 2007) | 2 lines

use new canonical name for download server

........
r77429 | kpfleming | 2007-07-26 17:16:42 -0500 (Thu, 26 Jul 2007) | 2 lines

change protocol for downloads as well

........

................
r77461 | file | 2007-07-27 01:20:25 +0200 (Fri, 27 Jul 2007) | 12 lines

Merged revisions 77460 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77460 | file | 2007-07-26 20:19:04 -0300 (Thu, 26 Jul 2007) | 4 lines

(closes issue #10302)
Reported by: litnialex
If a DTMF end frame comes from a channel without a begin and it is going to a technology that only accepts end frames (aka INFO) then use the minimum DTMF duration if one is not in the frame already.

........

................
r77491 | mmichelson | 2007-07-27 16:31:35 +0200 (Fri, 27 Jul 2007) | 11 lines

Merged revisions 77490 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77490 | mmichelson | 2007-07-27 09:30:43 -0500 (Fri, 27 Jul 2007) | 3 lines

"re-invite" was misspelled


........

................
r77520 | murf | 2007-07-27 17:46:20 +0200 (Fri, 27 Jul 2007) | 1 line

These fixes take care of two problems: a complaint in asterisk-dev that goto's aren't working in trunk, a side effect of the move to commas as arg seps in apps and funcs; and a problem I spotted myself with dial's 'e' option, where gotos were off by one, because I forgot to set the AUTOLOOP flag in the peer channel.
................
r77534 | tilghman | 2007-07-27 18:20:55 +0200 (Fri, 27 Jul 2007) | 2 lines

'dialplan save' shouldn't be converting '|' back to ',' anymore.

................
r77537 | file | 2007-07-27 18:29:40 +0200 (Fri, 27 Jul 2007) | 14 lines

Merged revisions 77536 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77536 | file | 2007-07-27 13:27:16 -0300 (Fri, 27 Jul 2007) | 6 lines

(closes issue #10323)
Reported by: julianjm
Patches:
      chan_sip_device_state_hold_fix.v1.diff.txt uploaded by julianjm (license 99)
Clear ONHOLD flag when decrementing the onHold peer count. If we did not do this the count may keep decreasing.

........

................
r77538 | file | 2007-07-27 18:31:55 +0200 (Fri, 27 Jul 2007) | 2 lines

Turn 4 lines of code into 1 line that does the same thing.

................
r77541 | file | 2007-07-27 19:05:18 +0200 (Fri, 27 Jul 2007) | 14 lines

Merged revisions 77540 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77540 | file | 2007-07-27 14:04:08 -0300 (Fri, 27 Jul 2007) | 6 lines

(closes issue #10310)
Reported by: prashant_jois
Patches:
      cdr_pgsql.patch uploaded by prashant (license 114)
Finish the Postgresql connection after the log messages are printed so we don't access invalid memory.

........

................
r77572 | tilghman | 2007-07-27 20:17:12 +0200 (Fri, 27 Jul 2007) | 10 lines

Merged revisions 77571 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77571 | tilghman | 2007-07-27 13:15:58 -0500 (Fri, 27 Jul 2007) | 2 lines

Missing newline

........

................
r77602 | tilghman | 2007-07-28 01:16:04 +0200 (Sat, 28 Jul 2007) | 2 lines

Target asterisk.pdf stopped building when the build was moved to the doc directory.

................
r77603 | tilghman | 2007-07-28 01:21:23 +0200 (Sat, 28 Jul 2007) | 2 lines

Some ODBC drivers don't set the CHAR_OCTET_LENGTH field correctly.

................
r77616 | rizzo | 2007-07-28 09:44:16 +0200 (Sat, 28 Jul 2007) | 27 lines

make use of received= and rport= fields in sip replies.

In a nutshell, these fields are used to tell a sip entity
the address and port its request came from, and are extremely
useful in the presence of NATs, especially with symmetric NATs
where STUN is totally ineffective.

This patch stores the address and port in the 'ourip' field of
the dialog descriptor, so they can be reused in subsequent transactions.
As it is, it works well for things like REGISTER requiring authentication,
because the second REGISTER request (with auth credentials) will carry
the correct address. Maybe it can also be useful, in case of an address
change, to do one or both of the following:

+ propagate the new address to the parent user/peer descriptor so that new
  dialogs will use the correct address from the beginning.
  This is trivial to implement, I am just waiting for feedback on this.

+ re-issue a request in case of an address change. This a lot less trivial,
  maybe unnecessary, and probably covered by the previous item.

I would seriously consider this patch for addition to 1.4 and 1.2.
The code is very little intrusive, and it would solve in a correct
way the nat traversal problems for which externip/externaddr/stunaddr
are only a partial and expensive workaround.


................
r77630 | rizzo | 2007-07-28 11:29:22 +0200 (Sat, 28 Jul 2007) | 2 lines

simplify a conditional expression using S_OR

................
r77631 | rizzo | 2007-07-28 11:32:10 +0200 (Sat, 28 Jul 2007) | 2 lines

remove an unused string

................
r77647 | rizzo | 2007-07-28 18:25:25 +0200 (Sat, 28 Jul 2007) | 11 lines

start introducing hooks for reference counts on dialog descriptors.
This commit is, for all practical purposes, a no-op, as it only
introduces the dialog_ref() and dialog_unref() methods, and uses them
in a few places (not all the places where they would be needed).

The goal is to start annotating the code with these calls, so the transition
to a proper container will be easier.

Nothing to backport.


................
r77648 | rizzo | 2007-07-28 18:38:07 +0200 (Sat, 28 Jul 2007) | 2 lines

more dialog_ref()/dialog_unref() calls

................
r77650 | rizzo | 2007-07-28 19:16:24 +0200 (Sat, 28 Jul 2007) | 2 lines

more dialog_ref()/dialog_unref() calls

................
r77653 | rizzo | 2007-07-29 01:43:35 +0200 (Sun, 29 Jul 2007) | 7 lines

add some documentation to auto_congest(), and some
dialog_ref/unref (they are a no-op at the moment).
Also clean a pointer after freeing memory to avoid
dangling references, and write a for() loop in canonical form.

In practice, everything in this commit is a no-op.

................
r77654 | rizzo | 2007-07-29 02:06:35 +0200 (Sun, 29 Jul 2007) | 8 lines

make register_unref() return NULL so it is easy to cleanup
the original pointer while calling the function.

on passing add some comments on one of the places where it
is used, and explain why it is safe there.

again, a no-op for practical purposes.

................
r77668 | rizzo | 2007-07-29 10:19:19 +0200 (Sun, 29 Jul 2007) | 6 lines

more documentation on internal representation of incoming SIP messages.

Remove definitions for now-unused flags, and add references to print
routines for other flags.


................
r77669 | rizzo | 2007-07-29 10:58:10 +0200 (Sun, 29 Jul 2007) | 8 lines

back on cleaning up the usage of flags.
Move together flags used in the same way (e.g. dialog only,
dialog-peer, ...) so it will become easier to deal with them
in a more systematic way.
This is being done in stages so it will be easier to detect
breakage, if any should occur.


................
r77682 | rizzo | 2007-07-29 11:27:30 +0200 (Sun, 29 Jul 2007) | 18 lines

remove bit position from description of SIP_* flags. 

use AST_FORMAT_AUDIO_MASK instead of playing with AST_FORMAT_MAX_AUDIO
to determine audio formats.
There is a dubious use of AST_FORMAT_MAX_AUDIO in sip_request_call()
which surely needs fixing, namely: 
 
        /* mask request with some set of allowed formats.
         * XXX this needs to be fixed.
         * The original code uses AST_FORMAT_AUDIO_MASK, but it is
         * unclear what to use here. We have global_capabilities, which is
         * configured from sip.conf, and sip_tech.capabilities, which is
         * hardwired to all audio formats.
         */
 
The latter is possibly something to backport when fixed.


................
r77684 | rizzo | 2007-07-29 12:13:14 +0200 (Sun, 29 Jul 2007) | 6 lines

build the version of sip_tech with no send_digit_begin
at load time instead of duplicating the initializer.
This should remove the risk of forgetting fields in the
initializer.


................
r77697 | rizzo | 2007-07-29 12:49:32 +0200 (Sun, 29 Jul 2007) | 2 lines

minor simplification of a conditional statement

................
r77711 | rizzo | 2007-07-29 22:01:36 +0200 (Sun, 29 Jul 2007) | 14 lines

Move some global 'flags' to individual variables.

Start putting these variables in a single struct (called 'sip_cfg' for the time
being, but it could as well be 'global' or some other name) so it
is easy, when reading the code, to figure out what they are for.

The downside of using struct fields instead of individual global
variables is that the compiler cannot tell if there are unused fields.
But the advantage of not cluttering the namespace and manilpulating
all these variables at once certainly overcome the disadvantagess.

Nothing to backport, again.


................
r77712 | rizzo | 2007-07-29 22:13:32 +0200 (Sun, 29 Jul 2007) | 3 lines

move RT_FROMCONTACT to a proper sip_peer field.


................
r77725 | rizzo | 2007-07-29 22:28:02 +0200 (Sun, 29 Jul 2007) | 2 lines

move the two remaining peer flags to proper variables.

................
r77726 | rizzo | 2007-07-29 22:55:20 +0200 (Sun, 29 Jul 2007) | 8 lines

use a function, cli_yesno(), to produce the output Yes or No for
CLI lines. This helps maintaining consistency on output, slightly
improves readability, and maybe one day will make it easier to
translate the output in other languages (though i have a hard time
believing that a CLI user who needs 'yes' and 'no' to be translated
can actually figure out what he/she is doing!)


................
r77739 | rizzo | 2007-07-29 23:24:56 +0200 (Sun, 29 Jul 2007) | 19 lines

move some dialog-only flags to proper variables, namely
SIP_NOVIDEO, SIP_DIALOG_ANSWEREDELSEWHERE, SIP_PAGE2_NOTEXT,
SIP_PAGE2_OUTGOING_CALL
These are seldom used so the diff is relatively small.

Note that 'OUTGOING_CALL' is dangerously similar to another
dialog flag, 'SIP_OUTGOING', so the description will need to
clarify the different meaning of the two.

Also note that the description of NOTEXT is a bit unclear - does
it mean we don't support it, or 'not requested or not supported' ?


On passing fix a comment referring to video instead of text.

Finally, mark with XXX a possibly misleading debugging message.
(maybe the latter is worth backporting).


................
r77753 | rizzo | 2007-07-30 10:07:00 +0200 (Mon, 30 Jul 2007) | 5 lines

rename handle_request() to handle_incoming(), as the former
was misleading - the function deals with all incoming packets, be
them requests or responses.


................
r77766 | rizzo | 2007-07-30 12:55:37 +0200 (Mon, 30 Jul 2007) | 12 lines

minor code rearrangements:
+ place the link field at the beginning of struct sip_pvt, 
  and not somewhere in the middle;
 
+ in __sip_reliable_xmit, remove a duplicate assignment, and
  put the statements in a more logical order (i.e. first copy
  the payload and associated info, then copy arguments from the
  caller, then finish initializing the headers...)
 
nothing to backport.


................
r77769 | file | 2007-07-30 16:53:14 +0200 (Mon, 30 Jul 2007) | 20 lines

Merged revisions 77768 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77768 | file | 2007-07-30 11:51:44 -0300 (Mon, 30 Jul 2007) | 12 lines

Merged revisions 77767 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77767 | file | 2007-07-30 11:50:02 -0300 (Mon, 30 Jul 2007) | 4 lines

(closes issue #10334)
Reported by: ramonpeek
Pass through the return value from macro_exec through the MacroIf application.

........

................

................
r77770 | russell | 2007-07-30 17:22:20 +0200 (Mon, 30 Jul 2007) | 2 lines

Resolve some compiler warnings so that I can build under dev mode

................
r77772 | file | 2007-07-30 17:49:30 +0200 (Mon, 30 Jul 2007) | 14 lines

Merged revisions 77771 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77771 | file | 2007-07-30 12:47:52 -0300 (Mon, 30 Jul 2007) | 6 lines

(closes issue #10301)
Reported by: fnordian
Patches:
      asterisk-1.4.9-channel.c.patch uploaded by fnordian (license 110)
Restore previous behavior where if we failed to lock the channel we wanted we would return to exactly the same point as if we had just reentered the function.

........

................
r77773 | file | 2007-07-30 18:02:01 +0200 (Mon, 30 Jul 2007) | 2 lines

Minor clean up of app_followme.

................
r77779 | file | 2007-07-30 19:12:58 +0200 (Mon, 30 Jul 2007) | 12 lines

Merged revisions 77778 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77778 | file | 2007-07-30 14:11:02 -0300 (Mon, 30 Jul 2007) | 4 lines

(closes issue #10327)
Reported by: kkiely
Instead of directly mucking with the extension/context/priority of the channel we are transferring when it has a PBX simply call ast_async_goto on it. This will ensure that the channel gets handled properly and sent to the right place.

........

................
r77781 | russell | 2007-07-30 19:31:29 +0200 (Mon, 30 Jul 2007) | 24 lines

Merged revisions 77780 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77780 | russell | 2007-07-30 12:29:43 -0500 (Mon, 30 Jul 2007) | 16 lines

(closes issue #10301)
Reported by: fnordian
Patches:
      asterisk-1.4.9-channel.c.patch uploaded by fnordian (license 110)
      Additional changes by me

Fix some problems in channel_find_locked() which can cause an infinite loop.
The reference to the previous channel is set to NULL in some cases.  These changes
ensure that the reference to the previous channel gets restored before needing
it again.

I'm not convinced that the code that is setting it to NULL is really the right
thing to do.  However, I am making these changes to fix the obvious problem
and just leaving an XXX comment that it needs a better explanation that what
is there now.

........

................
r77784 | tilghman | 2007-07-30 20:45:09 +0200 (Mon, 30 Jul 2007) | 18 lines

Merged revisions 77783 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77783 | tilghman | 2007-07-30 13:43:55 -0500 (Mon, 30 Jul 2007) | 10 lines

Merged revisions 77782 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77782 | tilghman | 2007-07-30 13:40:54 -0500 (Mon, 30 Jul 2007) | 2 lines

Revert change in revision 71656, even though it fixed a bug, because many people were depending upon the (broken) behavior.

........

................

................
r77786 | russell | 2007-07-30 20:56:29 +0200 (Mon, 30 Jul 2007) | 11 lines

Merged revisions 77785 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77785 | russell | 2007-07-30 13:55:15 -0500 (Mon, 30 Jul 2007) | 3 lines

file and I both committed changes for issue #10301.  Remove a duplicated
assignment to restore the original value of the previous channel.

........

................
r77787 | tilghman | 2007-07-30 21:11:28 +0200 (Mon, 30 Jul 2007) | 2 lines

Cleanup of res_agi, ensuring thread safety (closes issue #10288)

................
r77789 | russell | 2007-07-30 21:18:24 +0200 (Mon, 30 Jul 2007) | 18 lines

Merged revisions 77788 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77788 | russell | 2007-07-30 14:13:31 -0500 (Mon, 30 Jul 2007) | 10 lines

(closes issue #10279)
Reported by: seanbright
Patches:
      res_agi.carefulwrite.1.4.07252007.patch uploaded by seanbright (license 71)
      res_agi.carefulwrite.trunk.07252007.patch uploaded by seanbright (license 71)

Allow the "agi_network: yes" line to be printed out in the AGI debug output.
Also, allow partial writes to be handled when writing out this line just like
it is for all of the others.

........

................
r77790 | russell | 2007-07-30 21:31:27 +0200 (Mon, 30 Jul 2007) | 5 lines

Remove an XXX comment noting that it would be nice for a declaration to be
inside of a function.  (Yes, it would!)  Replace it with a note that explains
why it can't be done using the way that the AST_THREADSTORAGE macro is
currently defined.

................
r77791 | russell | 2007-07-30 21:35:33 +0200 (Mon, 30 Jul 2007) | 7 lines

Improve ast_agi_fdprintf() by using the ast_str() API.
 * Use a thread local ast_str for building the string that will be written out
   to the console for debug, and to the FD for the AGI itself, instead of allocating
   a buffer on the heap every time the function is called.
 * Use the information contained within the ast_str to determine how many bytes
   need to be written instead of calling strlen().

................
r77792 | russell | 2007-07-30 21:39:52 +0200 (Mon, 30 Jul 2007) | 2 lines

Fix the return value of ast_agi_fdprintf() to include the result from ast_carefulwrite()

................
r77793 | rizzo | 2007-07-30 21:42:25 +0200 (Mon, 30 Jul 2007) | 4 lines

print formats as 0x%x instead of %d in a warning message.
Being bitmasks, it is a lot easier to read this way.


................
r77796 | qwell | 2007-07-30 22:19:13 +0200 (Mon, 30 Jul 2007) | 15 lines

Merged revisions 77795 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10083)
........
r77795 | qwell | 2007-07-30 15:17:08 -0500 (Mon, 30 Jul 2007) | 6 lines

Applications like SayAlpha() should not hang up the channel if you
 request an "unknown" character such as a comma.
Instead, skip the character and move on.

Issue 10083, initial patch by jsmith, modified by me.

........

................
r77797 | russell | 2007-07-30 22:21:05 +0200 (Mon, 30 Jul 2007) | 16 lines

Merged revisions 77794 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77794 | russell | 2007-07-30 15:16:43 -0500 (Mon, 30 Jul 2007) | 8 lines

Fix an issue that could potentially cause corruption of the global iax frame
queue.  In the network_thread() loop, it traverses the list using the
AST_LIST_TRAVERSE_SAFE macro.  However, to remove an element of the list within
this loop, it used AST_LIST_REMOVE, instead of AST_LIST_REMOVE_CURRENT, which I
believe could leave some of the internal variables of the SAFE macro invalid.
Mihai says that he already made this change in his local copy and it didn't help
his VNAK storm issues, but I still think it's wrong.  :)

........

................
r77799 | russell | 2007-07-30 22:33:44 +0200 (Mon, 30 Jul 2007) | 2 lines

Explicitly set a variable to 1 instead of using the increment operator.

................
r77800 | russell | 2007-07-30 22:36:18 +0200 (Mon, 30 Jul 2007) | 2 lines

Change another unnecessary use of the increment operator to explicitly set the var to 1

................
r77801 | file | 2007-07-30 22:42:28 +0200 (Mon, 30 Jul 2007) | 2 lines

Add support for call forwarding and timeouts to the dialing API.

................
r77808 | tilghman | 2007-07-31 03:10:47 +0200 (Tue, 31 Jul 2007) | 2 lines

Mostly cleanup of documentation to substitute the pipe with the comma, but a few other formatting cleanups, too.

................
r77810 | murf | 2007-07-31 05:32:04 +0200 (Tue, 31 Jul 2007) | 1 line

Discovered in experiments on core files: if you wrap the lock and unlock calls with sip_pvt_lock and sip_pvt_unlock, you lose the tracing info you would normally get via DETECT_DEADLOCKS; so I turn these two functions into macros when DETECT_DEADLOCKS is called. This way, you get meaningful stuff in the file and func slots in the lock_info struct.
................
r77819 | kpfleming | 2007-07-31 16:54:46 +0200 (Tue, 31 Jul 2007) | 3 lines

umm... let's build with --enable-dev-mode, mmkay?


................
r77820 | kpfleming | 2007-07-31 16:55:37 +0200 (Tue, 31 Jul 2007) | 2 lines

use a different method for overriding the send_digit_begin pointer, as the old one fails to compile on my 64-bit system with gcc-4.1 and --enable-dev-mode turned on

................
r77821 | kpfleming | 2007-07-31 17:01:27 +0200 (Tue, 31 Jul 2007) | 2 lines

there is no use in having functions that have no code in them, and hide the locking info when DEBUG_THREADS is enabled... i could have fixed this to be dependent on DEBUG_THREADS, but it would be just as easy for someone to add their test/debugging code to the macros as it would have been to the functions

................
r77825 | mmichelson | 2007-07-31 17:22:32 +0200 (Tue, 31 Jul 2007) | 14 lines

Merged revisions 77824 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77824 | mmichelson | 2007-07-31 10:21:22 -0500 (Tue, 31 Jul 2007) | 6 lines

This patch makes Asterisk send 100 Trying provisional responses upon receipt of re-invites. This makes it so that if there are two or more Asterisk
servers between endpoints, the Asterisk servers will not keep retransmitting the re-invites.

(closes issue #10274, reported by cstadlmann, patched by me with approval from file)


........

................
r77828 | kpfleming | 2007-07-31 17:54:29 +0200 (Tue, 31 Jul 2007) | 10 lines

Merged revisions 77827 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77827 | kpfleming | 2007-07-31 10:53:42 -0500 (Tue, 31 Jul 2007) | 2 lines

DETECT_DEADLOCKS can't be enabled without DEBUG_THREADS or it does nothing

........

................
r77829 | murf | 2007-07-31 17:59:01 +0200 (Tue, 31 Jul 2007) | 1 line

thanks to Russel, for pointing out that the dialoglist_lock/unlock routines also need to be macros if DETECT_DEADLOCKS is set
................
r77833 | file | 2007-07-31 18:21:34 +0200 (Tue, 31 Jul 2007) | 10 lines

Merged revisions 77831 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77831 | file | 2007-07-31 13:17:09 -0300 (Tue, 31 Jul 2007) | 2 lines

Add a flag to the speech API that allows an engine to set whether it received results or not.

........

................
r77834 | tilghman | 2007-07-31 18:44:25 +0200 (Tue, 31 Jul 2007) | 3 lines

Add func_lock, which creates dialplan mutexes, and note that the Macro apps are now deprecated.
(Closes issue #10264)

................
r77838 | tilghman | 2007-07-31 20:50:06 +0200 (Tue, 31 Jul 2007) | 2 lines

Add some documentation detailing an aspect of dialplan functions, as requested by Russell

................
r77847 | murf | 2007-07-31 23:33:37 +0200 (Tue, 31 Jul 2007) | 17 lines

Merged revisions 77844 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77844 | murf | 2007-07-31 14:59:10 -0600 (Tue, 31 Jul 2007) | 9 lines

Merged revisions 77842 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77842 | murf | 2007-07-31 13:19:35 -0600 (Tue, 31 Jul 2007) | 1 line

This probably isn't super-general, but it's a first stab at using kill -11 to generate a core file instead of gcore.
........

................

................
r77851 | tilghman | 2007-08-01 06:36:15 +0200 (Wed, 01 Aug 2007) | 2 lines

Twould help if we actually defined ->mod before comparing against it (reported and fixed by Juggie via IRC).

................
r77853 | mmichelson | 2007-08-01 16:02:19 +0200 (Wed, 01 Aug 2007) | 15 lines

Merged revisions 77852 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77852 | mmichelson | 2007-08-01 08:59:59 -0500 (Wed, 01 Aug 2007) | 7 lines

If a queue uses dynamic realtime members, then the member list should be updated after each attempt to call the queue.
This fixes an issue where if a caller calls into a queue where no one is logged in, they would wait forever even if a member
logged in at some point.

(closes issue #10346, reported by and tested by blitzrage, patched by me)


........

................
r77855 | mmichelson | 2007-08-01 16:09:45 +0200 (Wed, 01 Aug 2007) | 16 lines

Merged revisions 77854 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77854 | mmichelson | 2007-08-01 09:08:57 -0500 (Wed, 01 Aug 2007) | 8 lines

Fixes an issue I introduced to queues wherein a queue with joinempty=yes would kick people out of the queue because of erroneously
thinking the 'n' option was in use.

(closes issue #10320, reported by jfitzgibbon, patched by me, tested by blitzrage and me)

Thank you blitzrage for all the testing you've done lately with queues! It's much appreciated!


........

................
r77857 | file | 2007-08-01 17:28:02 +0200 (Wed, 01 Aug 2007) | 2 lines

Convert CLI helpers list to rwlist.

................
r77858 | russell | 2007-08-01 17:39:54 +0200 (Wed, 01 Aug 2007) | 5 lines

Convert code that checks the _softhangup member of ast_channel directory to use
the ast_check_hangup() funciton.  This function takes scheduled hangups into
account.
(closes issue #10230, patch by Juggie)

................
r77864 | file | 2007-08-01 19:27:09 +0200 (Wed, 01 Aug 2007) | 10 lines

Merged revisions 77863 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77863 | file | 2007-08-01 14:22:35 -0300 (Wed, 01 Aug 2007) | 2 lines

Extend autoconf logic to determine which version of gethostbyname_r is on the system.

........

................
r77866 | file | 2007-08-01 19:47:05 +0200 (Wed, 01 Aug 2007) | 10 lines

Merged revisions 77865 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77865 | file | 2007-08-01 14:42:52 -0300 (Wed, 01 Aug 2007) | 2 lines

And for my last trick... make sure that if gethostbyname_r is exported by a library that it is used.

........

................
r77868 | file | 2007-08-01 19:53:09 +0200 (Wed, 01 Aug 2007) | 10 lines

Merged revisions 77867 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77867 | file | 2007-08-01 14:52:11 -0300 (Wed, 01 Aug 2007) | 2 lines

Whoops, I meant R_5 not R5.

........

................
r77870 | file | 2007-08-01 20:01:33 +0200 (Wed, 01 Aug 2007) | 10 lines

Merged revisions 77869 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77869 | file | 2007-08-01 14:56:59 -0300 (Wed, 01 Aug 2007) | 2 lines

Add some fixes for building on Solaris.

........

................
r77872 | file | 2007-08-01 20:10:25 +0200 (Wed, 01 Aug 2007) | 11 lines

Blocked revisions 77871 via svnmerge

........
r77871 | file | 2007-08-01 15:08:51 -0300 (Wed, 01 Aug 2007) | 4 lines

(closes issue #10351)
Reported by: ftarz
Some platforms don't like it when you pass NULL to vsnprintf so pass "" instead.

........

................
r77875 | file | 2007-08-01 20:56:31 +0200 (Wed, 01 Aug 2007) | 2 lines

Don't look for /dev/urandom when cross compiling. Just assume it is not available.

................
r77876 | file | 2007-08-01 21:12:36 +0200 (Wed, 01 Aug 2007) | 2 lines

Solaris does not have a sysinfo like we know of on Linux.

................
r77878 | file | 2007-08-01 21:37:59 +0200 (Wed, 01 Aug 2007) | 2 lines

Instead of adding the SOLARIS check to each HAVE_SYSINFO check let's just make the sysinfo autoconf logic a bit pickier about what it considers a usable sysinfo.

................
r77879 | qwell | 2007-08-01 22:05:13 +0200 (Wed, 01 Aug 2007) | 4 lines

Add the Ring time in the CONNECT on the queue_log and on the Manager event AgentConnect

Closes issue #10349, patch by eliel

................
r77884 | qwell | 2007-08-01 23:12:02 +0200 (Wed, 01 Aug 2007) | 15 lines

Merged revisions 77883 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77883 | qwell | 2007-08-01 16:08:42 -0500 (Wed, 01 Aug 2007) | 7 lines

Fix an issue that caused one-way audio on some newer devices (specifically the 7921),
 due to sending packets in the wrong order during hangup.

Also make sure we clear tones/messages on the correct line/instance.

Issue 10291, patch by DEA, tested by sbisker and myself.

........

................
r77888 | tilghman | 2007-08-02 00:19:34 +0200 (Thu, 02 Aug 2007) | 10 lines

Merged revisions 77886 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77886 | tilghman | 2007-08-01 17:14:47 -0500 (Wed, 01 Aug 2007) | 2 lines

Voicemail with ODBC_STORAGE defined does not compile cleanly (missing def)

........

................
r77889 | russell | 2007-08-02 00:24:23 +0200 (Thu, 02 Aug 2007) | 31 lines

Merged revisions 77887 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77887 | russell | 2007-08-01 17:16:17 -0500 (Wed, 01 Aug 2007) | 23 lines

Fix some race conditions which have been causing weird problems in chan_iax2.
The most notable problem is that people have been seeing storms of VNAK frames
being sent due to really old frames mysteriously being in the retransmission
queue and never getting removed.

It was possible that a dynamic thread got created, but did not acquire its lock
before the thread that created it signals it to perform an action.  When this
happens, the thread will sleep until it hits a timeout, and then get destroyed.
So, the action never gets performed and in some cases, means a frame doesn't
get transmitted and never gets freed since the scheduler never gets a chance
to reschedule transmission.

Another less severe race condition is in the handling of a timeout for a dynamic
thread.  It was possible for it to be acquired to perform at action at the same
time that it hit a timeout.  When this occurs, whatever action it was acquired
for would never get performed.

(patch contributed by Mihai and SteveK)
(closes issue #10289)
(closes issue #10248)
(closes issue #10232)
(possibly related to issue #10359)

........

................
r77891 | qwell | 2007-08-02 00:31:07 +0200 (Thu, 02 Aug 2007) | 13 lines

Merged revisions 77890 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10291)
........
r77890 | qwell | 2007-08-01 17:28:56 -0500 (Wed, 01 Aug 2007) | 4 lines

Put in some additional debug information for softkey/stimulus messages.

Issue 10291, patch by DEA.

........

................
r77895 | qwell | 2007-08-02 17:16:53 +0200 (Thu, 02 Aug 2007) | 14 lines

Merged revisions 77894 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10358)
........
r77894 | qwell | 2007-08-02 10:15:45 -0500 (Thu, 02 Aug 2007) | 5 lines

Make sure that we show the correct extension if dialed from a macro
"From: 5555" rather than "From: s"

Issue 10358, initial patch by DEA, reworked by me to use S_OR, tested by sbisker

........

................
r77940 | russell | 2007-08-02 18:58:26 +0200 (Thu, 02 Aug 2007) | 12 lines

Merged revisions 77939 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77939 | russell | 2007-08-02 11:56:04 -0500 (Thu, 02 Aug 2007) | 4 lines

Add another sanity check to vnak_retransmit().  This check ensures that frames
that have already been marked for deletion don't get retransmitted.
(closes issue #10361, patch from mihai)

........

................
r77941 | russell | 2007-08-02 19:09:42 +0200 (Thu, 02 Aug 2007) | 6 lines

Fix an issue that Simon pointed out to me on IRC.  There were cases in the
trunk version of find_idle_thread() where the old full frame processing
information was not cleared out.  This would have caused full frames to get
deferred for processing by threads that weren't actually processing frames for
that call.  Nice catch!!

................
r77944 | russell | 2007-08-02 20:05:23 +0200 (Thu, 02 Aug 2007) | 17 lines

Merged revisions 77943 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77943 | russell | 2007-08-02 13:04:43 -0500 (Thu, 02 Aug 2007) | 9 lines

Fix another race condition in the handling of dynamic threads.  If the dynamic
thread timed out waiting for something to do, but was acquired to perform an
action immediately afterwords, then wait on the condition again to give the
other thread a chance to finish setting up the data for what action this thread
should perform.  Otherwise, if it immediately continues, it will perform the
wrong action.
(reported on IRC by mihai, patch by me)
(related to issue #10289)

........

................
r77946 | murf | 2007-08-02 20:32:34 +0200 (Thu, 02 Aug 2007) | 17 lines

Merged revisions 77945 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77945 | murf | 2007-08-02 12:21:40 -0600 (Thu, 02 Aug 2007) | 9 lines

Merged revisions 77942 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77942 | murf | 2007-08-02 11:56:37 -0600 (Thu, 02 Aug 2007) | 1 line

This patch hopefully solves 10141; The user is running with it, and it doesn't appear to harm asterisk's operation, and may prevent a crash. I'll store it in 1.2, as we have shut down support on 1.2, but since I developed the patch before support finished, and it might affect 1.4 and trunk, I'm going ahead with it.
........

................

................
r77948 | qwell | 2007-08-02 20:43:29 +0200 (Thu, 02 Aug 2007) | 14 lines

Merged revisions 77947 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10299)
........
r77947 | qwell | 2007-08-02 13:42:36 -0500 (Thu, 02 Aug 2007) | 5 lines

Make sure we clear the prompt status message on a hangup.
Also rearrange messages to better fit with what a wireshark trace shows it should be.

Issue 10299, initial patch and solution by sbisker, modified by me to fit with wireshark trace.

........

................
r77950 | russell | 2007-08-02 21:26:12 +0200 (Thu, 02 Aug 2007) | 13 lines

Merged revisions 77949 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77949 | russell | 2007-08-02 14:25:14 -0500 (Thu, 02 Aug 2007) | 5 lines

Fix the case where a dynamic thread times out waiting for something to do
during the first time it runs.  This shouldn't ever happen, but we should
account for it anyway.
(pointed out by pete, who works with mihai)

........

................
r77994 | qwell | 2007-08-02 22:23:20 +0200 (Thu, 02 Aug 2007) | 14 lines

Merged revisions 77993 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10325)
........
r77993 | qwell | 2007-08-02 15:22:40 -0500 (Thu, 02 Aug 2007) | 5 lines

If a device disconnects, the session will go away.
If this happens during call setup, we need to give up.

Issue 10325.

........

................
r77997 | qwell | 2007-08-02 23:54:54 +0200 (Thu, 02 Aug 2007) | 14 lines

Merged revisions 77996 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #9779)
........
r77996 | qwell | 2007-08-02 16:53:39 -0500 (Thu, 02 Aug 2007) | 5 lines

Make sure we actually allow 6 chars to be sent.
Also make note of the "A" option of date format.

Issue 9779, modifications by DEA, wedhorn, and myself.

........

................
r78029 | russell | 2007-08-03 04:05:02 +0200 (Fri, 03 Aug 2007) | 14 lines

Merged revisions 78028 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r78028 | russell | 2007-08-02 21:04:22 -0500 (Thu, 02 Aug 2007) | 6 lines

Don't reuse the timespec that was set to 0 in the previous timedwait as it
will just return immediately.  Also, fix some logic so the thread's lock

[... 23282 lines stripped ...]



More information about the asterisk-commits mailing list