[asterisk-commits] file: branch 1.4 r43933 - in /branches/1.4:
apps/ channels/ funcs/ include/as...
asterisk-commits at lists.digium.com
asterisk-commits at lists.digium.com
Thu Sep 28 11:05:44 MST 2006
Author: file
Date: Thu Sep 28 13:05:43 2006
New Revision: 43933
URL: http://svn.digium.com/view/asterisk?rev=43933&view=rev
Log:
Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)
Modified:
branches/1.4/apps/app_alarmreceiver.c
branches/1.4/apps/app_festival.c
branches/1.4/apps/app_followme.c
branches/1.4/apps/app_playback.c
branches/1.4/apps/app_rpt.c
branches/1.4/channels/chan_iax2.c
branches/1.4/channels/chan_mgcp.c
branches/1.4/channels/chan_misdn.c
branches/1.4/channels/chan_sip.c
branches/1.4/channels/chan_skinny.c
branches/1.4/channels/iax2-provision.c
branches/1.4/funcs/func_timeout.c
branches/1.4/include/asterisk/logger.h
branches/1.4/main/frame.c
branches/1.4/main/udptl.c
branches/1.4/res/res_monitor.c
branches/1.4/res/res_musiconhold.c
branches/1.4/res/res_smdi.c
Modified: branches/1.4/apps/app_alarmreceiver.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_alarmreceiver.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/apps/app_alarmreceiver.c (original)
+++ branches/1.4/apps/app_alarmreceiver.c Thu Sep 28 13:05:43 2006
@@ -136,7 +136,7 @@
res = ast_db_put(db_family, key, value);
if((res)&&(option_verbose >= 4))
- ast_verbose(VERBOSE_PREFIX_4 "AlarmReceiver: database_increment write error");
+ ast_verbose(VERBOSE_PREFIX_4 "AlarmReceiver: database_increment write error\n");
return;
}
Modified: branches/1.4/apps/app_festival.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_festival.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/apps/app_festival.c (original)
+++ branches/1.4/apps/app_festival.c Thu Sep 28 13:05:43 2006
@@ -485,7 +485,7 @@
* */
if ( read_data == -1 )
{
- ast_log(LOG_WARNING,"Unable to read from cache/festival fd");
+ ast_log(LOG_WARNING,"Unable to read from cache/festival fd\n");
close(fd);
ast_config_destroy(cfg);
ast_module_user_remove(u);
Modified: branches/1.4/apps/app_followme.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_followme.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/apps/app_followme.c (original)
+++ branches/1.4/apps/app_followme.c Thu Sep 28 13:05:43 2006
@@ -951,7 +951,7 @@
if (option_debug)
ast_log(LOG_DEBUG, "New profile %s.\n", args.followmeid);
if (!f) {
- ast_log(LOG_WARNING, "Profile requested, %s, not found in the configuration.", args.followmeid);
+ ast_log(LOG_WARNING, "Profile requested, %s, not found in the configuration.\n", args.followmeid);
res = -1;
} else {
/* XXX TODO: Reinsert the db check value to see whether or not follow-me is on or off */
Modified: branches/1.4/apps/app_playback.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_playback.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/apps/app_playback.c (original)
+++ branches/1.4/apps/app_playback.c Thu Sep 28 13:05:43 2006
@@ -341,7 +341,7 @@
return RESULT_SHOWUSAGE;
mode = argv[2];
- ast_log(LOG_WARNING, "init say.c from %s to %s", old_mode, mode);
+ ast_log(LOG_WARNING, "init say.c from %s to %s\n", old_mode, mode);
if (!strcmp(mode, old_mode)) {
ast_log(LOG_WARNING, "say mode is %s already\n", mode);
Modified: branches/1.4/apps/app_rpt.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_rpt.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/apps/app_rpt.c (original)
+++ branches/1.4/apps/app_rpt.c Thu Sep 28 13:05:43 2006
@@ -2618,7 +2618,7 @@
rpt_mutex_lock(&myrpt->lock);
remque((struct qlem *) tele); /* We don't like stuck transmitters, remove it from the queue */
rpt_mutex_unlock(&myrpt->lock);
- ast_log(LOG_WARNING, "Could not create telemetry thread: %s",strerror(res));
+ ast_log(LOG_WARNING, "Could not create telemetry thread: %s\n",strerror(res));
}
return;
}
Modified: branches/1.4/channels/chan_iax2.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_iax2.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/channels/chan_iax2.c (original)
+++ branches/1.4/channels/chan_iax2.c Thu Sep 28 13:05:43 2006
@@ -5425,7 +5425,7 @@
username = strsep(&stringp, "@");
hostname = strsep(&stringp, "@");
if (!hostname) {
- ast_log(LOG_WARNING, "Format for registration is user[:secret]@host[:port] at line %d", lineno);
+ ast_log(LOG_WARNING, "Format for registration is user[:secret]@host[:port] at line %d\n", lineno);
return -1;
}
stringp=username;
Modified: branches/1.4/channels/chan_mgcp.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_mgcp.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/channels/chan_mgcp.c (original)
+++ branches/1.4/channels/chan_mgcp.c Thu Sep 28 13:05:43 2006
@@ -3004,7 +3004,7 @@
ast_log(LOG_WARNING, "Off hook, but already have owner on %s@%s\n", p->name, p->parent->name);
} else {
ast_log(LOG_WARNING, "On hook, but already have owner on %s@%s\n", p->name, p->parent->name);
- ast_log(LOG_WARNING, "If we're onhook why are we here trying to handle a hd or hf?");
+ ast_log(LOG_WARNING, "If we're onhook why are we here trying to handle a hd or hf?\n");
}
if (ast_bridged_channel(sub->owner))
ast_queue_control(sub->owner, AST_CONTROL_UNHOLD);
@@ -3793,7 +3793,7 @@
e->sub = sub;
} else {
/* XXX Should find a way to clean up our memory */
- ast_log(LOG_WARNING, "Out of memory allocating subchannel");
+ ast_log(LOG_WARNING, "Out of memory allocating subchannel\n");
return NULL;
}
}
@@ -3910,7 +3910,7 @@
sub->nat = nat;
} else {
/* XXX Should find a way to clean up our memory */
- ast_log(LOG_WARNING, "Out of memory allocating subchannel");
+ ast_log(LOG_WARNING, "Out of memory allocating subchannel\n");
return NULL;
}
}
Modified: branches/1.4/channels/chan_misdn.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_misdn.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/channels/chan_misdn.c (original)
+++ branches/1.4/channels/chan_misdn.c Thu Sep 28 13:05:43 2006
@@ -1896,7 +1896,7 @@
{
struct chan_list *ch=MISDN_ASTERISK_TECH_PVT(ast);
- if (!ch) { ast_verbose("No chan_list in misdn_call"); return -1;}
+ if (!ch) { ast_verbose("No chan_list in misdn_call\n"); return -1;}
newbc->capability=ast->transfercapability;
pbx_builtin_setvar_helper(ast,"TRANSFERCAPABILITY",ast_transfercapability2str(newbc->capability));
@@ -2392,7 +2392,7 @@
if (!f || (f->frametype != AST_FRAME_DTMF))
return frame;
- ast_log(LOG_DEBUG, "Detected inband DTMF digit: %c", f->subclass);
+ ast_log(LOG_DEBUG, "Detected inband DTMF digit: %c\n", f->subclass);
if (tmp->faxdetect && (f->subclass == 'f')) {
/* Fax tone -- Handle and return NULL */
Modified: branches/1.4/channels/chan_sip.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_sip.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/channels/chan_sip.c (original)
+++ branches/1.4/channels/chan_sip.c Thu Sep 28 13:05:43 2006
@@ -3987,7 +3987,7 @@
p->t38.state = T38_LOCAL_REINVITE;
transmit_reinvite_with_t38_sdp(p);
if (option_debug > 1)
- ast_log(LOG_DEBUG, "T38 state changed to %d on channel %s", p->t38.state, ast->name);
+ ast_log(LOG_DEBUG, "T38 state changed to %d on channel %s\n", p->t38.state, ast->name);
}
} else if (!ast_test_flag(&p->flags[0], SIP_PENDINGBYE)) {
if (option_debug > 2)
@@ -14307,10 +14307,7 @@
parse_request(&req);
req.method = find_sip_method(req.rlPart1);
if (ast_test_flag(&req, SIP_PKT_DEBUG)) {
- ast_verbose("--- (%d headers %d lines)", req.headers, req.lines);
- if (req.headers + req.lines == 0)
- ast_verbose(" Nat keepalive ");
- ast_verbose("---\n");
+ ast_verbose("--- (%d headers %d lines)%s ---\n", req.headers, req.lines, (req.headers + req.lines == 0) ? " Nat keepalive" : "");
}
if (req.headers < 2) {
Modified: branches/1.4/channels/chan_skinny.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_skinny.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/channels/chan_skinny.c (original)
+++ branches/1.4/channels/chan_skinny.c Thu Sep 28 13:05:43 2006
@@ -4507,7 +4507,7 @@
if (skinnysock < 0) {
skinnysock = socket(AF_INET, SOCK_STREAM, 0);
if(setsockopt(skinnysock, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) == -1) {
- ast_log(LOG_ERROR, "Set Socket Options failed: errno %d, %s", errno, strerror(errno));
+ ast_log(LOG_ERROR, "Set Socket Options failed: errno %d, %s\n", errno, strerror(errno));
ast_config_destroy(cfg);
return 0;
}
Modified: branches/1.4/channels/iax2-provision.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/iax2-provision.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/channels/iax2-provision.c (original)
+++ branches/1.4/channels/iax2-provision.c Thu Sep 28 13:05:43 2006
@@ -283,7 +283,7 @@
if (!src) {
src = iax_template_find(def, 0);
if (!src)
- ast_log(LOG_WARNING, "Unable to locate default base template '%s' for creating '%s', omitting.", def, s);
+ ast_log(LOG_WARNING, "Unable to locate default base template '%s' for creating '%s', omitting.\n", def, s);
}
if (!src)
return -1;
Modified: branches/1.4/funcs/func_timeout.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/funcs/func_timeout.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/funcs/func_timeout.c (original)
+++ branches/1.4/funcs/func_timeout.c Thu Sep 28 13:05:43 2006
@@ -46,7 +46,7 @@
time_t myt;
if (!data) {
- ast_log(LOG_ERROR, "Must specify type of timeout to get.");
+ ast_log(LOG_ERROR, "Must specify type of timeout to get.\n");
return -1;
}
@@ -76,7 +76,7 @@
break;
default:
- ast_log(LOG_ERROR, "Unknown timeout type specified.");
+ ast_log(LOG_ERROR, "Unknown timeout type specified.\n");
break;
}
@@ -91,7 +91,7 @@
struct tm myt;
if (!data) {
- ast_log(LOG_ERROR, "Must specify type of timeout to set.");
+ ast_log(LOG_ERROR, "Must specify type of timeout to set.\n");
return -1;
}
@@ -137,7 +137,7 @@
break;
default:
- ast_log(LOG_ERROR, "Unknown timeout type specified.");
+ ast_log(LOG_ERROR, "Unknown timeout type specified.\n");
break;
}
Modified: branches/1.4/include/asterisk/logger.h
URL: http://svn.digium.com/view/asterisk/branches/1.4/include/asterisk/logger.h?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/include/asterisk/logger.h (original)
+++ branches/1.4/include/asterisk/logger.h Thu Sep 28 13:05:43 2006
@@ -48,7 +48,7 @@
/*! Used for sending a log message */
/*!
\brief This is the standard logger function. Probably the only way you will invoke it would be something like this:
- ast_log(LOG_WHATEVER, "Problem with the %s Captain. We should get some more. Will %d be enough?", "flux capacitor", 10);
+ ast_log(LOG_WHATEVER, "Problem with the %s Captain. We should get some more. Will %d be enough?\n", "flux capacitor", 10);
where WHATEVER is one of ERROR, DEBUG, EVENT, NOTICE, or WARNING depending
on which log you wish to output to. These are implemented as macros, that
will provide the function with the needed arguments.
Modified: branches/1.4/main/frame.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/frame.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/main/frame.c (original)
+++ branches/1.4/main/frame.c Thu Sep 28 13:05:43 2006
@@ -229,7 +229,7 @@
/* IF we have an optimization frame, send it */
if (s->opt) {
if (s->opt->offset < AST_FRIENDLY_OFFSET)
- ast_log(LOG_WARNING, "Returning a frame of inappropriate offset (%d).",
+ ast_log(LOG_WARNING, "Returning a frame of inappropriate offset (%d).\n",
s->opt->offset);
opt = s->opt;
s->opt = NULL;
Modified: branches/1.4/main/udptl.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/udptl.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/main/udptl.c (original)
+++ branches/1.4/main/udptl.c Thu Sep 28 13:05:43 2006
@@ -712,7 +712,7 @@
udptl->error_correction_scheme = UDPTL_ERROR_CORRECTION_NONE;
break;
default:
- ast_log(LOG_WARNING, "error correction parameter invalid");
+ ast_log(LOG_WARNING, "error correction parameter invalid\n");
};
} else
ast_log(LOG_WARNING, "udptl structure is null\n");
Modified: branches/1.4/res/res_monitor.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/res/res_monitor.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/res/res_monitor.c (original)
+++ branches/1.4/res/res_monitor.c Thu Sep 28 13:05:43 2006
@@ -338,7 +338,7 @@
{
char tmp[256];
if (ast_strlen_zero(fname_base)) {
- ast_log(LOG_WARNING, "Cannot change monitor filename of channel %s to null", chan->name);
+ ast_log(LOG_WARNING, "Cannot change monitor filename of channel %s to null\n", chan->name);
return -1;
}
Modified: branches/1.4/res/res_musiconhold.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/res/res_musiconhold.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/res/res_musiconhold.c (original)
+++ branches/1.4/res/res_musiconhold.c Thu Sep 28 13:05:43 2006
@@ -1245,7 +1245,7 @@
res = ast_register_application(app4, moh4_exec, synopsis4, descrip4);
if (!init_classes(0)) { /* No music classes configured, so skip it */
- ast_log(LOG_WARNING, "No music on hold classes configured, disabling music on hold.");
+ ast_log(LOG_WARNING, "No music on hold classes configured, disabling music on hold.\n");
} else {
ast_install_music_functions(local_ast_moh_start, local_ast_moh_stop, local_ast_moh_cleanup);
}
Modified: branches/1.4/res/res_smdi.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/res/res_smdi.c?rev=43933&r1=43932&r2=43933&view=diff
==============================================================================
--- branches/1.4/res/res_smdi.c (original)
+++ branches/1.4/res/res_smdi.c Thu Sep 28 13:05:43 2006
@@ -143,7 +143,7 @@
fclose(file);
ASTOBJ_UNLOCK(iface);
- ast_log(LOG_DEBUG, "Sent MWI unset message for %s on %s", mailbox, iface->name);
+ ast_log(LOG_DEBUG, "Sent MWI unset message for %s on %s\n", mailbox, iface->name);
return 0;
}
@@ -199,7 +199,7 @@
if (elapsed > iface->msg_expiry) {
/* found an expired message */
ASTOBJ_UNREF(md_msg, ast_smdi_md_message_destroy);
- ast_log(LOG_NOTICE, "Purged expired message from %s SMDI MD message queue. Message was %ld milliseconds too old.",
+ ast_log(LOG_NOTICE, "Purged expired message from %s SMDI MD message queue. Message was %ld milliseconds too old.\n",
iface->name, elapsed - iface->msg_expiry);
md_msg = ASTOBJ_CONTAINER_UNLINK_START(&iface->md_q);
}
@@ -267,7 +267,7 @@
if (elapsed > iface->msg_expiry) {
/* found an expired message */
ASTOBJ_UNREF(mwi_msg, ast_smdi_mwi_message_destroy);
- ast_log(LOG_NOTICE, "Purged expired message from %s SMDI MWI message queue. Message was %ld milliseconds too old.",
+ ast_log(LOG_NOTICE, "Purged expired message from %s SMDI MWI message queue. Message was %ld milliseconds too old.\n",
iface->name, elapsed - iface->msg_expiry);
mwi_msg = ASTOBJ_CONTAINER_UNLINK_START(&iface->mwi_q);
}
More information about the asterisk-commits
mailing list