[asterisk-commits] file: branch 1.2 r43924 - in /branches/1.2: ./ apps/ channels/ funcs/ include...

asterisk-commits at lists.digium.com asterisk-commits at lists.digium.com
Thu Sep 28 11:00:31 MST 2006


Author: file
Date: Thu Sep 28 13:00:30 2006
New Revision: 43924

URL: http://svn.digium.com/view/asterisk?rev=43924&view=rev
Log:
Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)

Modified:
    branches/1.2/apps/app_alarmreceiver.c
    branches/1.2/apps/app_festival.c
    branches/1.2/apps/app_hasnewvoicemail.c
    branches/1.2/channels/chan_misdn.c
    branches/1.2/channels/chan_sip.c
    branches/1.2/channels/chan_skinny.c
    branches/1.2/channels/iax2-provision.c
    branches/1.2/frame.c
    branches/1.2/funcs/func_timeout.c
    branches/1.2/include/asterisk/logger.h
    branches/1.2/res/res_features.c
    branches/1.2/res/res_monitor.c
    branches/1.2/res/res_musiconhold.c

Modified: branches/1.2/apps/app_alarmreceiver.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/apps/app_alarmreceiver.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/apps/app_alarmreceiver.c (original)
+++ branches/1.2/apps/app_alarmreceiver.c Thu Sep 28 13:00:30 2006
@@ -145,7 +145,7 @@
 	res = ast_db_put(db_family, key, value);
 	
 	if((res)&&(option_verbose >= 4))
-		ast_verbose(VERBOSE_PREFIX_4 "AlarmReceiver: database_increment write error");
+		ast_verbose(VERBOSE_PREFIX_4 "AlarmReceiver: database_increment write error\n");
 	
 	return;	
 }

Modified: branches/1.2/apps/app_festival.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/apps/app_festival.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/apps/app_festival.c (original)
+++ branches/1.2/apps/app_festival.c Thu Sep 28 13:00:30 2006
@@ -471,7 +471,7 @@
                         * */
                        if ( read_data == -1 )
                        {
-                               ast_log(LOG_WARNING,"Unable to read from cache/festival fd");
+                               ast_log(LOG_WARNING,"Unable to read from cache/festival fd\n");
 			       close(fd);
 			       ast_config_destroy(cfg);
 			       LOCAL_USER_REMOVE(u);

Modified: branches/1.2/apps/app_hasnewvoicemail.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/apps/app_hasnewvoicemail.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/apps/app_hasnewvoicemail.c (original)
+++ branches/1.2/apps/app_hasnewvoicemail.c Thu Sep 28 13:00:30 2006
@@ -260,7 +260,7 @@
 
 	args = ast_strdupa(data);
 	if (!args) {
-		ast_log(LOG_ERROR, "Out of memory");
+		ast_log(LOG_ERROR, "Out of memory\n");
 		LOCAL_USER_REMOVE(u);
 		return buf;
 	}

Modified: branches/1.2/channels/chan_misdn.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/channels/chan_misdn.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/channels/chan_misdn.c (original)
+++ branches/1.2/channels/chan_misdn.c Thu Sep 28 13:00:30 2006
@@ -1630,7 +1630,7 @@
 	
 	{
 		struct chan_list *ch=MISDN_ASTERISK_TECH_PVT(ast);
-		if (!ch) { ast_verbose("No chan_list in misdn_call"); return -1;}
+		if (!ch) { ast_verbose("No chan_list in misdn_call\n"); return -1;}
 		
 		newbc->capability=ast->transfercapability;
 		pbx_builtin_setvar_helper(ast,"TRANSFERCAPABILITY",ast_transfercapability2str(newbc->capability));
@@ -2751,7 +2751,7 @@
 	
 	f = ast_dsp_process(tmp->ast, tmp->dsp, f2);
 	if (f && (f->frametype == AST_FRAME_DTMF)) {
-		ast_log(LOG_DEBUG, "Detected inband DTMF digit: %c", f->subclass);
+		ast_log(LOG_DEBUG, "Detected inband DTMF digit: %c\n", f->subclass);
 		if (f->subclass == 'f' && tmp->faxdetect) {
 			/* Fax tone -- Handle and return NULL */
 			struct ast_channel *ast = tmp->ast;

Modified: branches/1.2/channels/chan_sip.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/channels/chan_sip.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/channels/chan_sip.c (original)
+++ branches/1.2/channels/chan_sip.c Thu Sep 28 13:00:30 2006
@@ -1143,7 +1143,7 @@
 	if (!recordhistory || !p)
 		return 0;
 	if(!(hist = malloc(sizeof(struct sip_history)))) {
-		ast_log(LOG_WARNING, "Can't allocate memory for history");
+		ast_log(LOG_WARNING, "Can't allocate memory for history\n");
 		return 0;
 	}
 	memset(hist, 0, sizeof(struct sip_history));
@@ -11333,10 +11333,7 @@
 	parse_request(&req);
 	req.method = find_sip_method(req.rlPart1);
 	if (ast_test_flag(&req, SIP_PKT_DEBUG)) {
-		ast_verbose("--- (%d headers %d lines)", req.headers, req.lines);
-		if (req.headers + req.lines == 0) 
-			ast_verbose(" Nat keepalive ");
-		ast_verbose("---\n");
+		ast_verbose("--- (%d headers %d lines)%s ---\n", req.headers, req.lines, (req.headers + req.lines == 0) ? " Nat keepalive" : "");
 	}
 
 	if (req.headers < 2) {

Modified: branches/1.2/channels/chan_skinny.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/channels/chan_skinny.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/channels/chan_skinny.c (original)
+++ branches/1.2/channels/chan_skinny.c Thu Sep 28 13:00:30 2006
@@ -1609,7 +1609,7 @@
                        					l->sub = sub;
                        				} else {
                        					/* XXX Should find a way to clean up our memory */
-                       					ast_log(LOG_WARNING, "Out of memory allocating subchannel");
+                       					ast_log(LOG_WARNING, "Out of memory allocating subchannel\n");
                       					return NULL;
                        				}
                     			}
@@ -1617,7 +1617,7 @@
 					d->lines = l;			
 	    			} else {
 			        	/* XXX Should find a way to clean up our memory */
-                    			ast_log(LOG_WARNING, "Out of memory allocating line");
+                    			ast_log(LOG_WARNING, "Out of memory allocating line\n");
                     			return NULL;
 				}
 			} else {
@@ -3178,7 +3178,7 @@
 	if (skinnysock < 0) {
 		skinnysock = socket(AF_INET, SOCK_STREAM, 0);
 		if(setsockopt(skinnysock, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) == -1) {
-			ast_log(LOG_ERROR, "Set Socket Options failed: errno %d, %s", errno, strerror(errno));
+			ast_log(LOG_ERROR, "Set Socket Options failed: errno %d, %s\n", errno, strerror(errno));
 			ast_config_destroy(cfg);
 			return 0;
 		}

Modified: branches/1.2/channels/iax2-provision.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/channels/iax2-provision.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/channels/iax2-provision.c (original)
+++ branches/1.2/channels/iax2-provision.c Thu Sep 28 13:00:30 2006
@@ -279,7 +279,7 @@
 		if (!src) {
 			src = iax_template_find(def, 0);
 			if (!src)
-				ast_log(LOG_WARNING, "Unable to locate default base template '%s' for creating '%s', omitting.", def, s);
+				ast_log(LOG_WARNING, "Unable to locate default base template '%s' for creating '%s', omitting.\n", def, s);
 		}
 		if (!src)
 			return -1;

Modified: branches/1.2/frame.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/frame.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/frame.c (original)
+++ branches/1.2/frame.c Thu Sep 28 13:00:30 2006
@@ -198,7 +198,7 @@
 	/* IF we have an optimization frame, send it */
 	if (s->opt) {
 		if (s->opt->offset < AST_FRIENDLY_OFFSET)
-			ast_log(LOG_WARNING, "Returning a frame of inappropriate offset (%d).",
+			ast_log(LOG_WARNING, "Returning a frame of inappropriate offset (%d).\n",
 							s->opt->offset);
 		opt = s->opt;
 		s->opt = NULL;

Modified: branches/1.2/funcs/func_timeout.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/funcs/func_timeout.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/funcs/func_timeout.c (original)
+++ branches/1.2/funcs/func_timeout.c Thu Sep 28 13:00:30 2006
@@ -43,7 +43,7 @@
 	time_t myt;
 
 	if (!data) {
-		ast_log(LOG_ERROR, "Must specify type of timeout to get.");
+		ast_log(LOG_ERROR, "Must specify type of timeout to get.\n");
                 return NULL;
 	}
 	
@@ -73,7 +73,7 @@
 		break;
 
 	default:
-		ast_log(LOG_ERROR, "Unknown timeout type specified.");
+		ast_log(LOG_ERROR, "Unknown timeout type specified.\n");
 		break;
 	}
 
@@ -87,7 +87,7 @@
 	struct tm myt;
 
 	if (!data) {
-		ast_log(LOG_ERROR, "Must specify type of timeout to set.");
+		ast_log(LOG_ERROR, "Must specify type of timeout to set.\n");
 		return;
 	}
 	
@@ -129,7 +129,7 @@
 		break;
 
 	default:
-		ast_log(LOG_ERROR, "Unknown timeout type specified.");
+		ast_log(LOG_ERROR, "Unknown timeout type specified.\n");
 		break;
 	}
 }

Modified: branches/1.2/include/asterisk/logger.h
URL: http://svn.digium.com/view/asterisk/branches/1.2/include/asterisk/logger.h?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/include/asterisk/logger.h (original)
+++ branches/1.2/include/asterisk/logger.h Thu Sep 28 13:00:30 2006
@@ -43,7 +43,7 @@
 /*! Used for sending a log message */
 /*!
 	\brief This is the standard logger function.  Probably the only way you will invoke it would be something like this:
-	ast_log(LOG_WHATEVER, "Problem with the %s Captain.  We should get some more.  Will %d be enough?", "flux capacitor", 10);
+	ast_log(LOG_WHATEVER, "Problem with the %s Captain.  We should get some more.  Will %d be enough?\n", "flux capacitor", 10);
 	where WHATEVER is one of ERROR, DEBUG, EVENT, NOTICE, or WARNING depending
 	on which log you wish to output to. These are implemented as macros, that
 	will provide the function with the needed arguments.

Modified: branches/1.2/res/res_features.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/res/res_features.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/res/res_features.c (original)
+++ branches/1.2/res/res_features.c Thu Sep 28 13:00:30 2006
@@ -2062,7 +2062,7 @@
 			char *exten, *party=NULL, *app=NULL, *app_args=NULL; 
 
 			if (!tmp_val) { 
-				ast_log(LOG_ERROR, "res_features: strdup failed");
+				ast_log(LOG_ERROR, "res_features: strdup failed\n");
 				continue;
 			}
 			

Modified: branches/1.2/res/res_monitor.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/res/res_monitor.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/res/res_monitor.c (original)
+++ branches/1.2/res/res_monitor.c Thu Sep 28 13:00:30 2006
@@ -298,7 +298,7 @@
 {
 	char tmp[256];
 	if (ast_strlen_zero(fname_base)) {
-		ast_log(LOG_WARNING, "Cannot change monitor filename of channel %s to null", chan->name);
+		ast_log(LOG_WARNING, "Cannot change monitor filename of channel %s to null\n", chan->name);
 		return -1;
 	}
 	

Modified: branches/1.2/res/res_musiconhold.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/res/res_musiconhold.c?rev=43924&r1=43923&r2=43924&view=diff
==============================================================================
--- branches/1.2/res/res_musiconhold.c (original)
+++ branches/1.2/res/res_musiconhold.c Thu Sep 28 13:00:30 2006
@@ -759,7 +759,7 @@
 	
 	files_DIR = opendir(class->dir);
 	if (!files_DIR) {
-		ast_log(LOG_WARNING, "Cannot open dir %s or dir does not exist", class->dir);
+		ast_log(LOG_WARNING, "Cannot open dir %s or dir does not exist\n", class->dir);
 		return -1;
 	}
 
@@ -1218,7 +1218,7 @@
 		res = ast_register_application(app4, moh4_exec, synopsis4, descrip4);
 
 	if (!init_classes(0)) { 	/* No music classes configured, so skip it */
-		ast_log(LOG_WARNING, "No music on hold classes configured, disabling music on hold.");
+		ast_log(LOG_WARNING, "No music on hold classes configured, disabling music on hold.\n");
 	} else {
 		ast_install_music_functions(local_ast_moh_start, local_ast_moh_stop, local_ast_moh_cleanup);
 	}



More information about the asterisk-commits mailing list