[asterisk-commits] russell: branch 1.4 r47391 - in /branches/1.4: apps/ build_tools/ channels/

[asterisk-commits at lists.digium.com]

Author: russell
Date: Thu Nov  9 15:26:27 2006
New Revision: 47391

URL: http://svn.digium.com/view/asterisk?view=rev&rev=47391
Log:
Work around an issue that caused menuselect to display a bogus description for
app_voicemail and chan_zap.  These modules use some preprocessor directives to
determine what it will report to Asterisk as its description.  However, the way
we extract this information from the source files for menuselect is not smart
enough to figure this out.
(issue #8326, #8328)

Modified:
    branches/1.4/apps/app_voicemail.c
    branches/1.4/build_tools/prep_moduledeps
    branches/1.4/channels/chan_zap.c

Modified: branches/1.4/apps/app_voicemail.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_voicemail.c?view=diff&rev=47391&r1=47390&r2=47391
==============================================================================
--- branches/1.4/apps/app_voicemail.c (original)
+++ branches/1.4/apps/app_voicemail.c Thu Nov  9 15:26:27 2006
@@ -8649,6 +8649,10 @@
 }
 
 #endif /* IMAP_STORAGE */
+
+/* This is a workaround so that menuselect displays a proper description
+ * AST_MODULE_INFO(, , "Comedian Mail (Voicemail System)"
+ */
  
 AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_DEFAULT, tdesc,
 		.load = load_module,

Modified: branches/1.4/build_tools/prep_moduledeps
URL: http://svn.digium.com/view/asterisk/branches/1.4/build_tools/prep_moduledeps?view=diff&rev=47391&r1=47390&r2=47391
==============================================================================
--- branches/1.4/build_tools/prep_moduledeps (original)
+++ branches/1.4/build_tools/prep_moduledeps Thu Nov  9 15:26:27 2006
@@ -1,7 +1,7 @@
 #!/bin/sh
 
 get_description() {
-	TDESC=`grep -e AST_MODULE_INFO ${1} | cut -d '"' -f 2`
+	TDESC=`grep -m 1 -e AST_MODULE_INFO ${1} | cut -d '"' -f 2`
 }
 
 process_dir() {

Modified: branches/1.4/channels/chan_zap.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_zap.c?view=diff&rev=47391&r1=47390&r2=47391
==============================================================================
--- branches/1.4/channels/chan_zap.c (original)
+++ branches/1.4/channels/chan_zap.c Thu Nov  9 15:26:27 2006
@@ -11354,6 +11354,10 @@
 	return 0;
 }
 
+/* This is a workaround so that menuselect displays a proper description
+ * AST_MODULE_INFO(, , "Zapata Telephony"
+ */
+
 #ifdef ZAPATA_PRI
 #define tdesc "Zapata Telephony w/PRI"
 #else