[asterisk-commits] trunk r25411 - in /trunk: include/asterisk/pbx.h pbx.c

[asterisk-commits at lists.digium.com]

Author: russell
Date: Mon May  8 05:08:20 2006
New Revision: 25411

URL: http://svn.digium.com/view/asterisk?rev=25411&view=rev
Log:
remove an XXX comment
 - we can't use ast_true here because non-empty strings would no longer be
   evaluated as true
document the return values of pbx_checkcondition() in doxygen format

Modified:
    trunk/include/asterisk/pbx.h
    trunk/pbx.c

Modified: trunk/include/asterisk/pbx.h
URL: http://svn.digium.com/view/asterisk/trunk/include/asterisk/pbx.h?rev=25411&r1=25410&r2=25411&view=diff
==============================================================================
--- trunk/include/asterisk/pbx.h (original)
+++ trunk/include/asterisk/pbx.h Mon May  8 05:08:20 2006
@@ -692,7 +692,14 @@
    particular application with given extension */
 int ast_pbx_outgoing_app(const char *type, int format, void *data, int timeout, const char *app, const char *appdata, int *reason, int sync, const char *cid_num, const char *cid_name, struct ast_variable *vars, const char *account, struct ast_channel **locked_channel);
 
-/* Evaluate a condition for non-falseness and return a boolean */
+/*!
+ * \brief Evaluate a condition
+ *
+ * \retval 0 if the condition is NULL or of zero length
+ * \retval int If the string is an integer, the integer representation of
+ *             the integer is returned
+ * \retval 1 Any other non-empty string
+ */
 int pbx_checkcondition(const char *condition);
 
 /* Functions for returning values from structures */

Modified: trunk/pbx.c
URL: http://svn.digium.com/view/asterisk/trunk/pbx.c?rev=25411&r1=25410&r2=25411&view=diff
==============================================================================
--- trunk/pbx.c (original)
+++ trunk/pbx.c Mon May  8 05:08:20 2006
@@ -5486,7 +5486,7 @@
 		return 0;
 	else if (*condition >= '0' && *condition <= '9')	/* Numbers are evaluated for truth */
 		return atoi(condition);
-	else	/* Strings are true -- XXX maybe use ast_true() ? */
+	else	/* Strings are true */
 		return 1;
 }