[asterisk-commits] branch 1.2 r11503 - in /branches/1.2: ./ cdr/
include/asterisk/ res/
asterisk-commits at lists.digium.com
asterisk-commits at lists.digium.com
Wed Mar 1 10:41:54 MST 2006
Author: tilghman
Date: Wed Mar 1 11:41:52 2006
New Revision: 11503
URL: http://svn.digium.com/view/asterisk?rev=11503&view=rev
Log:
Bug 6615 - Fix 64bit conversion errors by using a long int
Modified:
branches/1.2/cdr.c
branches/1.2/cdr/cdr_manager.c
branches/1.2/cdr/cdr_odbc.c
branches/1.2/cdr/cdr_pgsql.c
branches/1.2/cdr/cdr_tds.c
branches/1.2/include/asterisk/cdr.h
branches/1.2/res/res_config_odbc.c
Modified: branches/1.2/cdr.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/cdr.c?rev=11503&r1=11502&r2=11503&view=diff
==============================================================================
--- branches/1.2/cdr.c (original)
+++ branches/1.2/cdr.c Wed Mar 1 11:41:52 2006
@@ -251,9 +251,9 @@
strftime(workspace, workspacelen, fmt, &tm);
}
} else if (!strcasecmp(name, "duration"))
- snprintf(workspace, workspacelen, "%d", cdr->duration);
+ snprintf(workspace, workspacelen, "%ld", cdr->duration);
else if (!strcasecmp(name, "billsec"))
- snprintf(workspace, workspacelen, "%d", cdr->billsec);
+ snprintf(workspace, workspacelen, "%ld", cdr->billsec);
else if (!strcasecmp(name, "disposition"))
ast_copy_string(workspace, ast_cdr_disp2str(cdr->disposition), workspacelen);
else if (!strcasecmp(name, "amaflags"))
Modified: branches/1.2/cdr/cdr_manager.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/cdr/cdr_manager.c?rev=11503&r1=11502&r2=11503&view=diff
==============================================================================
--- branches/1.2/cdr/cdr_manager.c (original)
+++ branches/1.2/cdr/cdr_manager.c Wed Mar 1 11:41:52 2006
@@ -121,8 +121,8 @@
"StartTime: %s\r\n"
"AnswerTime: %s\r\n"
"EndTime: %s\r\n"
- "Duration: %d\r\n"
- "BillableSeconds: %d\r\n"
+ "Duration: %ld\r\n"
+ "BillableSeconds: %ld\r\n"
"Disposition: %s\r\n"
"AMAFlags: %s\r\n"
"UniqueID: %s\r\n"
Modified: branches/1.2/cdr/cdr_odbc.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/cdr/cdr_odbc.c?rev=11503&r1=11502&r2=11503&view=diff
==============================================================================
--- branches/1.2/cdr/cdr_odbc.c (original)
+++ branches/1.2/cdr/cdr_odbc.c Wed Mar 1 11:41:52 2006
@@ -122,7 +122,7 @@
if ((ODBC_res != SQL_SUCCESS) && (ODBC_res != SQL_SUCCESS_WITH_INFO)) {
if (option_verbose > 10)
ast_verbose( VERBOSE_PREFIX_4 "cdr_odbc: Failure in AllocStatement %d\n", ODBC_res);
- SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, ODBC_stat, &ODBC_err, ODBC_msg, 100, &ODBC_mlen);
+ SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, (unsigned char *)ODBC_stat, &ODBC_err, (unsigned char *)ODBC_msg, 100, &ODBC_mlen);
SQLFreeHandle(SQL_HANDLE_STMT, ODBC_stmt);
connected = 0;
ast_mutex_unlock(&odbc_lock);
@@ -133,12 +133,12 @@
strange reason if I don't it blows holes in memory like
like a shotgun. So we just do this so its safe. */
- ODBC_res = SQLPrepare(ODBC_stmt, sqlcmd, SQL_NTS);
+ ODBC_res = SQLPrepare(ODBC_stmt, (unsigned char *)sqlcmd, SQL_NTS);
if ((ODBC_res != SQL_SUCCESS) && (ODBC_res != SQL_SUCCESS_WITH_INFO)) {
if (option_verbose > 10)
ast_verbose( VERBOSE_PREFIX_4 "cdr_odbc: Error in PREPARE %d\n", ODBC_res);
- SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, ODBC_stat, &ODBC_err, ODBC_msg, 100, &ODBC_mlen);
+ SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, (unsigned char *)ODBC_stat, &ODBC_err, (unsigned char *)ODBC_msg, 100, &ODBC_mlen);
SQLFreeHandle(SQL_HANDLE_STMT, ODBC_stmt);
connected = 0;
ast_mutex_unlock(&odbc_lock);
@@ -381,7 +381,7 @@
if ((ODBC_res != SQL_SUCCESS) && (ODBC_res != SQL_SUCCESS_WITH_INFO)) {
if (option_verbose > 10)
ast_verbose( VERBOSE_PREFIX_4 "cdr_odbc: Error in Query %d\n", ODBC_res);
- SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, ODBC_stat, &ODBC_err, ODBC_msg, 100, &ODBC_mlen);
+ SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, (unsigned char *)ODBC_stat, &ODBC_err, (unsigned char *)ODBC_msg, 100, &ODBC_mlen);
SQLFreeHandle(SQL_HANDLE_STMT, ODBC_stmt);
connected = 0;
return -1;
@@ -438,7 +438,7 @@
if ((ODBC_res != SQL_SUCCESS) && (ODBC_res != SQL_SUCCESS_WITH_INFO)) {
if (option_verbose > 10)
ast_verbose( VERBOSE_PREFIX_4 "cdr_odbc: Error SQLConnect %d\n", ODBC_res);
- SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, ODBC_stat, &ODBC_err, ODBC_msg, 100, &ODBC_mlen);
+ SQLGetDiagRec(SQL_HANDLE_DBC, ODBC_con, 1, (unsigned char *)ODBC_stat, &ODBC_err, (unsigned char *)ODBC_msg, 100, &ODBC_mlen);
SQLFreeHandle(SQL_HANDLE_ENV, ODBC_env);
connected = 0;
return -1;
Modified: branches/1.2/cdr/cdr_pgsql.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/cdr/cdr_pgsql.c?rev=11503&r1=11502&r2=11503&view=diff
==============================================================================
--- branches/1.2/cdr/cdr_pgsql.c (original)
+++ branches/1.2/cdr/cdr_pgsql.c Wed Mar 1 11:41:52 2006
@@ -122,7 +122,7 @@
snprintf(sqlcmd,sizeof(sqlcmd),"INSERT INTO %s (calldate,clid,src,dst,dcontext,channel,dstchannel,"
"lastapp,lastdata,duration,billsec,disposition,amaflags,accountcode,uniqueid,userfield) VALUES"
- " ('%s','%s','%s','%s','%s', '%s','%s','%s','%s',%d,%d,'%s',%d,'%s','%s','%s')",
+ " ('%s','%s','%s','%s','%s', '%s','%s','%s','%s',%ld,%ld,'%s',%ld,'%s','%s','%s')",
table,timestr,clid,cdr->src, cdr->dst, dcontext,channel, dstchannel, lastapp, lastdata,
cdr->duration,cdr->billsec,ast_cdr_disp2str(cdr->disposition),cdr->amaflags, cdr->accountcode, uniqueid, userfield);
Modified: branches/1.2/cdr/cdr_tds.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/cdr/cdr_tds.c?rev=11503&r1=11502&r2=11503&view=diff
==============================================================================
--- branches/1.2/cdr/cdr_tds.c (original)
+++ branches/1.2/cdr/cdr_tds.c Wed Mar 1 11:41:52 2006
@@ -169,8 +169,8 @@
"%s, " /* start */
"%s, " /* answer */
"%s, " /* end */
- "%d, " /* duration */
- "%d, " /* billsec */
+ "%ld, " /* duration */
+ "%ld, " /* billsec */
"'%s', " /* disposition */
"'%s', " /* amaflags */
"'%s'" /* uniqueid */
Modified: branches/1.2/include/asterisk/cdr.h
URL: http://svn.digium.com/view/asterisk/branches/1.2/include/asterisk/cdr.h?rev=11503&r1=11502&r2=11503&view=diff
==============================================================================
--- branches/1.2/include/asterisk/cdr.h (original)
+++ branches/1.2/include/asterisk/cdr.h Wed Mar 1 11:41:52 2006
@@ -74,13 +74,13 @@
struct timeval end;
/*! Total time in system, in seconds */
- int duration;
+ long int duration;
/*! Total time call is up, in seconds */
- int billsec;
+ long int billsec;
/*! What happened to the call */
- int disposition;
+ long int disposition;
/*! What flags to use */
- int amaflags;
+ long int amaflags;
/*! What account number to use */
char accountcode[AST_MAX_ACCOUNT_CODE];
/*! flags */
Modified: branches/1.2/res/res_config_odbc.c
URL: http://svn.digium.com/view/asterisk/branches/1.2/res/res_config_odbc.c?rev=11503&r1=11502&r2=11503&view=diff
==============================================================================
--- branches/1.2/res/res_config_odbc.c (original)
+++ branches/1.2/res/res_config_odbc.c Wed Mar 1 11:41:52 2006
@@ -103,7 +103,7 @@
newval = va_arg(aq, const char *);
}
va_end(aq);
- res = SQLPrepare(stmt, sql, SQL_NTS);
+ res = SQLPrepare(stmt, (unsigned char *)sql, SQL_NTS);
if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
ast_log(LOG_WARNING, "SQL Prepare failed![%s]\n", sql);
SQLFreeHandle (SQL_HANDLE_STMT, stmt);
@@ -146,7 +146,7 @@
for (x=0;x<colcount;x++) {
rowdata[0] = '\0';
collen = sizeof(coltitle);
- res = SQLDescribeCol(stmt, x + 1, coltitle, sizeof(coltitle), &collen,
+ res = SQLDescribeCol(stmt, x + 1, (unsigned char *)coltitle, sizeof(coltitle), &collen,
&datatype, &colsize, &decimaldigits, &nullable);
if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
ast_log(LOG_WARNING, "SQL Describe Column error!\n[%s]\n\n", sql);
@@ -249,7 +249,7 @@
if (initfield)
snprintf(sql + strlen(sql), sizeof(sql) - strlen(sql), " ORDER BY %s", initfield);
va_end(aq);
- res = SQLPrepare(stmt, sql, SQL_NTS);
+ res = SQLPrepare(stmt, (unsigned char *)sql, SQL_NTS);
if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
ast_log(LOG_WARNING, "SQL Prepare failed![%s]\n", sql);
SQLFreeHandle (SQL_HANDLE_STMT, stmt);
@@ -300,7 +300,7 @@
for (x=0;x<colcount;x++) {
rowdata[0] = '\0';
collen = sizeof(coltitle);
- res = SQLDescribeCol(stmt, x + 1, coltitle, sizeof(coltitle), &collen,
+ res = SQLDescribeCol(stmt, x + 1, (unsigned char *)coltitle, sizeof(coltitle), &collen,
&datatype, &colsize, &decimaldigits, &nullable);
if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
ast_log(LOG_WARNING, "SQL Describe Column error!\n[%s]\n\n", sql);
@@ -376,7 +376,7 @@
va_end(aq);
snprintf(sql + strlen(sql), sizeof(sql) - strlen(sql), " WHERE %s=?", keyfield);
- res = SQLPrepare(stmt, sql, SQL_NTS);
+ res = SQLPrepare(stmt, (unsigned char *)sql, SQL_NTS);
if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
ast_log(LOG_WARNING, "SQL Prepare failed![%s]\n", sql);
SQLFreeHandle (SQL_HANDLE_STMT, stmt);
More information about the asterisk-commits
mailing list