[asterisk-commits] trunk r31841 - /trunk/channels/chan_sip.c

[asterisk-commits at lists.digium.com]

Author: rizzo
Date: Sat Jun  3 17:18:41 2006
New Revision: 31841

URL: http://svn.digium.com/view/asterisk?rev=31841&view=rev
Log:
mark XXX a bug in the code. oej/kevin, any idea what you want
to use here ?


Modified:
    trunk/channels/chan_sip.c

Modified: trunk/channels/chan_sip.c
URL: http://svn.digium.com/view/asterisk/trunk/channels/chan_sip.c?rev=31841&r1=31840&r2=31841&view=diff
==============================================================================
--- trunk/channels/chan_sip.c (original)
+++ trunk/channels/chan_sip.c Sat Jun  3 17:18:41 2006
@@ -7331,6 +7331,10 @@
 			if ((ptr = strchr(referdata->replaces_callid, ';'))) 	/* Remove options */ {
 				*ptr = '\0';
 			}
+			/*
+			 * XXX don't know what was the intention but this code is
+			 * definitely wrong, as ptr can be NULL here.
+			 */
 			ptr++;
 
 			/* Find the different tags before we destroy the string */