[asterisk-commits] kpfleming: branch 1.4 r48521 - in /branches/1.4: ./ include/ main/stdtime/

[asterisk-commits at lists.digium.com]

Author: kpfleming
Date: Sat Dec 16 14:12:41 2006
New Revision: 48521

URL: http://svn.digium.com/view/asterisk?view=rev&rev=48521
Log:
since we really, really have to have autoconfig.h included before all other headers (especially system headers), the Makefile will now force it to happen (this will fix build problems with files like ast_expr2f.c, where we can't control the inclusion order in the file itself)

Modified:
    branches/1.4/Makefile
    branches/1.4/include/asterisk.h
    branches/1.4/main/stdtime/localtime.c

Modified: branches/1.4/Makefile
URL: http://svn.digium.com/view/asterisk/branches/1.4/Makefile?view=diff&rev=48521&r1=48520&r2=48521
==============================================================================
--- branches/1.4/Makefile (original)
+++ branches/1.4/Makefile Sat Dec 16 14:12:41 2006
@@ -180,6 +180,8 @@
 endif
 
 ASTCFLAGS+=-pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations $(DEBUG)
+
+ASTCFLAGS+=-include $(ASTTOPDIR)/include/asterisk/autoconfig.h
 
 ifeq ($(AST_DEVMODE),yes)
   ASTCFLAGS+=-Werror -Wunused

Modified: branches/1.4/include/asterisk.h
URL: http://svn.digium.com/view/asterisk/branches/1.4/include/asterisk.h?view=diff&rev=48521&r1=48520&r2=48521
==============================================================================
--- branches/1.4/include/asterisk.h (original)
+++ branches/1.4/include/asterisk.h Sat Dec 16 14:12:41 2006
@@ -18,6 +18,13 @@
 #ifndef _ASTERISK_H
 #define _ASTERISK_H
 
+/* The include of 'autoconfig.h' is not necessary for any modules that
+   are part of the Asterisk source tree, because the top-level Makefile
+   will forcibly include that header in all compilations before all
+   other headers (even system headers). However, leaving this here will
+   help out-of-tree module builders, and doesn't cause any harm for the
+   in-tree modules.
+*/
 #include "asterisk/autoconfig.h"
 
 #include "asterisk/compat.h"

Modified: branches/1.4/main/stdtime/localtime.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/stdtime/localtime.c?view=diff&rev=48521&r1=48520&r2=48521
==============================================================================
--- branches/1.4/main/stdtime/localtime.c (original)
+++ branches/1.4/main/stdtime/localtime.c Sat Dec 16 14:12:41 2006
@@ -43,10 +43,6 @@
 #define TZ_STRLEN_MAX	255
 /* #define DEBUG */
 
-#include "asterisk.h"
- 
-ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
-
 /*LINTLIBRARY*/
 
 #include <sys/types.h>
@@ -58,9 +54,13 @@
 
 #include "private.h"
 #include "tzfile.h"
+
+#include "asterisk.h"
+
+ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
+
 #include "asterisk/lock.h"
 #include "asterisk/localtime.h"
-
 
 #ifndef lint
 #ifndef NOID