[asterisk-commits] trunk r17028 - /trunk/manager.c

asterisk-commits at lists.digium.com asterisk-commits at lists.digium.com
Mon Apr 3 00:30:08 MST 2006


Author: tilghman
Date: Mon Apr  3 02:30:07 2006
New Revision: 17028

URL: http://svn.digium.com/view/asterisk?rev=17028&view=rev
Log:
Bug 6862 - No need to initialize memory to zero twice

Modified:
    trunk/manager.c

Modified: trunk/manager.c
URL: http://svn.digium.com/view/asterisk/trunk/manager.c?rev=17028&r1=17027&r2=17028&view=diff
==============================================================================
--- trunk/manager.c (original)
+++ trunk/manager.c Mon Apr  3 02:30:07 2006
@@ -2358,7 +2358,6 @@
 		ast_log(LOG_NOTICE, "Unable to open management configuration manager.conf.  Call management disabled.\n");
 		return 0;
 	}
-	memset(&ba, 0, sizeof(ba));
 	val = ast_variable_retrieve(cfg, "general", "enabled");
 	if (val)
 		enabled = ast_true(val);
@@ -2386,11 +2385,11 @@
 
 	if ((val = ast_variable_retrieve(cfg, "general", "httptimeout")))
 		newhttptimeout = atoi(val);
-	
+
+	memset(&ba, 0, sizeof(ba));
 	ba.sin_family = AF_INET;
 	ba.sin_port = htons(portno);
-	memset(&ba.sin_addr, 0, sizeof(ba.sin_addr));
-	
+
 	if ((val = ast_variable_retrieve(cfg, "general", "bindaddr"))) {
 		if (!inet_aton(val, &ba.sin_addr)) { 
 			ast_log(LOG_WARNING, "Invalid address '%s' specified, using 0.0.0.0\n", val);



More information about the asterisk-commits mailing list