<p> Attention is currently required from: Jaco Kroon. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/20024">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/calendar.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/20024/comment/ff1e3462_c27bc706">Patch Set #3, Line 207:</a> <code style="font-family:monospace,monospace"> * \param The busy_state value to obtain a string for.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is not the correct doxygen syntax. You need to include the parameter name (see `ast_calendar_merge_events` for an example).</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/20024/comment/75126698_d36bbed4">Patch Set #3, Line 209:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">, or NULL if the input<br> *   value isn't one of the pre-defined values<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This will need to be updated assuming you make the change I suggested to the implementation.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_calendar.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/20024/comment/bdd550ab_e1370b45">Patch Set #2, Line 369:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">default:<br>            return NULL;<br></pre></blockquote></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Elsewhere in the code BUSYSTATE comes from what I would consider an "untrusted source" and is processed with atol(), so what if BUSYSTATE:-1 or BUSYSTATE:3 comes our way?  What if the specification (unlikely) gets expanded?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Then just return "Unknown (Busy)" directly instead of making the calling code responsible for it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/20024">change 20024</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/20024"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I894e4ecc3e93db4ff7783d46266ba3c5e6ccda10 </div>
<div style="display:none"> Gerrit-Change-Number: 20024 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 23 Mar 2023 14:36:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Comment-In-Reply-To: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>